[GitHub] [geode] bschuchardt commented on a change in pull request #5669: GEODE-8665: handling exception on SNIHostName

[GitBox <gi...@apache.org>]

bschuchardt commented on a change in pull request #5669:
URL: https://github.com/apache/geode/pull/5669#discussion_r512323375



##########
File path: geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java
##########
@@ -846,7 +846,14 @@ private boolean setServerNames(SSLParameters modifiedParams, HostAndPort addr) {
         // ignore - we'll see what happens with endpoint validation using a numeric address...
       }
     }
-    serverNames.add(new SNIHostName(hostName));
+    try {
+      serverNames.add(new SNIHostName(hostName));
+    } catch (Exception ex) {

Review comment:
       If we can't establish the SNI field as requested shouldn't we throw an informative exception?   If you throw an SSLException, for instance, ConnectionFactoryImpl will catch it and log it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org