You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "nsivabalan (via GitHub)" <gi...@apache.org> on 2024/10/13 17:01:31 UTC

[PR] [HUDI-8342] Throwing exception for partition stats instantiation for non partitioned table [hudi]

nsivabalan opened a new pull request, #12089:
URL: https://github.com/apache/hudi/pull/12089

   ### Change Logs
   
   Throwing exception for partition stats instantiation for non partitioned table
   
   ### Impact
   
   Throwing exception for partition stats instantiation for non partitioned table
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8342] Throwing exception for partition stats instantiation for non partitioned table [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12089:
URL: https://github.com/apache/hudi/pull/12089#issuecomment-2414125629

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1104",
       "triggerID" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4dbdce94dac9f63d33958dafca44f178de51a1be",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1147",
       "triggerID" : "4dbdce94dac9f63d33958dafca44f178de51a1be",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * acffc7ab40498224bc67e64dd5f23860cf935ebe Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1104) 
   * 4dbdce94dac9f63d33958dafca44f178de51a1be Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1147) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8342] Log warning and skip building partition stats for non partitioned table [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12089:
URL: https://github.com/apache/hudi/pull/12089#issuecomment-2414532623

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1104",
       "triggerID" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4dbdce94dac9f63d33958dafca44f178de51a1be",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1147",
       "triggerID" : "4dbdce94dac9f63d33958dafca44f178de51a1be",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6358b874fff992c6a8767329bd2252b5416b7f6a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1149",
       "triggerID" : "6358b874fff992c6a8767329bd2252b5416b7f6a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6358b874fff992c6a8767329bd2252b5416b7f6a Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1149) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8342] Throwing exception for partition stats instantiation for non partitioned table [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12089:
URL: https://github.com/apache/hudi/pull/12089#issuecomment-2409051876

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1104",
       "triggerID" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * acffc7ab40498224bc67e64dd5f23860cf935ebe Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1104) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8342] Log warning and skip building partition stats for non partitioned table [hudi]

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #12089:
URL: https://github.com/apache/hudi/pull/12089#issuecomment-2414697977

   <img width="1228" alt="image" src="https://github.com/user-attachments/assets/48d1d5e4-cc53-4383-b62f-d2225da59a62">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8342] Log warning and skip building partition stats for non partitioned table [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12089:
URL: https://github.com/apache/hudi/pull/12089#issuecomment-2414186403

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1104",
       "triggerID" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4dbdce94dac9f63d33958dafca44f178de51a1be",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1147",
       "triggerID" : "4dbdce94dac9f63d33958dafca44f178de51a1be",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6358b874fff992c6a8767329bd2252b5416b7f6a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6358b874fff992c6a8767329bd2252b5416b7f6a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * acffc7ab40498224bc67e64dd5f23860cf935ebe Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1104) 
   * 4dbdce94dac9f63d33958dafca44f178de51a1be Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1147) 
   * 6358b874fff992c6a8767329bd2252b5416b7f6a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8342] Log warning and skip building partition stats for non partitioned table [hudi]

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan merged PR #12089:
URL: https://github.com/apache/hudi/pull/12089


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8342] Throwing exception for partition stats instantiation for non partitioned table [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12089:
URL: https://github.com/apache/hudi/pull/12089#issuecomment-2409077255

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1104",
       "triggerID" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * acffc7ab40498224bc67e64dd5f23860cf935ebe Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1104) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8342] Throwing exception for partition stats instantiation for non partitioned table [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12089:
URL: https://github.com/apache/hudi/pull/12089#issuecomment-2414122070

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1104",
       "triggerID" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4dbdce94dac9f63d33958dafca44f178de51a1be",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4dbdce94dac9f63d33958dafca44f178de51a1be",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * acffc7ab40498224bc67e64dd5f23860cf935ebe Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1104) 
   * 4dbdce94dac9f63d33958dafca44f178de51a1be UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8342] Log warning and skip building partition stats for non partitioned table [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12089:
URL: https://github.com/apache/hudi/pull/12089#issuecomment-2414374789

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1104",
       "triggerID" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4dbdce94dac9f63d33958dafca44f178de51a1be",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1147",
       "triggerID" : "4dbdce94dac9f63d33958dafca44f178de51a1be",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6358b874fff992c6a8767329bd2252b5416b7f6a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1149",
       "triggerID" : "6358b874fff992c6a8767329bd2252b5416b7f6a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4dbdce94dac9f63d33958dafca44f178de51a1be Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1147) 
   * 6358b874fff992c6a8767329bd2252b5416b7f6a Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1149) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8342] Throwing exception for partition stats instantiation for non partitioned table [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12089:
URL: https://github.com/apache/hudi/pull/12089#issuecomment-2409051439

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * acffc7ab40498224bc67e64dd5f23860cf935ebe UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8342] Throwing exception for partition stats instantiation for non partitioned table [hudi]

Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on PR #12089:
URL: https://github.com/apache/hudi/pull/12089#issuecomment-2411989975

   > Should we skip building partition stats index for non-partitioned table instead of throwing an error?
   
   Since we want to keep partition stats enabled by default, I think it makes sense to log a warning and skip building instead of failing. Otherwise, many new users will try out Hudi on non-partitioned table and they will have to manually disable it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8342] Throwing exception for partition stats instantiation for non partitioned table [hudi]

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #12089:
URL: https://github.com/apache/hudi/pull/12089#issuecomment-2412022201

   partition stats is not enabled by default. So, I don't see it a strong reason from usability standup. 
   but I am open to logging a warning and not throw an exception. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-8342] Log warning and skip building partition stats for non partitioned table [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12089:
URL: https://github.com/apache/hudi/pull/12089#issuecomment-2414190385

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1104",
       "triggerID" : "acffc7ab40498224bc67e64dd5f23860cf935ebe",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4dbdce94dac9f63d33958dafca44f178de51a1be",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1147",
       "triggerID" : "4dbdce94dac9f63d33958dafca44f178de51a1be",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6358b874fff992c6a8767329bd2252b5416b7f6a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6358b874fff992c6a8767329bd2252b5416b7f6a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4dbdce94dac9f63d33958dafca44f178de51a1be Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=1147) 
   * 6358b874fff992c6a8767329bd2252b5416b7f6a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org