You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2016/11/16 21:29:40 UTC
[GitHub] nifi pull request #1236: LDAP - Configurable strategy to identify users
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1236
LDAP - Configurable strategy to identify users
NIFI-3020:
- Introducing a user identity strategy for identifying users.
- Fixing issue with the referral strategy error message.
- Adding code to shutdown the application when the authorizer or login identity provider are not initialized successfully.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-3020
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1236.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1236
----
commit 252e3bae209bb7d4365dd28dded7e72048e38e41
Author: Matt Gilman <ma...@gmail.com>
Date: 2016-11-16T21:29:14Z
NIFI-3020:
- Introducing a strategy for identifying users.
- Fixing issue with the referral strategy error message.
- Adding code to shutdown the application when the authorizer or login identity provider are not initialized successfully.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1236: LDAP - Configurable strategy to identify users
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1236
Reviewing..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1236: LDAP - Configurable strategy to identify users
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1236: LDAP - Configurable strategy to identify users
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1236#discussion_r88742365
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/contextlistener/ApplicationStartupContextListener.java ---
@@ -121,4 +111,16 @@ public void contextDestroyed(ServletContextEvent sce) {
}
}
}
+
+ private void shutdown(final FlowService flowService, final RequestReplicator requestReplicator) {
+ // ensure the flow service is terminated
+ if (flowService != null && flowService.isRunning()) {
+ flowService.stop(false);
+ }
+
+ // ensure the request replicator is shutdown
+ if (requestReplicator != null) {
+ requestReplicator.shutdown();
+ }
--- End diff --
Good call. I'll update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1236: LDAP - Configurable strategy to identify users
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1236
I tested it with OpenLDAP
- Tested the default behavior, DN was used as NiFi user identifier
- Tested with USE_USERNAME, the username which was input at the login window was used as NiFi user identifier
Works as expected. The change looks good.
However I think `administration-guide.adoc` in nifi-docs project should be updated with the newly added `Identity Strategy` setting. [NiFi System Administrator\u2019s Guide](https://nifi.apache.org/docs/nifi-docs/html/administration-guide.html#lightweight-directory-access-protocol-ldap).
Once the doc has been updated, I'd +1
Thanks @mcgilman !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1236: LDAP - Configurable strategy to identify users
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1236#discussion_r88571378
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/contextlistener/ApplicationStartupContextListener.java ---
@@ -121,4 +111,16 @@ public void contextDestroyed(ServletContextEvent sce) {
}
}
}
+
+ private void shutdown(final FlowService flowService, final RequestReplicator requestReplicator) {
+ // ensure the flow service is terminated
+ if (flowService != null && flowService.isRunning()) {
+ flowService.stop(false);
+ }
+
+ // ensure the request replicator is shutdown
+ if (requestReplicator != null) {
+ requestReplicator.shutdown();
+ }
--- End diff --
Shouldn't _stop_ and _shutdown_ be guarded against exception (wrapped try/catch). I mean if something happens in _stop_, _shutdown_ won't execute. Not sure if that's ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1236: LDAP - Configurable strategy to identify users
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/1236
I am +1 now. If @ijokarumawak has no issues let's merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1236: LDAP - Configurable strategy to identify users
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1236
@mcgilman Thanks for updating the docs! Exception handling at shutdown looks good. +1
Would you squash the commits to get it merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1236: LDAP - Configurable strategy to identify users
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1236
Good call. I've updated the Admin Guide in a second commit. Thanks @ijokarumawak!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1236: LDAP - Configurable strategy to identify users
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/1236
@mcgilman @ijokarumawak squashing and merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---