You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by Philipp Zehnder <ze...@apache.org> on 2020/02/04 16:00:07 UTC
Refactor MQTT based adapters
Hi all,
since we have multiple adapters that use MQTT I created a utils class with all the code required for the configuration parameters.
One of the new adapters is the NetioMQTTAdapter. The adapter itself works, but the labels are not shown in the UI.
Maybe someone knows what the problem could be?
It works when I use the old labels with Labels.from.
When I use the new labels with Labels.withId it does not work. I think the problem is with the alternative static properties, since it also works when I remove them from the adapter description.
Please write if anyone has a hint what the problem might be.
Philipp
Re: Refactor MQTT based adapters
Posted by Philipp Zehnder <ze...@apache.org>.
Hi Johannes,
thank you for your help on the problem. I tested it on my computer and everything works as expected and I merged the branch into dev.
I added a comment to the issue [1] regarding the problem with the strings.en files.
Philipp
> On 5. Feb 2020, at 01:16, Johannes Tex <te...@apache.org> wrote:
>
> Hi,
>
> this is not the best solution but I think there is no other way at the moment. In my opinion it would be great if we could create a strings.en file specific for the MQTTUtil and all Adapters that use MQTTUtil import this file addition to the Adapter specific string files.
>
> For now I created Assets for all MQTT Adapters and the Procotol (See Branch: netio).
>
> P.S. I found a bug to get the protocol assets (e.g. the icons of protocols were not displayed when coming from the backend), but this is fixed now.
>
> Johannes
>
>
> On 2020/02/04 21:39:40, Philipp Zehnder <ze...@fzi.de> wrote:
>> Hi,
>>
>> Ah ok. But then we have the problem I described in Issue [1] in the comments field.
>> For your solution we have to edit all the strings.en files that are using the MQTT configurations. I think this solution is very error prone, but for now I do not have a better solution so it would be great if you could commit your changes.
>>
>> What I do not understand is, why the TISensorTag adapter worked with the Labels.from version of the MQTT Utils class?
>>
>>
>>
>>
>> [1] https://issues.apache.org/jira/projects/STREAMPIPES/issues/STREAMPIPES-69?filter=allopenissues&orderby=created+DESC%2C+priority+DESC%2C+updated+DESC <https://issues.apache.org/jira/projects/STREAMPIPES/issues/STREAMPIPES-69?filter=allopenissues&orderby=created+DESC,+priority+DESC,+updated+DESC>
>>
>>> On 4. Feb 2020, at 22:30, Johannes Tex <te...@apache.org> wrote:
>>>
>>> Hi Philipp,
>>>
>>> yes, on my computer it is working.
>>> I changed in the MQTT utils class to Labels.withId and added the string in the string.en file.
>>> If you like i can commit it and you can try at your machine.
>>>
>>> Johannes
>>>
>>> On 2020/02/04 21:10:01, Philipp Zehnder <ze...@apache.org> wrote:
>>>> Hi,
>>>>
>>>> @Johannes: Does it work on your machine? It still does not work on my computer.
>>>> The commit you mentioned was to fix a bug that occurred when the component started. The problem is that the labels are not shown in the UI. See the attached screenshot.
>>>>
>>>>
>>>>
>>>>> On 4. Feb 2020, at 21:20, Dominik Riemer <ri...@apache.org> wrote:
>>>>>
>>>>> Great!
>>>>> So I guess this was just Philipp's way to ask for a code review :D
>>>>>
>>>>> -----Original Message-----
>>>>> From: Johannes Tex <te...@apache.org>
>>>>> Sent: Tuesday, February 4, 2020 9:16 PM
>>>>> To: dev@streampipes.apache.org
>>>>> Subject: Re: Refactor MQTT based adapters
>>>>>
>>>>> Hi Philipp
>>>>>
>>>>> I took a quick look and tried to use the NetioMQTTAdapter with "Labels.withId". It has worked as expected. I guess you already fixed it with your commit "Add null check for alternative labels in label generator" :)
>>>>>
>>>>> Johannes
>>>>>
>>>>> On 2020/02/04 16:00:07, Philipp Zehnder <ze...@apache.org> wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> since we have multiple adapters that use MQTT I created a utils class with all the code required for the configuration parameters.
>>>>>> One of the new adapters is the NetioMQTTAdapter. The adapter itself works, but the labels are not shown in the UI.
>>>>>>
>>>>>> Maybe someone knows what the problem could be?
>>>>>> It works when I use the old labels with Labels.from.
>>>>>> When I use the new labels with Labels.withId it does not work. I think the problem is with the alternative static properties, since it also works when I remove them from the adapter description.
>>>>>> Please write if anyone has a hint what the problem might be.
>>>>>>
>>>>>>
>>>>>> Philipp
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>
>>
Re: Refactor MQTT based adapters
Posted by Johannes Tex <te...@apache.org>.
Hi,
this is not the best solution but I think there is no other way at the moment. In my opinion it would be great if we could create a strings.en file specific for the MQTTUtil and all Adapters that use MQTTUtil import this file addition to the Adapter specific string files.
For now I created Assets for all MQTT Adapters and the Procotol (See Branch: netio).
P.S. I found a bug to get the protocol assets (e.g. the icons of protocols were not displayed when coming from the backend), but this is fixed now.
Johannes
On 2020/02/04 21:39:40, Philipp Zehnder <ze...@fzi.de> wrote:
> Hi,
>
> Ah ok. But then we have the problem I described in Issue [1] in the comments field.
> For your solution we have to edit all the strings.en files that are using the MQTT configurations. I think this solution is very error prone, but for now I do not have a better solution so it would be great if you could commit your changes.
>
> What I do not understand is, why the TISensorTag adapter worked with the Labels.from version of the MQTT Utils class?
>
>
>
>
> [1] https://issues.apache.org/jira/projects/STREAMPIPES/issues/STREAMPIPES-69?filter=allopenissues&orderby=created+DESC%2C+priority+DESC%2C+updated+DESC <https://issues.apache.org/jira/projects/STREAMPIPES/issues/STREAMPIPES-69?filter=allopenissues&orderby=created+DESC,+priority+DESC,+updated+DESC>
>
> > On 4. Feb 2020, at 22:30, Johannes Tex <te...@apache.org> wrote:
> >
> > Hi Philipp,
> >
> > yes, on my computer it is working.
> > I changed in the MQTT utils class to Labels.withId and added the string in the string.en file.
> > If you like i can commit it and you can try at your machine.
> >
> > Johannes
> >
> > On 2020/02/04 21:10:01, Philipp Zehnder <ze...@apache.org> wrote:
> >> Hi,
> >>
> >> @Johannes: Does it work on your machine? It still does not work on my computer.
> >> The commit you mentioned was to fix a bug that occurred when the component started. The problem is that the labels are not shown in the UI. See the attached screenshot.
> >>
> >>
> >>
> >>> On 4. Feb 2020, at 21:20, Dominik Riemer <ri...@apache.org> wrote:
> >>>
> >>> Great!
> >>> So I guess this was just Philipp's way to ask for a code review :D
> >>>
> >>> -----Original Message-----
> >>> From: Johannes Tex <te...@apache.org>
> >>> Sent: Tuesday, February 4, 2020 9:16 PM
> >>> To: dev@streampipes.apache.org
> >>> Subject: Re: Refactor MQTT based adapters
> >>>
> >>> Hi Philipp
> >>>
> >>> I took a quick look and tried to use the NetioMQTTAdapter with "Labels.withId". It has worked as expected. I guess you already fixed it with your commit "Add null check for alternative labels in label generator" :)
> >>>
> >>> Johannes
> >>>
> >>> On 2020/02/04 16:00:07, Philipp Zehnder <ze...@apache.org> wrote:
> >>>> Hi all,
> >>>>
> >>>> since we have multiple adapters that use MQTT I created a utils class with all the code required for the configuration parameters.
> >>>> One of the new adapters is the NetioMQTTAdapter. The adapter itself works, but the labels are not shown in the UI.
> >>>>
> >>>> Maybe someone knows what the problem could be?
> >>>> It works when I use the old labels with Labels.from.
> >>>> When I use the new labels with Labels.withId it does not work. I think the problem is with the alternative static properties, since it also works when I remove them from the adapter description.
> >>>> Please write if anyone has a hint what the problem might be.
> >>>>
> >>>>
> >>>> Philipp
> >>>>
> >>>>
> >>>>
> >>>
> >>
> >>
>
>
Re: Refactor MQTT based adapters
Posted by Philipp Zehnder <ze...@fzi.de>.
Hi,
Ah ok. But then we have the problem I described in Issue [1] in the comments field.
For your solution we have to edit all the strings.en files that are using the MQTT configurations. I think this solution is very error prone, but for now I do not have a better solution so it would be great if you could commit your changes.
What I do not understand is, why the TISensorTag adapter worked with the Labels.from version of the MQTT Utils class?
[1] https://issues.apache.org/jira/projects/STREAMPIPES/issues/STREAMPIPES-69?filter=allopenissues&orderby=created+DESC%2C+priority+DESC%2C+updated+DESC <https://issues.apache.org/jira/projects/STREAMPIPES/issues/STREAMPIPES-69?filter=allopenissues&orderby=created+DESC,+priority+DESC,+updated+DESC>
> On 4. Feb 2020, at 22:30, Johannes Tex <te...@apache.org> wrote:
>
> Hi Philipp,
>
> yes, on my computer it is working.
> I changed in the MQTT utils class to Labels.withId and added the string in the string.en file.
> If you like i can commit it and you can try at your machine.
>
> Johannes
>
> On 2020/02/04 21:10:01, Philipp Zehnder <ze...@apache.org> wrote:
>> Hi,
>>
>> @Johannes: Does it work on your machine? It still does not work on my computer.
>> The commit you mentioned was to fix a bug that occurred when the component started. The problem is that the labels are not shown in the UI. See the attached screenshot.
>>
>>
>>
>>> On 4. Feb 2020, at 21:20, Dominik Riemer <ri...@apache.org> wrote:
>>>
>>> Great!
>>> So I guess this was just Philipp's way to ask for a code review :D
>>>
>>> -----Original Message-----
>>> From: Johannes Tex <te...@apache.org>
>>> Sent: Tuesday, February 4, 2020 9:16 PM
>>> To: dev@streampipes.apache.org
>>> Subject: Re: Refactor MQTT based adapters
>>>
>>> Hi Philipp
>>>
>>> I took a quick look and tried to use the NetioMQTTAdapter with "Labels.withId". It has worked as expected. I guess you already fixed it with your commit "Add null check for alternative labels in label generator" :)
>>>
>>> Johannes
>>>
>>> On 2020/02/04 16:00:07, Philipp Zehnder <ze...@apache.org> wrote:
>>>> Hi all,
>>>>
>>>> since we have multiple adapters that use MQTT I created a utils class with all the code required for the configuration parameters.
>>>> One of the new adapters is the NetioMQTTAdapter. The adapter itself works, but the labels are not shown in the UI.
>>>>
>>>> Maybe someone knows what the problem could be?
>>>> It works when I use the old labels with Labels.from.
>>>> When I use the new labels with Labels.withId it does not work. I think the problem is with the alternative static properties, since it also works when I remove them from the adapter description.
>>>> Please write if anyone has a hint what the problem might be.
>>>>
>>>>
>>>> Philipp
>>>>
>>>>
>>>>
>>>
>>
>>
Re: Refactor MQTT based adapters
Posted by Johannes Tex <te...@apache.org>.
Hi Philipp,
yes, on my computer it is working.
I changed in the MQTT utils class to Labels.withId and added the string in the string.en file.
If you like i can commit it and you can try at your machine.
Johannes
On 2020/02/04 21:10:01, Philipp Zehnder <ze...@apache.org> wrote:
> Hi,
>
> @Johannes: Does it work on your machine? It still does not work on my computer.
> The commit you mentioned was to fix a bug that occurred when the component started. The problem is that the labels are not shown in the UI. See the attached screenshot.
>
>
>
> > On 4. Feb 2020, at 21:20, Dominik Riemer <ri...@apache.org> wrote:
> >
> > Great!
> > So I guess this was just Philipp's way to ask for a code review :D
> >
> > -----Original Message-----
> > From: Johannes Tex <te...@apache.org>
> > Sent: Tuesday, February 4, 2020 9:16 PM
> > To: dev@streampipes.apache.org
> > Subject: Re: Refactor MQTT based adapters
> >
> > Hi Philipp
> >
> > I took a quick look and tried to use the NetioMQTTAdapter with "Labels.withId". It has worked as expected. I guess you already fixed it with your commit "Add null check for alternative labels in label generator" :)
> >
> > Johannes
> >
> > On 2020/02/04 16:00:07, Philipp Zehnder <ze...@apache.org> wrote:
> >> Hi all,
> >>
> >> since we have multiple adapters that use MQTT I created a utils class with all the code required for the configuration parameters.
> >> One of the new adapters is the NetioMQTTAdapter. The adapter itself works, but the labels are not shown in the UI.
> >>
> >> Maybe someone knows what the problem could be?
> >> It works when I use the old labels with Labels.from.
> >> When I use the new labels with Labels.withId it does not work. I think the problem is with the alternative static properties, since it also works when I remove them from the adapter description.
> >> Please write if anyone has a hint what the problem might be.
> >>
> >>
> >> Philipp
> >>
> >>
> >>
> >
>
>
Re: Refactor MQTT based adapters
Posted by Philipp Zehnder <ze...@apache.org>.
Hi,
@Johannes: Does it work on your machine? It still does not work on my computer.
The commit you mentioned was to fix a bug that occurred when the component started. The problem is that the labels are not shown in the UI. See the attached screenshot.
> On 4. Feb 2020, at 21:20, Dominik Riemer <ri...@apache.org> wrote:
>
> Great!
> So I guess this was just Philipp's way to ask for a code review :D
>
> -----Original Message-----
> From: Johannes Tex <te...@apache.org>
> Sent: Tuesday, February 4, 2020 9:16 PM
> To: dev@streampipes.apache.org
> Subject: Re: Refactor MQTT based adapters
>
> Hi Philipp
>
> I took a quick look and tried to use the NetioMQTTAdapter with "Labels.withId". It has worked as expected. I guess you already fixed it with your commit "Add null check for alternative labels in label generator" :)
>
> Johannes
>
> On 2020/02/04 16:00:07, Philipp Zehnder <ze...@apache.org> wrote:
>> Hi all,
>>
>> since we have multiple adapters that use MQTT I created a utils class with all the code required for the configuration parameters.
>> One of the new adapters is the NetioMQTTAdapter. The adapter itself works, but the labels are not shown in the UI.
>>
>> Maybe someone knows what the problem could be?
>> It works when I use the old labels with Labels.from.
>> When I use the new labels with Labels.withId it does not work. I think the problem is with the alternative static properties, since it also works when I remove them from the adapter description.
>> Please write if anyone has a hint what the problem might be.
>>
>>
>> Philipp
>>
>>
>>
>
RE: Refactor MQTT based adapters
Posted by Dominik Riemer <ri...@apache.org>.
Great!
So I guess this was just Philipp's way to ask for a code review :D
-----Original Message-----
From: Johannes Tex <te...@apache.org>
Sent: Tuesday, February 4, 2020 9:16 PM
To: dev@streampipes.apache.org
Subject: Re: Refactor MQTT based adapters
Hi Philipp
I took a quick look and tried to use the NetioMQTTAdapter with "Labels.withId". It has worked as expected. I guess you already fixed it with your commit "Add null check for alternative labels in label generator" :)
Johannes
On 2020/02/04 16:00:07, Philipp Zehnder <ze...@apache.org> wrote:
> Hi all,
>
> since we have multiple adapters that use MQTT I created a utils class with all the code required for the configuration parameters.
> One of the new adapters is the NetioMQTTAdapter. The adapter itself works, but the labels are not shown in the UI.
>
> Maybe someone knows what the problem could be?
> It works when I use the old labels with Labels.from.
> When I use the new labels with Labels.withId it does not work. I think the problem is with the alternative static properties, since it also works when I remove them from the adapter description.
> Please write if anyone has a hint what the problem might be.
>
>
> Philipp
>
>
>
Re: Refactor MQTT based adapters
Posted by Johannes Tex <te...@apache.org>.
Hi Philipp
I took a quick look and tried to use the NetioMQTTAdapter with "Labels.withId". It has worked as expected. I guess you already fixed it with your commit "Add null check for alternative labels in label generator" :)
Johannes
On 2020/02/04 16:00:07, Philipp Zehnder <ze...@apache.org> wrote:
> Hi all,
>
> since we have multiple adapters that use MQTT I created a utils class with all the code required for the configuration parameters.
> One of the new adapters is the NetioMQTTAdapter. The adapter itself works, but the labels are not shown in the UI.
>
> Maybe someone knows what the problem could be?
> It works when I use the old labels with Labels.from.
> When I use the new labels with Labels.withId it does not work. I think the problem is with the alternative static properties, since it also works when I remove them from the adapter description.
> Please write if anyone has a hint what the problem might be.
>
>
> Philipp
>
>
>