[GitHub] [flink] reswqa commented on a diff in pull request #21122: [FLINK-28889] Hybrid shuffle supports multiple consumer and broadcast optimization

[GitBox <gi...@apache.org>]

reswqa commented on code in PR #21122:
URL: https://github.com/apache/flink/pull/21122#discussion_r1002986901


##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsMemoryDataManager.java:
##########
@@ -72,8 +73,8 @@ public class HsMemoryDataManager implements HsSpillingInfoProvider, HsMemoryData
 
     private final AtomicInteger numUnSpillBuffers = new AtomicInteger(0);
 
-    private final Map<Integer, HsSubpartitionViewInternalOperations> subpartitionViewOperationsMap =
-            new ConcurrentHashMap<>();
+    private final List<Map<Integer, HsSubpartitionViewInternalOperations>>
+            subpartitionViewOperationsMap;

Review Comment:
   I didn't change the List into an array because I didn't want to introduce a raw type Map.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org