You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/06 02:59:56 UTC

[GitHub] [apisix-go-plugin-runner] ms2008 opened a new issue #57: bug: there is a typo while populating GTASHA

ms2008 opened a new issue #57:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/57


   ### Issue description
   
   There is a typo in this place:
   
   https://github.com/apache/apisix-go-plugin-runner/blob/0cfd47b75a403215e78f78bf468dc4e87f8a6ecf/Makefile#L22
   
   The pipeline here should be logical or operational, which is a double pipe symbol as `||`.
   
   ### Environment
   
   * APISIX Go Plugin Runner's version:
   * APISIX version:
   * Go version:
   * OS (cmd: `uname -a`):
   
   ### Minimal test code / Steps to reproduce the issue
   
   1.
   2.
   3.
   
   ### What's the actual result? (including assertion message & call stack if applicable)
   
   ```
   Version: latest
   Git SHA: 
   Go Version: go1.17.5
   Building OS/Arch: linux/amd64
   Running OS/Arch: linux/amd64
   ```
   
   ### What's the expected result?
   
   ```
   Version: latest
   Git SHA: 0cfd47b
   Go Version: go1.17.5
   Building OS/Arch: linux/amd64
   Running OS/Arch: linux/amd64
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-go-plugin-runner] spacewander closed issue #57: bug: there is a typo while populating GITSHA

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #57:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/57


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-go-plugin-runner] spacewander closed issue #57: bug: there is a typo while populating GITSHA

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #57:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/57


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-go-plugin-runner] spacewander commented on issue #57: bug: there is a typo while populating GITSHA

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #57:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/57#issuecomment-1006310769


   Good catch. PR is welcome!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org