You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/13 23:16:39 UTC

[GitHub] [incubator-gobblin] jack-moseley commented on a change in pull request #2924: [GOBBLIN-1084] Refresh flowgraph when templates are modified

jack-moseley commented on a change in pull request #2924: [GOBBLIN-1084] Refresh flowgraph when templates are modified
URL: https://github.com/apache/incubator-gobblin/pull/2924#discussion_r392524602
 
 

 ##########
 File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GitFlowGraphMonitor.java
 ##########
 @@ -127,6 +128,14 @@ public boolean shouldPollGit() {
    */
   @Override
   void processGitConfigChanges() throws GitAPIException, IOException {
+    if (flowTemplateCatalog.isPresent() && (flowTemplateCatalog.get() instanceof ObservingFSFlowEdgeTemplateCatalog)) {
 
 Review comment:
   I didn't do this since refresh flow graph only makes sense for observing flow catalog, but yeah I guess doing instanceof is not great either so I'll change it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services