You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Rolf Schumacher (JIRA)" <ji...@apache.org> on 2009/12/23 12:19:29 UTC
[jira] Created: (JSPWIKI-620) templates not copied
templates not copied
--------------------
Key: JSPWIKI-620
URL: https://issues.apache.org/jira/browse/JSPWIKI-620
Project: JSPWiki
Issue Type: Bug
Components: Servlet Container/Java compatibility
Affects Versions: 2.8.3
Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
Reporter: Rolf Schumacher
Fix For: 2.8.4
What I did:
checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
What I expected:
to see the Main.txt page
What I got:
a blank window
Workaround:
manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-620) templates not copied
Posted by "Rolf Schumacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794671#action_12794671 ]
Rolf Schumacher commented on JSPWIKI-620:
-----------------------------------------
Hi, Harry,
seems to me as a perfect analysis. Option 1 isn't performed in one go (othewise you would have presented the solution). Option 3 comes with the advantages that it doesn't cost much (just comment out the target), "war-tomcat" can be restored easily (just throw out the text at a later date), and - in case of objection - we may find out why someone favors this kind of installation (what about mass installation of JSPWiki on a number of clients?) in order to document that requirement.
The option of doing nothing seems to me in contradiction with the rest of JSPWikis quality. For the sake of the wiki administrators time it can not be left in. On the other hand this is not really a major issue, if you know the work-around "take the war-target": that is option 3.
> templates not copied
> --------------------
>
> Key: JSPWIKI-620
> URL: https://issues.apache.org/jira/browse/JSPWIKI-620
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.3
> Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
> Reporter: Rolf Schumacher
>
> What I did:
> checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
> What I expected:
> to see the Main.txt page
> What I got:
> a blank window
> Workaround:
> manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-620) templates not copied
Posted by "Rolf Schumacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794354#action_12794354 ]
Rolf Schumacher commented on JSPWIKI-620:
-----------------------------------------
Ok, Harry, you're right with "ant war".
In the text 'built with "ant war" or "ant war-tomcat"' shall be reduced to '"ant war-tomcat"'.
Could you please try the same with "war-tomcat".
I do not realy know what should happen in case of "precompiled jsps", however if I proceed as you did except for war-tomcat, I got a blank screen and some errors in jspwiki.log.
> templates not copied
> --------------------
>
> Key: JSPWIKI-620
> URL: https://issues.apache.org/jira/browse/JSPWIKI-620
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.3
> Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
> Reporter: Rolf Schumacher
>
> What I did:
> checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
> What I expected:
> to see the Main.txt page
> What I got:
> a blank window
> Workaround:
> manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (JSPWIKI-620) templates not copied
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harry Metske closed JSPWIKI-620.
--------------------------------
Resolution: Won't Fix
not fixed in 2.8
> templates not copied
> --------------------
>
> Key: JSPWIKI-620
> URL: https://issues.apache.org/jira/browse/JSPWIKI-620
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.3
> Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
> Reporter: Rolf Schumacher
>
> What I did:
> checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
> What I expected:
> to see the Main.txt page
> What I got:
> a blank window
> Workaround:
> manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-620) templates not copied
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794674#action_12794674 ]
Janne Jalkanen commented on JSPWIKI-620:
----------------------------------------
I'm all for dropping the precompiled jsp's (option 3). Considering that with 3.0, the JSPs become quite a lot lighter as code is moved into ActionBeans, I'm not even sure whether they really benefit anyone.
(the way we could implement 1 is that the precompilation process could create a simple text file of compiled JSPs, which we could then read in and check in TemplateManager.findResource(). But I'm not sure it's a good solution, especially if we can't find people who can speak up for this feature. But as it's a feature drop, we should vote on it on the mailing list.)
> templates not copied
> --------------------
>
> Key: JSPWIKI-620
> URL: https://issues.apache.org/jira/browse/JSPWIKI-620
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.3
> Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
> Reporter: Rolf Schumacher
>
> What I did:
> checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
> What I expected:
> to see the Main.txt page
> What I got:
> a blank window
> Workaround:
> manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-620) templates not copied
Posted by "Rolf Schumacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795789#action_12795789 ]
Rolf Schumacher commented on JSPWIKI-620:
-----------------------------------------
Sounds god to me, Harry.
Seems to be much better than just throwing it out.
However I'm not as familiar with building JSPWiki as I should in order
to back you up.
Rolf
> templates not copied
> --------------------
>
> Key: JSPWIKI-620
> URL: https://issues.apache.org/jira/browse/JSPWIKI-620
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.3
> Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
> Reporter: Rolf Schumacher
>
> What I did:
> checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
> What I expected:
> to see the Main.txt page
> What I got:
> a blank window
> Workaround:
> manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-620) templates not copied
Posted by "Rolf Schumacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794666#action_12794666 ]
Rolf Schumacher commented on JSPWIKI-620:
-----------------------------------------
I got to say that I started out using "war-tomcat" just because I ran JSPWiki with Tomcat. As that turned out not to work, I tried hard to understand why and to bring it up, including a new installation applying the "war" target. Somehow I got garbled and must have used the same former installation based on "war-tomcat" making me thinking something very odd is going on.
Hence, if we do not find out who uses war-tomcat and what for, I wouldn't mind just to drop it.
At least we can lower the priority of this issue.
> templates not copied
> --------------------
>
> Key: JSPWIKI-620
> URL: https://issues.apache.org/jira/browse/JSPWIKI-620
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.3
> Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
> Reporter: Rolf Schumacher
>
> What I did:
> checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
> What I expected:
> to see the Main.txt page
> What I got:
> a blank window
> Workaround:
> manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-620) templates not copied
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795365#action_12795365 ]
Harry Metske commented on JSPWIKI-620:
--------------------------------------
So, to summarize I propose we :
* mark this as a known issue for 2.8
* change 3.0's build.xml :
** add extra comment why we put source jsp's in the war in addition to the compiled jsp's
** make the webtests task depend on the jar-compiled-jsps task
** make the war task NOT anymore depend on the jar-compiled-jsps task
Right ?
> templates not copied
> --------------------
>
> Key: JSPWIKI-620
> URL: https://issues.apache.org/jira/browse/JSPWIKI-620
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.3
> Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
> Reporter: Rolf Schumacher
>
> What I did:
> checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
> What I expected:
> to see the Main.txt page
> What I got:
> a blank window
> Workaround:
> manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-620) templates not copied
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794486#action_12794486 ]
Janne Jalkanen commented on JSPWIKI-620:
----------------------------------------
No idea - I'm not sure where the war-tomcat task even originated from...
> templates not copied
> --------------------
>
> Key: JSPWIKI-620
> URL: https://issues.apache.org/jira/browse/JSPWIKI-620
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.3
> Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
> Reporter: Rolf Schumacher
>
> What I did:
> checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
> What I expected:
> to see the Main.txt page
> What I got:
> a blank window
> Workaround:
> manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-620) templates not copied
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794109#action_12794109 ]
Harry Metske commented on JSPWIKI-620:
--------------------------------------
Works for me (or I did not understand your problem):
First checked out https://svn.eu.apache.org/repos/asf/incubator/jspwiki/tags/jspwiki_2_8_3
And then:
{noformat}
metskem@gneisenau ~/workspace/JSPWiki-2.8.3 $ ant war
Buildfile: build.xml
installinit:
[mkdir] Created dir: /tmp/metskem/JSPWiki/install
[mkdir] Created dir: /tmp/metskem/JSPWiki/svnsrc
[mkdir] Created dir: /home/metskem/workspace/JSPWiki-2.8.3/releases
mkpropertyfile:
[copy] Copying 1 file to /home/metskem/workspace/JSPWiki-2.8.3/etc
[copy] Copying 1 file to /home/metskem/workspace/JSPWiki-2.8.3/tests/etc
[copy] Copying 1 file to /home/metskem/workspace/JSPWiki-2.8.3/tests/etc
[copy] Copying 1 file to /home/metskem/workspace/JSPWiki-2.8.3/tests/etc
init:
[mkdir] Created dir: /home/metskem/workspace/JSPWiki-2.8.3/tests/reports
[mkdir] Created dir: /tmp/testrepository
compile:
jar:
[copy] Copying 1 file to /home/metskem/workspace/JSPWiki-2.8.3/etc/i18n
[copy] Copying 1 file to /home/metskem/workspace/JSPWiki-2.8.3/etc/i18n/templates
[copy] Copying 1 file to /home/metskem/workspace/JSPWiki-2.8.3/etc/i18n/plugin
[jar] Building jar: /home/metskem/workspace/JSPWiki-2.8.3/build/JSPWiki.jar
compressedjs:
[mkdir] Created dir: /tmp/metskem/JSPWiki/compress/webdocs/scripts
[mkdir] Created dir: /tmp/metskem/JSPWiki/compress/webdocs/templates/default
[mkdir] Created dir: /tmp/metskem/JSPWiki/compress/webdocs/templates/default/skins/OrderedList
[mkdir] Created dir: /tmp/metskem/JSPWiki/compress/webdocs/templates/default/skins/PlainVanilla
[mkdir] Created dir: /tmp/metskem/JSPWiki/compress/webdocs/templates/default/skins/PlainVanilla 1024x768
[mkdir] Created dir: /tmp/metskem/JSPWiki/compress/webdocs/templates/default/skins/Smart
war:
[war] Building war: /tmp/metskem/JSPWiki/install/JSPWiki.war
[war] Updating war: /tmp/metskem/JSPWiki/install/JSPWiki.war
BUILD SUCCESSFUL
Total time: 10 seconds
metskem@gneisenau ~/workspace/JSPWiki-2.8.3 $ jar -tf /tmp/metskem/JSPWiki/install/JSPWiki.war|grep jsp
scripts/jspwiki-common.js
scripts/jspwiki-commonstyles.js
scripts/jspwiki-edit.js
scripts/jspwiki-prefs.js
templates/default/jspwiki.css
templates/default/jspwiki_print.css
Captcha.jsp
Comment.jsp
CookieError.jsp
Delete.jsp
DeleteGroup.jsp
Diff.jsp
Edit.jsp
EditGroup.jsp
Error.jsp
Group.jsp
Install.jsp
Login.jsp
LoginForm.jsp
Logout.jsp
LostPassword.jsp
Message.jsp
NewBlogEntry.jsp
NewGroup.jsp
PageInfo.jsp
PageModified.jsp
Preview.jsp
Rename.jsp
Search.jsp
SisterSites.jsp
Upload.jsp
UserPreferences.jsp
WEB-INF/jspwiki.policy
WEB-INF/jspwiki.properties
WEB-INF/jspwiki.tld
Wiki.jsp
Workflow.jsp
admin/Admin.jsp
admin/SecurityConfig.jsp
images/jspwiki-icons.png
images/jspwiki-strip.gif
images/jspwiki_logo.png
images/jspwiki_logo_s.png
rss.jsp
templates/default/AJAXCategories.jsp
templates/default/AJAXPreview.jsp
templates/default/AJAXSearch.jsp
templates/default/AttachmentTab.jsp
templates/default/CommentContent.jsp
templates/default/ConflictContent.jsp
templates/default/DiffContent.jsp
templates/default/DiffTab.jsp
templates/default/DisplayMessage.jsp
templates/default/EditContent.jsp
templates/default/EditGroupContent.jsp
templates/default/EditTemplate.jsp
templates/default/Favorites.jsp
templates/default/FindContent.jsp
templates/default/Footer.jsp
templates/default/GroupContent.jsp
templates/default/GroupTab.jsp
templates/default/Header.jsp
templates/default/InfoContent.jsp
templates/default/LoginContent.jsp
templates/default/NewGroupContent.jsp
templates/default/PageActionsBottom.jsp
templates/default/PageActionsTop.jsp
templates/default/PageContent.jsp
templates/default/PageTab.jsp
templates/default/PreferencesContent.jsp
templates/default/PreferencesTab.jsp
templates/default/PreviewContent.jsp
templates/default/ProfileTab.jsp
templates/default/SearchBox.jsp
templates/default/UploadTemplate.jsp
templates/default/UserBox.jsp
templates/default/ViewTemplate.jsp
templates/default/WorkflowContent.jsp
templates/default/admin/AdminTemplate.jsp
templates/default/admin/UserManagement.jsp
templates/default/commonheader.jsp
templates/default/editors/FCK.jsp
templates/default/editors/plain.jsp
templates/default/editors/preview.jsp
templates/default/localheader.jsp
templates/raw/ViewTemplate.jsp
metskem@gneisenau ~/workspace/JSPWiki-2.8.3 $
{noformat}
> templates not copied
> --------------------
>
> Key: JSPWIKI-620
> URL: https://issues.apache.org/jira/browse/JSPWIKI-620
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.3
> Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
> Reporter: Rolf Schumacher
> Fix For: 2.8.4
>
>
> What I did:
> checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
> What I expected:
> to see the Main.txt page
> What I got:
> a blank window
> Workaround:
> manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-620) templates not copied
Posted by "Andrew Jaquith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794683#action_12794683 ]
Andrew Jaquith commented on JSPWIKI-620:
----------------------------------------
The primary benefit of the precompiled JSPs is that you can deploy the WAR without unpacking. It is also important for web unit tests (which do not work at the moment), because pre-compilation speeds them up immensely. 3.0's Ant scripts were re-written to use precompiled JSPs for this purpose.
I seem to recall a previous discussion on the mailing list. I think the rough conclusion was that we should always copy JSPs into the WAR regardless of the pre-compilation setting -- it would also mean the .getResourceAsStream() calls would succeed, even if the JSPs *were* precompiled.
I do not favor dropping this. However, it would probably be a good idea to remove it from the 2.8 Ant script. Or we could simply mark this as a known issue for 2.8.
> templates not copied
> --------------------
>
> Key: JSPWIKI-620
> URL: https://issues.apache.org/jira/browse/JSPWIKI-620
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.3
> Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
> Reporter: Rolf Schumacher
>
> What I did:
> checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
> What I expected:
> to see the Main.txt page
> What I got:
> a blank window
> Workaround:
> manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-620) templates not copied
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794698#action_12794698 ]
Janne Jalkanen commented on JSPWIKI-620:
----------------------------------------
Hmmm... But the WAR file will work without unpacking too; the JSPs are compiled to the workdir.
TemplateManager.findResource() might not work if the WAR is not unpacked, but that has nothing to do with the pre-compiled JSPs as such.
We could do the pre-compilation for webtests-only separately, yes?
(At least a big fat <echo> in the ant script might be in order :-)
> templates not copied
> --------------------
>
> Key: JSPWIKI-620
> URL: https://issues.apache.org/jira/browse/JSPWIKI-620
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.3
> Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
> Reporter: Rolf Schumacher
>
> What I did:
> checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
> What I expected:
> to see the Main.txt page
> What I got:
> a blank window
> Workaround:
> manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-620) templates not copied
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794667#action_12794667 ]
Harry Metske commented on JSPWIKI-620:
--------------------------------------
Thanks for your feedback Rolf, and yes I think too there aren't many people using this war-tomcat.
We (mainly the work of Andrew) did port this task to JSPWiki 3.0 , and was renamed to jar-compiled-jsps (precompiling jsp's is not tomcat specific).
The main advantage is a speedup for the first user, I don't know if there are any other advantages (maybe security ?).
I had a look at TemplateManager and my findings are that TemplateManager.findResource() uses javax.servlet.ServletContext.getResourceAsStream("/templates/default/ViewTemplate.jsp") to determine which template to use.
If the physical jsp's aren't there (this is the case with precomiled jsp's), it always returns null, and we fail.
The Servlet API (http://java.sun.com/javaee/5/docs/api/) is not exactly clear in it's intended behavior, I would expect that getResource and getResourceAsStream would take the servlet mappings in web.xml into account, but apparently they don't.
So I see 3 options now :
1. Use something else than getResourceAsStream to find out which template to use
2. When using precompiled jsp's, als copy the source jsp's into the war
3. forget about this whole precompiling jsp's
Option 1 is the preferred one, anyone have any suggestions on the implementation ?
Option 2 is a kludge, and will confuse people.
Option 3 is the easiest of course, but we will loose something.
Anyone wants to comment ?
> templates not copied
> --------------------
>
> Key: JSPWIKI-620
> URL: https://issues.apache.org/jira/browse/JSPWIKI-620
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.3
> Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
> Reporter: Rolf Schumacher
>
> What I did:
> checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
> What I expected:
> to see the Main.txt page
> What I got:
> a blank window
> Workaround:
> manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-620) templates not copied
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794460#action_12794460 ]
Harry Metske commented on JSPWIKI-620:
--------------------------------------
Well yes, the war-tomcat task creates a JSPWiki-tomcat.war that has all jsp's compiled into jsp.jar, and also creates the necessary statements in web.xml.
However, after
* changing the jspwiki.properties (pagedir and attachmentdir)
* running the Installer
* recycling tomcat
I also get a blank screen when trying to access the JSPWiki webapp, the log shows the following messages :
==> /tmp/jspwiki.log <==
2009-12-24 17:55:32,354 [http-8080-1] INFO com.ecyrd.jspwiki.ui.TemplateManager JSPWiki:/JSPWiki/ JSPWiki:http://localhost:8080/JSPWiki/ - Final name = ViewTemplate.jsp
2009-12-24 17:55:32,355 [http-8080-1] FATAL com.ecyrd.jspwiki.ui.TemplateManager JSPWiki:/JSPWiki/ JSPWiki:http://localhost:8080/JSPWiki/ - findJSP() was asked to find a null template or name (default,null). JSP page '/JSPWiki/'
So there is something going wrong here, I have to find out what the intended behavior is (or somebody else can just tell it from the top of the head....)
> templates not copied
> --------------------
>
> Key: JSPWIKI-620
> URL: https://issues.apache.org/jira/browse/JSPWIKI-620
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.3
> Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
> Reporter: Rolf Schumacher
>
> What I did:
> checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
> What I expected:
> to see the Main.txt page
> What I got:
> a blank window
> Workaround:
> manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-620) templates not copied
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen updated JSPWIKI-620:
-----------------------------------
Fix Version/s: (was: 2.8.4)
Please don't mark fix versions, let the dev team decide when something is fixed :-)
> templates not copied
> --------------------
>
> Key: JSPWIKI-620
> URL: https://issues.apache.org/jira/browse/JSPWIKI-620
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.3
> Environment: Debian linux, ant 1.7.1, tomcat 6.0.20
> Reporter: Rolf Schumacher
>
> What I did:
> checked out branch 2.8.3 or downloaded source distribution from jspwiki.org, built with "ant war" or "ant war-tomcat", unjared to webapps location, configuration page is handled properly, restart tomcat, entered http://localhost:8080/JSPWiki.
> What I expected:
> to see the Main.txt page
> What I got:
> a blank window
> Workaround:
> manually copied all jsp pages from webdocs/templates/default of the source distribution to tomcat/webapps/JSPWiki/templates/default inclunding subdirectories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.