You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/08/17 05:20:21 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #10245: Minor fix
xiaoxiang781216 opened a new pull request, #10245:
URL: https://github.com/apache/nuttx/pull/10245
## Summary
- .gitignore: Add libsamplerate
- Fix include/nuttx/tls.h:233:20: error: unknown type name 'tls_dtor_t'
## Impact
## Testing
ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10245: Minor fix
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10245:
URL: https://github.com/apache/nuttx/pull/10245#discussion_r1296697148
##########
include/nuttx/tls.h:
##########
@@ -79,7 +79,7 @@ extern "C"
* TLS data indexes.
*/
-#if CONFIG_TLS_NELEM > 0
+#if CONFIG_TLS_TASK_NELEM || CONFIG_TLS_NELEM > 0
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #10245: Minor fix
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #10245:
URL: https://github.com/apache/nuttx/pull/10245#discussion_r1296688759
##########
include/nuttx/tls.h:
##########
@@ -79,7 +79,7 @@ extern "C"
* TLS data indexes.
*/
-#if CONFIG_TLS_NELEM > 0
+#if CONFIG_TLS_TASK_NELEM || CONFIG_TLS_NELEM > 0
Review Comment:
```suggestion
#if CONFIG_TLS_TASK_NELEM > 0 || CONFIG_TLS_NELEM > 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko merged pull request #10245: Minor fix
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #10245:
URL: https://github.com/apache/nuttx/pull/10245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org