You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2016/07/26 15:34:21 UTC
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/667
ARTEMIS-43 Adding notice about HornetQ donation and adding a history
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis history
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/667.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #667
----
commit 1c7bd5604ecb903daf5ba1c419236565f3dba3bb
Author: Clebert Suconic <cl...@apache.org>
Date: 2016-07-25T20:26:54Z
ARTEMIS-43 Adding notice about HornetQ donation and adding a history session
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72447120
--- Diff: NOTICE ---
@@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+
+Portions of this software were developed at
--- End diff --
@johnament I was told this is better to be kept as is. No real requirement to do it.. better to keep as is
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72416705
--- Diff: NOTICE ---
@@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+
+Portions of this software were developed at
--- End diff --
Ok, you can ignore the commentary from the peanut gallery over here. There was a piece to the SGA that wasn't clicking for me, someone pointed it out. This change is fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72286860
--- Diff: docs/hacking-guide/en/history.md ---
@@ -0,0 +1,19 @@
+History
+=======
+
+Artemis started with a code donation grant by RedHat in Oct 2014. During this process we took a snapshot of codebase and included it as an initial commit on the apache repository.
--- End diff --
duh.. thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/667
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72286070
--- Diff: docs/hacking-guide/en/history.md ---
@@ -0,0 +1,19 @@
+History
+=======
+
+Artemis started with a code donation grant by RedHat in Oct 2014. During this process we took a snapshot of codebase and included it as an initial commit on the apache repository.
--- End diff --
Red Hat
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72448663
--- Diff: NOTICE ---
@@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+
+Portions of this software were developed at
--- End diff --
Yep, leave it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72304637
--- Diff: NOTICE ---
@@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+
+Portions of this software were developed at
--- End diff --
I just want to give hornetq contributor the credit for their contributions on what became Artemis today.
We took a snapshot of hornetq during the Artemis, as it seemed the right decision at the time given the lengthy history logs existing on the donation. I think it's reasonable to include a word about their contributions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72296232
--- Diff: NOTICE ---
@@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+
+Portions of this software were developed at
--- End diff --
@clebertsuconic can you link to me an example of where you've seen it? Usually NOTICE is only when code is imported via non-SGA, e.g. a compatible OS license where modifications are done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72299763
--- Diff: NOTICE ---
@@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+
+Portions of this software were developed at
--- End diff --
http://www.apache.org/legal/src-headers.html#notice
in special:
```...
The NOTICE file may also include copyright notices moved from source files submitted to the ASF.
```
I found at least one example doing this.. I have seen others but I have the link for this one now:
https://github.com/apache/incubator-mynewt-core/blob/master/NOTICE
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72302279
--- Diff: NOTICE ---
@@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+
+Portions of this software were developed at
--- End diff --
I just pinged someone who's better at this than I am. I wouldn't use Mynewt as an example as they are incubating, but you are correct (and I even +1'd their release that included this). I will point the link you're quoting includes this:
```
- remove such notices, or
- move them to the NOTICE file associated with each applicable project release, or
- provide written permission for the ASF to make such removal or relocation of the notices.
```
Which the SGA should fall under the 1st or 3rd bullet point
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72306219
--- Diff: NOTICE ---
@@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+
+Portions of this software were developed at
--- End diff --
Right, I'm not saying that's a bad thing. My concern is this page: http://www.apache.org/dev/licensing-howto.html#mod-notice, which includes
Do not add anything to NOTICE which is not legally required.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72307320
--- Diff: NOTICE ---
@@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+
+Portions of this software were developed at
--- End diff --
The same text also says:
```Copyright notifications which have been relocated from source files (rather than removed) must be preserved in NOTICE.```
I think this is a simple and easy fix. it's concise and straight to the point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72294553
--- Diff: NOTICE ---
@@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+
+Portions of this software were developed at
--- End diff --
why not? I have seen other cases done that way on other projects at apache.
I believe we need something on the Notice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72294894
--- Diff: docs/hacking-guide/en/history.md ---
@@ -0,0 +1,19 @@
+History
+=======
+
+Artemis started with a code donation grant by RedHat in Oct 2014. During this process we took a snapshot of codebase and included it as an initial commit on the apache repository.
--- End diff --
Not my style.. I usually prefer text very concise and straight to the point.. but I can include yours.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72287865
--- Diff: docs/hacking-guide/en/history.md ---
@@ -0,0 +1,19 @@
+History
+=======
+
+Artemis started with a code donation grant by RedHat in Oct 2014. During this process we took a snapshot of codebase and included it as an initial commit on the apache repository.
--- End diff --
Perhaps reword this slightly.
The Apache ActiveMQ Artemis project was started in October 2014. The Artemis code base was seeded with a code donation, granted by Red Hat, of the HornetQ project. The code donation process consisted of taking a snapshot of the latest HornetQ code base and contributing this snapshot as an initial git commit into the Artemis git repository.
The HornetQ commit history is preserved, and can be accessed here: <>
Credit should be given to those developers who contributed to the HornetQ project. The top 10 committers are highlighted here: <>
For more information please visit the [HornetQ GitHub project].
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #667: ARTEMIS-43 Adding notice about HornetQ d...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/667#discussion_r72292777
--- Diff: NOTICE ---
@@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
+
+Portions of this software were developed at
--- End diff --
Since the code was donated via SGA, this should not be in your NOTICE.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---