You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/19 17:04:20 UTC

[GitHub] ruslo opened a new pull request #13321: CMake: Do not touch CMAKE_GENERATOR_TOOLSET

ruslo opened a new pull request #13321: CMake: Do not touch CMAKE_GENERATOR_TOOLSET
URL: https://github.com/apache/incubator-mxnet/pull/13321
 
 
   From documentation:
   
   ```
   The value of this variable should never be modified by project code.
   ... changing the value has undefined behavior.
   ```
   
   * https://cmake.org/cmake/help/latest/variable/CMAKE_GENERATOR_TOOLSET.html
   
   ## Description ##
   
   Fix CMake configuration error.
   
   ## Checklist ##
   ### Essentials ###
   
   - [x] The problem have been mentioned few times already (e.g. in [MXNET-796](https://issues.apache.org/jira/browse/MXNET-796), https://github.com/apache/incubator-mxnet/issues/12107#issuecomment-420548995) but all related pull requests are closed at this moment
   - [x] Changes are complete (i.e. I finished coding on this PR)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services