You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/10/07 11:43:09 UTC

[GitHub] [sling-org-apache-sling-commons-log] rombert opened a new pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

rombert opened a new pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8


   Created a draft PR, but the bundle now has too many dependencies inlined - including OSGi ones.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] cziegeler commented on pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
cziegeler commented on pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#issuecomment-996011677


   @rombert The PR now works for me with Java 8 and 11


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] karlpauls commented on pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
karlpauls commented on pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#issuecomment-937734665


   Yeah, that looks somewhat broken - wondering why that class would need to extend the internal one given the javadoc ... 
   
   Regardless, it would be good if you could inline the jar files so that we don't end up with embedded jars again :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] rombert edited a comment on pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
rombert edited a comment on pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#issuecomment-940112272


   @kwin @karlpauls  - the build now fails because of baselining issues in the Logback packages, e.g.
   
   ```
   [ERROR] Baseline mismatch for package ch.qos.logback.classic.encoder, MAJOR change. Current is 1.2.6, repo is 1.2.3, suggest 2.0.0 or -
   MAJOR                PACKAGE    ch.qos.logback.classic.encoder
     MAJOR              CLASS      ch.qos.logback.classic.encoder.PatternLayoutEncoder
       REMOVED          METHOD     setParent(ch.qos.logback.core.Appender)
         REMOVED        RETURN     void
       ADDED            METHOD     setParent(ch.qos.logback.core.spi.ContextAware)
         ADDED          RETURN     void
     REMOVED            VERSION    1.2.3
     ADDED              VERSION    1.2.6
   ```
   
   I think that we should ignore basellning here and keep the logback exports at the logback bundle version as a compromise, otherwise things can become quite confusing. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] rombert commented on a change in pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
rombert commented on a change in pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#discussion_r724121910



##########
File path: bnd.bnd
##########
@@ -0,0 +1,38 @@
+Bundle-DocURL: http://sling.apache.org/site/logging.html
+Import-Package: !org.slf4j.impl, \
+              !org.osgi.service.cm, \
+              !javax.servlet, \
+              !javax.servlet.http, \
+              !org.osgi.service.event, \
+              !javax.xml.transform, \
+              !javax.xml.transform.sax, \
+              !javax.xml.transform.stream, \
+              org.osgi.framework;version=1.3, \
+              org.slf4j;version="[1.6,1.8)", \
+              org.slf4j.spi;version="[1.6,1.8)", \
+              !groovy.lang, \
+              !org.codehaus.*, \
+              !javax.jms, \
+              !javax.mail, \
+              !javax.mail.internet, \
+              javax.management; \
+              javax.naming; \
+              javax.sql; \
+              javax.xml.parsers; \
+              org.xml.sax.*; \
+              sun.reflect;resolution:=optional, \
+              *
+DynamicImport-Package: org.osgi.service.cm;version=1.2, \
+              org.osgi.service.event;version=1.2, \
+              javax.xml.transform, \
+              javax.xml.transform.sax, \
+              javax.xml.transform.stream
+Embed-Dependency: jul-to-slf4j;inline="org/slf4j/bridge/SLF4JBridgeHandler.class", \

Review comment:
       I was trying to convert all the instructions from the maven-bundle-plugin. What is the equivalent for bnd?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] rombert commented on pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#issuecomment-996591112


   Great, thanks a lot @cziegeler !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] karlpauls commented on pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
karlpauls commented on pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#issuecomment-937724896






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] rombert commented on a change in pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
rombert commented on a change in pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#discussion_r724196271



##########
File path: bnd.bnd
##########
@@ -0,0 +1,38 @@
+Bundle-DocURL: http://sling.apache.org/site/logging.html
+Import-Package: !org.slf4j.impl, \
+              !org.osgi.service.cm, \
+              !javax.servlet, \
+              !javax.servlet.http, \
+              !org.osgi.service.event, \
+              !javax.xml.transform, \
+              !javax.xml.transform.sax, \
+              !javax.xml.transform.stream, \
+              org.osgi.framework;version=1.3, \
+              org.slf4j;version="[1.6,1.8)", \
+              org.slf4j.spi;version="[1.6,1.8)", \
+              !groovy.lang, \
+              !org.codehaus.*, \
+              !javax.jms, \
+              !javax.mail, \
+              !javax.mail.internet, \
+              javax.management; \
+              javax.naming; \
+              javax.sql; \
+              javax.xml.parsers; \
+              org.xml.sax.*; \
+              sun.reflect;resolution:=optional, \
+              *
+DynamicImport-Package: org.osgi.service.cm;version=1.2, \
+              org.osgi.service.event;version=1.2, \
+              javax.xml.transform, \
+              javax.xml.transform.sax, \
+              javax.xml.transform.stream
+Embed-Dependency: jul-to-slf4j;inline="org/slf4j/bridge/SLF4JBridgeHandler.class", \

Review comment:
       Thanks, should be fixed with 4de2b36979b086603e5ed9be4d8e99ed7db067f8




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] kwin commented on pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#issuecomment-940138897


   IMHO this is a false positive of baselining as http://logback.qos.ch/apidocs/ch/qos/logback/core/Appender.html derives from http://logback.qos.ch/apidocs/ch/qos/logback/core/spi/ContextAware.html. Not sure how this change may ever be backwards-incompatible TBH. @rombert I think this would be worth the report at https://github.com/bndtools/bnd/issues


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] kwin commented on a change in pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#discussion_r724115144



##########
File path: bnd.bnd
##########
@@ -0,0 +1,38 @@
+Bundle-DocURL: http://sling.apache.org/site/logging.html
+Import-Package: !org.slf4j.impl, \
+              !org.osgi.service.cm, \
+              !javax.servlet, \
+              !javax.servlet.http, \
+              !org.osgi.service.event, \
+              !javax.xml.transform, \
+              !javax.xml.transform.sax, \
+              !javax.xml.transform.stream, \
+              org.osgi.framework;version=1.3, \
+              org.slf4j;version="[1.6,1.8)", \
+              org.slf4j.spi;version="[1.6,1.8)", \
+              !groovy.lang, \
+              !org.codehaus.*, \
+              !javax.jms, \
+              !javax.mail, \
+              !javax.mail.internet, \
+              javax.management; \
+              javax.naming; \
+              javax.sql; \
+              javax.xml.parsers; \
+              org.xml.sax.*; \
+              sun.reflect;resolution:=optional, \
+              *
+DynamicImport-Package: org.osgi.service.cm;version=1.2, \
+              org.osgi.service.event;version=1.2, \
+              javax.xml.transform, \
+              javax.xml.transform.sax, \
+              javax.xml.transform.stream
+Embed-Dependency: jul-to-slf4j;inline="org/slf4j/bridge/SLF4JBridgeHandler.class", \

Review comment:
       This is not supported in bnd-maven-plugin

##########
File path: bnd.bnd
##########
@@ -0,0 +1,38 @@
+Bundle-DocURL: http://sling.apache.org/site/logging.html
+Import-Package: !org.slf4j.impl, \
+              !org.osgi.service.cm, \
+              !javax.servlet, \
+              !javax.servlet.http, \
+              !org.osgi.service.event, \
+              !javax.xml.transform, \
+              !javax.xml.transform.sax, \
+              !javax.xml.transform.stream, \
+              org.osgi.framework;version=1.3, \
+              org.slf4j;version="[1.6,1.8)", \
+              org.slf4j.spi;version="[1.6,1.8)", \
+              !groovy.lang, \
+              !org.codehaus.*, \
+              !javax.jms, \
+              !javax.mail, \
+              !javax.mail.internet, \
+              javax.management; \
+              javax.naming; \
+              javax.sql; \
+              javax.xml.parsers; \
+              org.xml.sax.*; \
+              sun.reflect;resolution:=optional, \
+              *
+DynamicImport-Package: org.osgi.service.cm;version=1.2, \
+              org.osgi.service.event;version=1.2, \
+              javax.xml.transform, \
+              javax.xml.transform.sax, \
+              javax.xml.transform.stream
+Embed-Dependency: jul-to-slf4j;inline="org/slf4j/bridge/SLF4JBridgeHandler.class", \

Review comment:
       https://groups.google.com/g/bndtools-users/c/NAdU0_X8OKY




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] rombert commented on a change in pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
rombert commented on a change in pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#discussion_r724121910



##########
File path: bnd.bnd
##########
@@ -0,0 +1,38 @@
+Bundle-DocURL: http://sling.apache.org/site/logging.html
+Import-Package: !org.slf4j.impl, \
+              !org.osgi.service.cm, \
+              !javax.servlet, \
+              !javax.servlet.http, \
+              !org.osgi.service.event, \
+              !javax.xml.transform, \
+              !javax.xml.transform.sax, \
+              !javax.xml.transform.stream, \
+              org.osgi.framework;version=1.3, \
+              org.slf4j;version="[1.6,1.8)", \
+              org.slf4j.spi;version="[1.6,1.8)", \
+              !groovy.lang, \
+              !org.codehaus.*, \
+              !javax.jms, \
+              !javax.mail, \
+              !javax.mail.internet, \
+              javax.management; \
+              javax.naming; \
+              javax.sql; \
+              javax.xml.parsers; \
+              org.xml.sax.*; \
+              sun.reflect;resolution:=optional, \
+              *
+DynamicImport-Package: org.osgi.service.cm;version=1.2, \
+              org.osgi.service.event;version=1.2, \
+              javax.xml.transform, \
+              javax.xml.transform.sax, \
+              javax.xml.transform.stream
+Embed-Dependency: jul-to-slf4j;inline="org/slf4j/bridge/SLF4JBridgeHandler.class", \

Review comment:
       I was trying to convert all the instructions from the maven-bundle-plugin. What is the equivalent for bnd?

##########
File path: bnd.bnd
##########
@@ -0,0 +1,38 @@
+Bundle-DocURL: http://sling.apache.org/site/logging.html
+Import-Package: !org.slf4j.impl, \
+              !org.osgi.service.cm, \
+              !javax.servlet, \
+              !javax.servlet.http, \
+              !org.osgi.service.event, \
+              !javax.xml.transform, \
+              !javax.xml.transform.sax, \
+              !javax.xml.transform.stream, \
+              org.osgi.framework;version=1.3, \
+              org.slf4j;version="[1.6,1.8)", \
+              org.slf4j.spi;version="[1.6,1.8)", \
+              !groovy.lang, \
+              !org.codehaus.*, \
+              !javax.jms, \
+              !javax.mail, \
+              !javax.mail.internet, \
+              javax.management; \
+              javax.naming; \
+              javax.sql; \
+              javax.xml.parsers; \
+              org.xml.sax.*; \
+              sun.reflect;resolution:=optional, \
+              *
+DynamicImport-Package: org.osgi.service.cm;version=1.2, \
+              org.osgi.service.event;version=1.2, \
+              javax.xml.transform, \
+              javax.xml.transform.sax, \
+              javax.xml.transform.stream
+Embed-Dependency: jul-to-slf4j;inline="org/slf4j/bridge/SLF4JBridgeHandler.class", \

Review comment:
       Thanks, should be fixed with 4de2b36979b086603e5ed9be4d8e99ed7db067f8




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] kwin edited a comment on pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
kwin edited a comment on pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#issuecomment-940138897


   IMHO this is a false positive of baselining as http://logback.qos.ch/apidocs/ch/qos/logback/core/Appender.html implements http://logback.qos.ch/apidocs/ch/qos/logback/core/spi/ContextAware.html. Not sure how this change may ever be backwards-incompatible TBH. @rombert I think this would be worth the report at https://github.com/bndtools/bnd/issues


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] rombert commented on pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#issuecomment-937727585


   Good catch @karlpauls - I fixed it (I think) in 1a6eec6ad8cfe56baa44e10c163a36fc253ca954 . However, bnd now (rightfully) complains that
   
   ```
   Export org.apache.sling.commons.log.logback,  has 1,  private references [org.apache.sling.commons.log.logback.internal]
   ```
   
   Which is presumably https://github.com/apache/sling-org-apache-sling-commons-log/blob/master/src/main/java/org/apache/sling/commons/log/logback/OsgiAction.java . I am not sure how to resolve that, except by skipping the check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] kwin commented on a change in pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#discussion_r724176122



##########
File path: bnd.bnd
##########
@@ -0,0 +1,38 @@
+Bundle-DocURL: http://sling.apache.org/site/logging.html
+Import-Package: !org.slf4j.impl, \
+              !org.osgi.service.cm, \
+              !javax.servlet, \
+              !javax.servlet.http, \
+              !org.osgi.service.event, \
+              !javax.xml.transform, \
+              !javax.xml.transform.sax, \
+              !javax.xml.transform.stream, \
+              org.osgi.framework;version=1.3, \
+              org.slf4j;version="[1.6,1.8)", \
+              org.slf4j.spi;version="[1.6,1.8)", \
+              !groovy.lang, \
+              !org.codehaus.*, \
+              !javax.jms, \
+              !javax.mail, \
+              !javax.mail.internet, \
+              javax.management; \
+              javax.naming; \
+              javax.sql; \
+              javax.xml.parsers; \
+              org.xml.sax.*; \
+              sun.reflect;resolution:=optional, \
+              *
+DynamicImport-Package: org.osgi.service.cm;version=1.2, \
+              org.osgi.service.event;version=1.2, \
+              javax.xml.transform, \
+              javax.xml.transform.sax, \
+              javax.xml.transform.stream
+Embed-Dependency: jul-to-slf4j;inline="org/slf4j/bridge/SLF4JBridgeHandler.class", \

Review comment:
       https://groups.google.com/g/bndtools-users/c/NAdU0_X8OKY




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] kwin commented on a change in pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#discussion_r724115144



##########
File path: bnd.bnd
##########
@@ -0,0 +1,38 @@
+Bundle-DocURL: http://sling.apache.org/site/logging.html
+Import-Package: !org.slf4j.impl, \
+              !org.osgi.service.cm, \
+              !javax.servlet, \
+              !javax.servlet.http, \
+              !org.osgi.service.event, \
+              !javax.xml.transform, \
+              !javax.xml.transform.sax, \
+              !javax.xml.transform.stream, \
+              org.osgi.framework;version=1.3, \
+              org.slf4j;version="[1.6,1.8)", \
+              org.slf4j.spi;version="[1.6,1.8)", \
+              !groovy.lang, \
+              !org.codehaus.*, \
+              !javax.jms, \
+              !javax.mail, \
+              !javax.mail.internet, \
+              javax.management; \
+              javax.naming; \
+              javax.sql; \
+              javax.xml.parsers; \
+              org.xml.sax.*; \
+              sun.reflect;resolution:=optional, \
+              *
+DynamicImport-Package: org.osgi.service.cm;version=1.2, \
+              org.osgi.service.event;version=1.2, \
+              javax.xml.transform, \
+              javax.xml.transform.sax, \
+              javax.xml.transform.stream
+Embed-Dependency: jul-to-slf4j;inline="org/slf4j/bridge/SLF4JBridgeHandler.class", \

Review comment:
       This is not supported in bnd-maven-plugin




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] rombert merged pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
rombert merged pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] karlpauls commented on pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
karlpauls commented on pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#issuecomment-937724896


   @rombert - I might be wrong but that looks like it is exporting a lot more than it used to, no?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] sonarcloud[bot] commented on pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#issuecomment-996005077


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&metric=coverage&view=list) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-log&pullRequest=8&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] rombert commented on pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#issuecomment-940112272


   @kwin @karlpauls  - the build now fails because of baselining issues in the Logback packages, e.g.
   
   ```
   [ERROR] Baseline mismatch for package ch.qos.logback.classic.encoder, MAJOR change. Current is 1.2.6, repo is 1.2.3, suggest 2.0.0 or -
   MAJOR                PACKAGE    ch.qos.logback.classic.encoder
     MAJOR              CLASS      ch.qos.logback.classic.encoder.PatternLayoutEncoder
       REMOVED          METHOD     setParent(ch.qos.logback.core.Appender)
         REMOVED        RETURN     void
       ADDED            METHOD     setParent(ch.qos.logback.core.spi.ContextAware)
         ADDED          RETURN     void
     REMOVED            VERSION    1.2.3
     ADDED              VERSION    1.2.6
   ```
   
   I think that we should ignore basellning here and keep the logback exports as a compromise, otherwise things can become quite confusing. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] rombert commented on pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#issuecomment-937727585


   Good catch @karlpauls - I fixed it (I think) in 1a6eec6ad8cfe56baa44e10c163a36fc253ca954 . However, bnd now (rightfully) complains that
   
   ```
   Export org.apache.sling.commons.log.logback,  has 1,  private references [org.apache.sling.commons.log.logback.internal]
   ```
   
   Which is presumably https://github.com/apache/sling-org-apache-sling-commons-log/blob/master/src/main/java/org/apache/sling/commons/log/logback/OsgiAction.java . I am not sure how to resolve that, except by skipping the check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org