You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/09/22 19:29:31 UTC
Review Request 38637: Added recovery warnings for LinuxLauncher on
Systemd.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38637/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen, Thomas Rampelberg, and Timothy Chen.
Bugs: MESOS-3425
https://issues.apache.org/jira/browse/MESOS-3425
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26
Diff: https://reviews.apache.org/r/38637/diff/
Testing
-------
make check
on ubuntu 15.04 with systemd 219 verified that pids get assigned to the `mesos_executor.slice`, and operator is warned about lack of proper resource isolation upon recovery if the executor pid is no longer in the slice.
Thanks,
Joris Van Remoortere
Re: Review Request 38637: Added recovery warnings for LinuxLauncher on
Systemd.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38637/#review100294
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38634, 38635, 38636, 38637]
All tests passed.
- Mesos ReviewBot
On Sept. 23, 2015, 8:34 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38637/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 8:34 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen, Thomas Rampelberg, and Timothy Chen.
>
>
> Bugs: MESOS-3425
> https://issues.apache.org/jira/browse/MESOS-3425
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp 459af1b98ba577863d88d521f3ba8792959f42b4
>
> Diff: https://reviews.apache.org/r/38637/diff/
>
>
> Testing
> -------
>
> make check
> on ubuntu 15.04 with systemd 219 verified that pids get assigned to the `mesos_executor.slice`, and operator is warned about lack of proper resource isolation upon recovery if the executor pid is no longer in the slice.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 38637: Added recovery warnings for LinuxLauncher on
Systemd.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38637/#review100335
-----------------------------------------------------------
Ship it!
Agree with Jie on returning 'Failure' instead of 'EXIT'. Great!
src/slave/containerizer/linux_launcher.cpp (line 176)
<https://reviews.apache.org/r/38637/#comment157523>
See previous review regarding renaming this.
- Benjamin Hindman
On Sept. 23, 2015, 8:34 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38637/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 8:34 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen, Thomas Rampelberg, and Timothy Chen.
>
>
> Bugs: MESOS-3425
> https://issues.apache.org/jira/browse/MESOS-3425
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp 459af1b98ba577863d88d521f3ba8792959f42b4
>
> Diff: https://reviews.apache.org/r/38637/diff/
>
>
> Testing
> -------
>
> make check
> on ubuntu 15.04 with systemd 219 verified that pids get assigned to the `mesos_executor.slice`, and operator is warned about lack of proper resource isolation upon recovery if the executor pid is no longer in the slice.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 38637: Added recovery warnings for LinuxLauncher on
Systemd.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38637/#review100376
-----------------------------------------------------------
src/slave/containerizer/linux_launcher.cpp (line 246)
<https://reviews.apache.org/r/38637/#comment157556>
I think this Nit, but I believe we've been using single quotes most of the times instead of ticks in all our messages.
- Timothy Chen
On Sept. 24, 2015, 4 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38637/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 4 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen, Thomas Rampelberg, and Timothy Chen.
>
>
> Bugs: MESOS-3425
> https://issues.apache.org/jira/browse/MESOS-3425
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp 459af1b98ba577863d88d521f3ba8792959f42b4
>
> Diff: https://reviews.apache.org/r/38637/diff/
>
>
> Testing
> -------
>
> make check
> on ubuntu 15.04 with systemd 219 verified that pids get assigned to the `mesos_executor.slice`, and operator is warned about lack of proper resource isolation upon recovery if the executor pid is no longer in the slice.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 38637: Added recovery warnings for LinuxLauncher on
Systemd.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38637/
-----------------------------------------------------------
(Updated Sept. 24, 2015, 4 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen, Thomas Rampelberg, and Timothy Chen.
Bugs: MESOS-3425
https://issues.apache.org/jira/browse/MESOS-3425
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/linux_launcher.cpp 459af1b98ba577863d88d521f3ba8792959f42b4
Diff: https://reviews.apache.org/r/38637/diff/
Testing
-------
make check
on ubuntu 15.04 with systemd 219 verified that pids get assigned to the `mesos_executor.slice`, and operator is warned about lack of proper resource isolation upon recovery if the executor pid is no longer in the slice.
Thanks,
Joris Van Remoortere
Re: Review Request 38637: Added recovery warnings for LinuxLauncher on
Systemd.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38637/
-----------------------------------------------------------
(Updated Sept. 24, 2015, 3:53 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen, Thomas Rampelberg, and Timothy Chen.
Bugs: MESOS-3425
https://issues.apache.org/jira/browse/MESOS-3425
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/linux_launcher.cpp 459af1b98ba577863d88d521f3ba8792959f42b4
Diff: https://reviews.apache.org/r/38637/diff/
Testing
-------
make check
on ubuntu 15.04 with systemd 219 verified that pids get assigned to the `mesos_executor.slice`, and operator is warned about lack of proper resource isolation upon recovery if the executor pid is no longer in the slice.
Thanks,
Joris Van Remoortere
Re: Review Request 38637: Added recovery warnings for LinuxLauncher on
Systemd.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38637/#review100321
-----------------------------------------------------------
src/slave/containerizer/linux_launcher.cpp (lines 187 - 188)
<https://reviews.apache.org/r/38637/#comment157502>
Please return a Failure instead.
src/slave/containerizer/linux_launcher.cpp (line 237)
<https://reviews.apache.org/r/38637/#comment157504>
Remove the period in the end of the logging.
- Jie Yu
On Sept. 23, 2015, 8:34 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38637/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 8:34 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen, Thomas Rampelberg, and Timothy Chen.
>
>
> Bugs: MESOS-3425
> https://issues.apache.org/jira/browse/MESOS-3425
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp 459af1b98ba577863d88d521f3ba8792959f42b4
>
> Diff: https://reviews.apache.org/r/38637/diff/
>
>
> Testing
> -------
>
> make check
> on ubuntu 15.04 with systemd 219 verified that pids get assigned to the `mesos_executor.slice`, and operator is warned about lack of proper resource isolation upon recovery if the executor pid is no longer in the slice.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 38637: Added recovery warnings for LinuxLauncher on
Systemd.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38637/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 8:34 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen, Thomas Rampelberg, and Timothy Chen.
Changes
-------
rebased
Bugs: MESOS-3425
https://issues.apache.org/jira/browse/MESOS-3425
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/linux_launcher.cpp 459af1b98ba577863d88d521f3ba8792959f42b4
Diff: https://reviews.apache.org/r/38637/diff/
Testing
-------
make check
on ubuntu 15.04 with systemd 219 verified that pids get assigned to the `mesos_executor.slice`, and operator is warned about lack of proper resource isolation upon recovery if the executor pid is no longer in the slice.
Thanks,
Joris Van Remoortere
Re: Review Request 38637: Added recovery warnings for LinuxLauncher on
Systemd.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Sept. 22, 2015, 8:49 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [38634, 38635]
> >
> > Failed command: ./support/apply-review.sh -n -r 38635
> >
> > Error:
> > 2015-09-23 03:49:49 URL:https://reviews.apache.org/r/38635/diff/raw/ [9385/9385] -> "38635.patch" [1]
> > 38635.patch:232: new blank line at EOF.
> > +
> > warning: 1 line adds whitespace errors.
> > Successfully applied: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.
> >
> > See summary.
> >
> >
> > Review: https://reviews.apache.org/r/38635
> > src/linux/systemd.cpp:205: new blank line at EOF.
> > Failed to commit patch
Style nit ^^
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38637/#review100129
-----------------------------------------------------------
On Sept. 22, 2015, 6:48 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38637/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:48 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen, Thomas Rampelberg, and Timothy Chen.
>
>
> Bugs: MESOS-3425
> https://issues.apache.org/jira/browse/MESOS-3425
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26
>
> Diff: https://reviews.apache.org/r/38637/diff/
>
>
> Testing
> -------
>
> make check
> on ubuntu 15.04 with systemd 219 verified that pids get assigned to the `mesos_executor.slice`, and operator is warned about lack of proper resource isolation upon recovery if the executor pid is no longer in the slice.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 38637: Added recovery warnings for LinuxLauncher on
Systemd.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38637/#review100129
-----------------------------------------------------------
Bad patch!
Reviews applied: [38634, 38635]
Failed command: ./support/apply-review.sh -n -r 38635
Error:
2015-09-23 03:49:49 URL:https://reviews.apache.org/r/38635/diff/raw/ [9385/9385] -> "38635.patch" [1]
38635.patch:232: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Successfully applied: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.
See summary.
Review: https://reviews.apache.org/r/38635
src/linux/systemd.cpp:205: new blank line at EOF.
Failed to commit patch
- Mesos ReviewBot
On Sept. 23, 2015, 1:48 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38637/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 1:48 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen, Thomas Rampelberg, and Timothy Chen.
>
>
> Bugs: MESOS-3425
> https://issues.apache.org/jira/browse/MESOS-3425
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26
>
> Diff: https://reviews.apache.org/r/38637/diff/
>
>
> Testing
> -------
>
> make check
> on ubuntu 15.04 with systemd 219 verified that pids get assigned to the `mesos_executor.slice`, and operator is warned about lack of proper resource isolation upon recovery if the executor pid is no longer in the slice.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 38637: Added recovery warnings for LinuxLauncher on
Systemd.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38637/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 1:48 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen, Thomas Rampelberg, and Timothy Chen.
Changes
-------
Refactored based on BenH's comments.
Bugs: MESOS-3425
https://issues.apache.org/jira/browse/MESOS-3425
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26
Diff: https://reviews.apache.org/r/38637/diff/
Testing
-------
make check
on ubuntu 15.04 with systemd 219 verified that pids get assigned to the `mesos_executor.slice`, and operator is warned about lack of proper resource isolation upon recovery if the executor pid is no longer in the slice.
Thanks,
Joris Van Remoortere
Re: Review Request 38637: Added recovery warnings for LinuxLauncher on
Systemd.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38637/#review100112
-----------------------------------------------------------
Can we add tests and user docs describing the issue and new behavior, how to setup systemd's policies etc?
- Niklas Nielsen
On Sept. 22, 2015, 10:29 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38637/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 10:29 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen, Thomas Rampelberg, and Timothy Chen.
>
>
> Bugs: MESOS-3425
> https://issues.apache.org/jira/browse/MESOS-3425
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26
>
> Diff: https://reviews.apache.org/r/38637/diff/
>
>
> Testing
> -------
>
> make check
> on ubuntu 15.04 with systemd 219 verified that pids get assigned to the `mesos_executor.slice`, and operator is warned about lack of proper resource isolation upon recovery if the executor pid is no longer in the slice.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 38637: Added recovery warnings for LinuxLauncher on
Systemd.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38637/#review100031
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38634, 38635, 38636, 38637]
All tests passed.
- Mesos ReviewBot
On Sept. 22, 2015, 5:29 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38637/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 5:29 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen, Thomas Rampelberg, and Timothy Chen.
>
>
> Bugs: MESOS-3425
> https://issues.apache.org/jira/browse/MESOS-3425
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26
>
> Diff: https://reviews.apache.org/r/38637/diff/
>
>
> Testing
> -------
>
> make check
> on ubuntu 15.04 with systemd 219 verified that pids get assigned to the `mesos_executor.slice`, and operator is warned about lack of proper resource isolation upon recovery if the executor pid is no longer in the slice.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>