You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/05/15 04:32:47 UTC

[kudu-CR] [master sentry-itest] disable one scenario due to SENTRY-2519

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13340


Change subject: [master_sentry-itest] disable one scenario due to SENTRY-2519
......................................................................

[master_sentry-itest] disable one scenario due to SENTRY-2519

This patch disabled SentryAuthzProviderCacheITest.CreateTables test
scenario until SENTRY-2519 is fixed.  It seems the behavior of the
Sentry application is undefined after if checkNotNull precondition
fires.  At least, Sentry exhibits different behavior under different
Java versions once checkNotNull fires upon an attempt to shut down.
Under OpenJDK 1.8.0 Sentry stops servicing RPC requests, effectively
shutting down.  However, under Oracle JDK 1.8.0_121 it continues its
business as usual, so the test scenario fails because it assumes
the Sentry is shutdown once StopSentry() returns success.

The issue of mis-reporting on the actual result of shutting down
Sentry by the SentryITestBase::StopSentry() method will be addressed
separately.

Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
---
M src/kudu/integration-tests/master_sentry-itest.cc
1 file changed, 13 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13340/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [master sentry-itest] disable one scenario due to SENTRY-2519

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13340

to look at the new patch set (#4).

Change subject: [master_sentry-itest] disable one scenario due to SENTRY-2519
......................................................................

[master_sentry-itest] disable one scenario due to SENTRY-2519

This patch disables SentryAuthzProviderCacheITest.CreateTables test
scenario until SENTRY-2519 is fixed.  It seems the behavior of the
Sentry application is undefined if checkNotNull precondition
fires.  At least, Sentry exhibits different behavior under different
Java versions once checkNotNull fires upon an attempt to shut down.
Under OpenJDK 1.8.0 Sentry stops servicing RPC requests, effectively
shutting down.  However, under Oracle JDK 1.8.0_121 it continues its
business as usual, so the test scenario fails because it assumes
the Sentry is shutdown once StopSentry() returns success.

The issue of mis-reporting on the actual result of shutting down
Sentry by the SentryITestBase::StopSentry() method will be addressed
separately.

Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
---
M src/kudu/sentry/mini_sentry.cc
1 file changed, 15 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13340/4
-- 
To view, visit http://gerrit.cloudera.org:8080/13340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [master sentry-itest] disable one test scenario

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13340 )

Change subject: [master_sentry-itest] disable one test scenario
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13340/4/src/kudu/sentry/mini_sentry.cc
File src/kudu/sentry/mini_sentry.cc:

http://gerrit.cloudera.org:8080/#/c/13340/4/src/kudu/sentry/mini_sentry.cc@168
PS4, Line 168:     // TODO(aserbin): clarify why this method returns Status::OK() even if
             :     //                Sentry fails to shutdown (e.g., as in SENTRY-2519).
> Yeah, KillAndWait is supposed to upgrade to a SIGKILL if the process hasn't
Yup, it turned out the problem was not in KillAndWait or JDK versions whatsoever.  Even with SENTRY-2519 not fixed, the test 100% fails when running with Sentry 2.1.0 and Hive 2.1.1, but 100% passes with HEAD version of the Sentry.



-- 
To view, visit http://gerrit.cloudera.org:8080/13340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 May 2019 22:26:00 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master sentry-itest] disable one scenario due to SENTRY-2519

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13340

to look at the new patch set (#5).

Change subject: [master_sentry-itest] disable one scenario due to SENTRY-2519
......................................................................

[master_sentry-itest] disable one scenario due to SENTRY-2519

With this patch, SentryITestBase::StopSentry() sends SIGKILL
instead of SIGTERM to Sentry's JVM.

This is to fix a flakiness in SentryAuthzProviderCacheITest.CreateTables
scenario.  It seems the behavior of the Sentry application is undefined
if guava's checkNotNull precondition fires.  At least, Sentry exhibits
different behavior under different Java versions once checkNotNull fires
upon an attempt to shut down.  Under OpenJDK 1.8.0 Sentry stop
sservicing RPC, effectively shutting down.  However, under Oracle JDK
1.8.0_121 it continues its business as usual for HMS --> Sentry RPCs,
so the test scenario fails because it assumes the Sentry is shutdown
once StopSentry() returns success.

The issue of mis-reporting on the actual result of shutting down
Sentry by the SentryITestBase::StopSentry() method will be addressed
separately.

Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
---
M src/kudu/sentry/mini_sentry.cc
1 file changed, 15 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13340/5
-- 
To view, visit http://gerrit.cloudera.org:8080/13340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [master sentry-itest] disable one test scenario

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13340 )

Change subject: [master_sentry-itest] disable one test scenario
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 May 2019 22:44:28 +0000
Gerrit-HasComments: No

[kudu-CR] [master sentry-itest] disable one test scenario

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13340

to look at the new patch set (#6).

Change subject: [master_sentry-itest] disable one test scenario
......................................................................

[master_sentry-itest] disable one test scenario

This is to fix a flakiness in SentryAuthzProviderCacheITest.CreateTables
scenario: it 100% passes with the HEAD versions of Hive and Sentry but
100% fails with Hive 2.1.1 and Sentry 2.1.0.  The scenario doesn't
exhibit any other signs of flakiness.  Until the root cause is clear,
let's keep this test scenario disabled.

Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
---
M src/kudu/integration-tests/master_sentry-itest.cc
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13340/6
-- 
To view, visit http://gerrit.cloudera.org:8080/13340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [master sentry-itest] disable one test scenario

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13340 )

Change subject: [master_sentry-itest] disable one test scenario
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 May 2019 22:35:56 +0000
Gerrit-HasComments: No

[kudu-CR] [master sentry-itest] disable one scenario due to SENTRY-2519

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13340 )

Change subject: [master_sentry-itest] disable one scenario due to SENTRY-2519
......................................................................


Patch Set 3:

StopSentry() sends a SIGTERM to the Sentry service. Maybe we should change that to a SIGKILL until SENTRY-2519 is fixed? There are a lot of MiniSentry::Stop calls right now; disabling just this one test means a bunch of other tests may misbehave if they assume Sentry really is down when it's not.


-- 
To view, visit http://gerrit.cloudera.org:8080/13340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 May 2019 04:53:30 +0000
Gerrit-HasComments: No

[kudu-CR] [master sentry-itest] disable one scenario due to SENTRY-2519

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13340

to look at the new patch set (#2).

Change subject: [master_sentry-itest] disable one scenario due to SENTRY-2519
......................................................................

[master_sentry-itest] disable one scenario due to SENTRY-2519

This patch disabled SentryAuthzProviderCacheITest.CreateTables test
scenario until SENTRY-2519 is fixed.  It seems the behavior of the
Sentry application is undefined if checkNotNull precondition
fires.  At least, Sentry exhibits different behavior under different
Java versions once checkNotNull fires upon an attempt to shut down.
Under OpenJDK 1.8.0 Sentry stops servicing RPC requests, effectively
shutting down.  However, under Oracle JDK 1.8.0_121 it continues its
business as usual, so the test scenario fails because it assumes
the Sentry is shutdown once StopSentry() returns success.

The issue of mis-reporting on the actual result of shutting down
Sentry by the SentryITestBase::StopSentry() method will be addressed
separately.

Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
---
M src/kudu/integration-tests/master_sentry-itest.cc
1 file changed, 13 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13340/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [master sentry-itest] disable one scenario due to SENTRY-2519

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13340

to look at the new patch set (#3).

Change subject: [master_sentry-itest] disable one scenario due to SENTRY-2519
......................................................................

[master_sentry-itest] disable one scenario due to SENTRY-2519

This patch disables SentryAuthzProviderCacheITest.CreateTables test
scenario until SENTRY-2519 is fixed.  It seems the behavior of the
Sentry application is undefined if checkNotNull precondition
fires.  At least, Sentry exhibits different behavior under different
Java versions once checkNotNull fires upon an attempt to shut down.
Under OpenJDK 1.8.0 Sentry stops servicing RPC requests, effectively
shutting down.  However, under Oracle JDK 1.8.0_121 it continues its
business as usual, so the test scenario fails because it assumes
the Sentry is shutdown once StopSentry() returns success.

The issue of mis-reporting on the actual result of shutting down
Sentry by the SentryITestBase::StopSentry() method will be addressed
separately.

Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
---
M src/kudu/integration-tests/master_sentry-itest.cc
1 file changed, 13 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13340/3
-- 
To view, visit http://gerrit.cloudera.org:8080/13340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [master sentry-itest] disable one scenario due to SENTRY-2519

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13340 )

Change subject: [master_sentry-itest] disable one scenario due to SENTRY-2519
......................................................................


Patch Set 3:

> StopSentry() sends a SIGTERM to the Sentry service. Maybe we should
 > change that to a SIGKILL until SENTRY-2519 is fixed? There are a
 > lot of MiniSentry::Stop calls right now; disabling just this one
 > test means a bunch of other tests may misbehave if they assume
 > Sentry really is down when it's not.

I think that's a good idea.  I also considered that, but was not sure whether SIGKILL was acceptable.  However, everything looks good with s/SIGTERM/SIGKILL/


-- 
To view, visit http://gerrit.cloudera.org:8080/13340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 May 2019 05:57:35 +0000
Gerrit-HasComments: No

[kudu-CR] [master sentry-itest] disable one scenario due to SENTRY-2519

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13340 )

Change subject: [master_sentry-itest] disable one scenario due to SENTRY-2519
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13340/4/src/kudu/sentry/mini_sentry.cc
File src/kudu/sentry/mini_sentry.cc:

http://gerrit.cloudera.org:8080/#/c/13340/4/src/kudu/sentry/mini_sentry.cc@168
PS4, Line 168:     // TODO(aserbin): clarify why this method returns Status::OK() even if
             :     //                Sentry fails to shutdown (e.g., as in SENTRY-2519).
Yeah, KillAndWait is supposed to upgrade to a SIGKILL if the process hasn't exited after 5 seconds. So the existing code should have handled this correctly. Can you please investigate?



-- 
To view, visit http://gerrit.cloudera.org:8080/13340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 May 2019 06:06:31 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master sentry-itest] disable one test scenario

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13340 )

Change subject: [master_sentry-itest] disable one test scenario
......................................................................

[master_sentry-itest] disable one test scenario

This is to fix a flakiness in SentryAuthzProviderCacheITest.CreateTables
scenario: it 100% passes with the HEAD versions of Hive and Sentry but
100% fails with Hive 2.1.1 and Sentry 2.1.0.  The scenario doesn't
exhibit any other signs of flakiness.  Until the root cause is clear,
let's keep this test scenario disabled.

Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
Reviewed-on: http://gerrit.cloudera.org:8080/13340
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/master_sentry-itest.cc
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Andrew Wong: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic397990e2fcda37ee6224a71a2ffe31aaa6414c6
Gerrit-Change-Number: 13340
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)