You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by "Daniel Stieglitz (Jira)" <ji...@apache.org> on 2022/11/14 15:01:00 UTC

[jira] [Comment Edited] (NIFI-10813) Complete changes on NIFI Expression Language Unit Testing to be completely JUnit 5

    [ https://issues.apache.org/jira/browse/NIFI-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633858#comment-17633858 ] 

Daniel Stieglitz edited comment on NIFI-10813 at 11/14/22 3:00 PM:
-------------------------------------------------------------------

This may be an issue with all the sub tasks listed in NIFI-9084 which were converted from Junit 4 to Junit 5. I noticed this in at least nifi/nifi-nar-bundles/nifi-jolt-record-bundle/nifi-jolt-record-processors/src/test/java/org/apache/nifi/processors/jolt/record/TestJoltTransformRecord.java


was (Author: JIRAUSER294662):
This may be an issue with all the sub tasks listed in NIFI-9084 which were converted from Junit 4 to Junit 5. I noticed it  in at least nifi/nifi-nar-bundles/nifi-jolt-record-bundle/nifi-jolt-record-processors/src/test/java/org/apache/nifi/processors/jolt/record/TestJoltTransformRecord.java

> Complete changes on NIFI Expression Language Unit Testing to be completely JUnit 5
> ----------------------------------------------------------------------------------
>
>                 Key: NIFI-10813
>                 URL: https://issues.apache.org/jira/browse/NIFI-10813
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Daniel Stieglitz
>            Assignee: Daniel Stieglitz
>            Priority: Minor
>
> In the unit class nifi/nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestQuery.java, I noticed SonarLint is complaining regarding the class being public and the test methods being public since in JUnit 5 they can be anything but private.  It is recommended to use package level as it improves the readability of code. This ticket is aimed on making TestQuery.java completely JUnit 5 by removing the public modifiers from the class and its methods.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)