You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/06/03 16:30:36 UTC
[GitHub] [hadoop] GauthamBanasandra opened a new pull request #2051: HDFS-15385 Upgrade boost library
GauthamBanasandra opened a new pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] oss-maker commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
oss-maker commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-650202499
Just went through the change list, it's strange how nobody thought of dependency cleanup till now. I always thought of giving a similar patch but didn't make time. Checking out the entire code of a dependency should never be done, especially in a project of this size. Going forward, we should not allow anyone to checkout the dependency, we should expect the user to install the dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-638459689
> Could someone with access to the CI machines please install the latest version of boost by running the following command
The CI job runs on docker container and the dockerfile is at `dev-support/docker/Dockerfile`. You can install the required libraries there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-646598835
The CI run isn't completing as it's getting aborted due to timeout. I'm not sure why this is happening. It seems like CI was running the unit tests when it got aborted. This issue has started happening ever since - https://github.com/apache/hadoop/pull/2051#issuecomment-640165168.
@aajisaka could you please suggest what to do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-638636989
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/2/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on a change in pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on a change in pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#discussion_r442634441
##########
File path: dev-support/docker/Dockerfile
##########
@@ -86,6 +86,15 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
+#######
+# Boost 1.76 (1.65 ships with Bionic)
+#######
+WORKDIR /root/boost-library
+RUN curl -L https://sourceforge.net/projects/boost/files/boost/1.72.0/boost_1_72_0.tar.bz2/download > boost_1_72_0.tar.bz2 \
+ && tar --bzip2 -xf boost_1_72_0.tar.bz2
+WORKDIR /root/boost-library/boost_1_72_0
Review comment:
> Is there any specific reason to use the latest version of boost? If not, the version provided and maintained in Ubuntu Bionic is better.
Yes @aajisaka. As part of the upgrade, I needed to use boost::asio::system_executor - https://github.com/apache/hadoop/pull/2051/commits/4dcc89a170ec5bdb98960c20ba40d8ce05871071#diff-365634cc5fad269ad19308bd99357403R43. It's available in Boost 1.72 but not in Boost 1.65.
(Also, it saves us from having to upgrade from 1.65 to 1.7x in the future :grin:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-640207289
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/8/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-658541750
Thank you @GauthamBanasandra for your work. I really appreciate it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-658068100
Would you add `# hadolint ignore=DL3003` to ignore the following hadolint warnings?
https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/13/artifact/out/diff-patch-hadolint.txt
```
dev-support/docker/Dockerfile:98 DL3003 Use WORKDIR to switch to a directory
dev-support/docker/Dockerfile_aarch64:101 DL3003 Use WORKDIR to switch to a directory
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on a change in pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on a change in pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#discussion_r442634441
##########
File path: dev-support/docker/Dockerfile
##########
@@ -86,6 +86,15 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
+#######
+# Boost 1.76 (1.65 ships with Bionic)
+#######
+WORKDIR /root/boost-library
+RUN curl -L https://sourceforge.net/projects/boost/files/boost/1.72.0/boost_1_72_0.tar.bz2/download > boost_1_72_0.tar.bz2 \
+ && tar --bzip2 -xf boost_1_72_0.tar.bz2
+WORKDIR /root/boost-library/boost_1_72_0
Review comment:
> Is there any specific reason to use the latest version of boost? If not, the version provided and maintained in Ubuntu Bionic is better.
Yes @aajisaka. As part of the upgrade, I needed to use boost::system_executor - https://github.com/apache/hadoop/pull/2051/commits/4dcc89a170ec5bdb98960c20ba40d8ce05871071#diff-365634cc5fad269ad19308bd99357403R43. It's available in Boost 1.72 but not in Boost 1.65.
(Also, it saves us from having to upgrade from 1.65 to 1.7x in the future :grin:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka edited a comment on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka edited a comment on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-657416339
Hi @GauthamBanasandra
Thank you for your update. The patch mostly looks good.
Would you rebase for the latest trunk and address the above comments from me? I'm +1 those are addressed.
Sorry for the late response.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on a change in pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#discussion_r442629175
##########
File path: dev-support/docker/Dockerfile
##########
@@ -86,6 +86,15 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
+#######
+# Boost 1.76 (1.65 ships with Bionic)
+#######
+WORKDIR /root/boost-library
+RUN curl -L https://sourceforge.net/projects/boost/files/boost/1.72.0/boost_1_72_0.tar.bz2/download > boost_1_72_0.tar.bz2 \
+ && tar --bzip2 -xf boost_1_72_0.tar.bz2
+WORKDIR /root/boost-library/boost_1_72_0
Review comment:
The versions are not consistent. The comment says boost 1.76 but downloads boost 1.72.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-639021747
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/5/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on a change in pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#discussion_r442630515
##########
File path: dev-support/docker/Dockerfile
##########
@@ -86,6 +86,15 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
+#######
+# Boost 1.76 (1.65 ships with Bionic)
+#######
+WORKDIR /root/boost-library
+RUN curl -L https://sourceforge.net/projects/boost/files/boost/1.72.0/boost_1_72_0.tar.bz2/download > boost_1_72_0.tar.bz2 \
+ && tar --bzip2 -xf boost_1_72_0.tar.bz2
+WORKDIR /root/boost-library/boost_1_72_0
Review comment:
Is there any specific reason to use the latest version of boost? If not, the version provided and maintained in Ubuntu Bionic is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-647768781
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 10s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 1m 6s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 19m 32s | trunk passed |
| +1 :green_heart: | compile | 20m 31s | trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 |
| +1 :green_heart: | compile | 17m 59s | trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| +1 :green_heart: | mvnsite | 18m 1s | trunk passed |
| +1 :green_heart: | shadedclient | 15m 5s | branch has no errors when building and testing our client artifacts. |
| -1 :x: | javadoc | 0m 34s | root in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04. |
| +1 :green_heart: | javadoc | 5m 42s | trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| -0 :warning: | patch | 21m 43s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 20m 20s | the patch passed |
| +1 :green_heart: | compile | 20m 34s | the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 |
| -1 :x: | cc | 20m 34s | root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 generated 6 new + 156 unchanged - 6 fixed = 162 total (was 162) |
| +1 :green_heart: | golang | 20m 34s | the patch passed |
| +1 :green_heart: | javac | 20m 34s | the patch passed |
| +1 :green_heart: | compile | 18m 2s | the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| -1 :x: | cc | 18m 2s | root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 generated 10 new + 152 unchanged - 10 fixed = 162 total (was 162) |
| +1 :green_heart: | golang | 18m 2s | the patch passed |
| +1 :green_heart: | javac | 18m 2s | the patch passed |
| +1 :green_heart: | hadolint | 0m 5s | There were no new hadolint issues. |
| +1 :green_heart: | mvnsite | 18m 28s | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | shelldocs | 0m 18s | There were no new shelldocs issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 13m 46s | patch has no errors when building and testing our client artifacts. |
| -1 :x: | javadoc | 0m 39s | root in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04. |
| +1 :green_heart: | javadoc | 5m 44s | the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
||| _ Other Tests _ |
| -1 :x: | unit | 597m 50s | root in the patch passed. |
| -1 :x: | asflicense | 1m 28s | The patch generated 1 ASF License warnings. |
| | | 802m 44s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdfs.server.federation.router.TestRouterFaultTolerant |
| | hadoop.hdfs.TestFileChecksum |
| | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics |
| | hadoop.hdfs.TestReconstructStripedFile |
| | hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy |
| | hadoop.hdfs.TestDecommission |
| | hadoop.hdfs.TestGetFileChecksum |
| | hadoop.hdfs.server.namenode.ha.TestEditLogTailer |
| | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped |
| | hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy |
| | hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler |
| | hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption |
| | hadoop.yarn.applications.distributedshell.TestDistributedShell |
| | hadoop.mapred.gridmix.TestGridmixSubmission |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/11/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2051 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint compile cc mvnsite javac unit golang javadoc mvninstall shadedclient |
| uname | Linux 809a42acf3fa 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / ce1008fe61a |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/11/artifact/out/branch-javadoc-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/11/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/11/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt |
| javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/11/artifact/out/patch-javadoc-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/11/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/11/testReport/ |
| asflicense | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/11/artifact/out/patch-asflicense-problems.txt |
| Max. process+thread count | 4025 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client . U: . |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/11/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-640089952
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/6/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on a change in pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#discussion_r442628777
##########
File path: BUILDING.txt
##########
@@ -6,6 +6,7 @@ Requirements:
* Unix System
* JDK 1.8
* Maven 3.3 or later
+* Boost 1.76
Review comment:
Would you add `(if compiling native code)`, as well as Protocol Buffers, CMake, and so on?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-650693101
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 23m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 10s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 1m 18s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 19m 31s | trunk passed |
| +1 :green_heart: | compile | 19m 39s | trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 |
| +1 :green_heart: | compile | 16m 57s | trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| +1 :green_heart: | mvnsite | 17m 14s | trunk passed |
| +1 :green_heart: | shadedclient | 14m 15s | branch has no errors when building and testing our client artifacts. |
| -1 :x: | javadoc | 0m 38s | root in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04. |
| +1 :green_heart: | javadoc | 5m 35s | trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| -0 :warning: | patch | 20m 51s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 19m 34s | the patch passed |
| +1 :green_heart: | compile | 19m 9s | the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 |
| -1 :x: | cc | 19m 9s | root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 generated 28 new + 126 unchanged - 36 fixed = 154 total (was 162) |
| +1 :green_heart: | golang | 19m 9s | the patch passed |
| +1 :green_heart: | javac | 19m 9s | the patch passed |
| +1 :green_heart: | compile | 17m 16s | the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| -1 :x: | cc | 17m 16s | root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 generated 31 new + 123 unchanged - 39 fixed = 154 total (was 162) |
| +1 :green_heart: | golang | 17m 16s | the patch passed |
| +1 :green_heart: | javac | 17m 16s | the patch passed |
| +1 :green_heart: | hadolint | 0m 4s | There were no new hadolint issues. |
| +1 :green_heart: | mvnsite | 17m 25s | the patch passed |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | shelldocs | 0m 17s | There were no new shelldocs issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 14m 0s | patch has no errors when building and testing our client artifacts. |
| -1 :x: | javadoc | 0m 37s | root in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04. |
| +1 :green_heart: | javadoc | 5m 47s | the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
||| _ Other Tests _ |
| -1 :x: | unit | 573m 26s | root in the patch passed. |
| -1 :x: | asflicense | 1m 32s | The patch generated 1 ASF License warnings. |
| | | 794m 14s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdfs.server.namenode.ha.TestPipelinesFailover |
| | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped |
| | hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler |
| | hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption |
| | hadoop.yarn.applications.distributedshell.TestDistributedShell |
| | hadoop.yarn.sls.appmaster.TestAMSimulator |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/12/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2051 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint compile cc mvnsite javac unit golang javadoc mvninstall shadedclient |
| uname | Linux 8df2a85234f2 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 8db38c98a6c |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/12/artifact/out/branch-javadoc-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/12/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/12/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt |
| javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/12/artifact/out/patch-javadoc-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/12/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/12/testReport/ |
| asflicense | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/12/artifact/out/patch-asflicense-problems.txt |
| Max. process+thread count | 4109 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask . U: . |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/12/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on a change in pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on a change in pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#discussion_r453722394
##########
File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/StringUtil.cc
##########
@@ -36,19 +36,19 @@ string StringUtil::ToString(uint32_t v) {
string StringUtil::ToString(int64_t v) {
char tmp[32];
- snprintf(tmp, 32, "%"PRId64, v);
+ snprintf(tmp, 32, "%" PRId64, v);
return tmp;
}
string StringUtil::ToString(int64_t v, char pad, int64_t len) {
char tmp[32];
- snprintf(tmp, 32, "%%%c%"PRId64""PRId64, pad, len);
+ snprintf(tmp, 32, "%%%c%" PRId64 "" PRId64, pad, len);
return Format(tmp, v);
}
string StringUtil::ToString(uint64_t v) {
char tmp[32];
- snprintf(tmp, 32, "%"PRIu64, v);
+ snprintf(tmp, 32, "%" PRIu64, v);
return tmp;
}
Review comment:
Done @aajisaka. I've removed these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-657676757
@aajisaka I've rebased and addressed the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka edited a comment on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka edited a comment on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-657416339
Hi @GauthamBanasandra
Thank you for your update. The patch mostly looks good.
Would you rebase to the latest trunk and address the above comments from me? I'm +1 those are addressed.
Sorry for the late response.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on a change in pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#discussion_r453490640
##########
File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/StringUtil.cc
##########
@@ -36,19 +36,19 @@ string StringUtil::ToString(uint32_t v) {
string StringUtil::ToString(int64_t v) {
char tmp[32];
- snprintf(tmp, 32, "%"PRId64, v);
+ snprintf(tmp, 32, "%" PRId64, v);
return tmp;
}
string StringUtil::ToString(int64_t v, char pad, int64_t len) {
char tmp[32];
- snprintf(tmp, 32, "%%%c%"PRId64""PRId64, pad, len);
+ snprintf(tmp, 32, "%%%c%" PRId64 "" PRId64, pad, len);
return Format(tmp, v);
}
string StringUtil::ToString(uint64_t v) {
char tmp[32];
- snprintf(tmp, 32, "%"PRIu64, v);
+ snprintf(tmp, 32, "%" PRIu64, v);
return tmp;
}
Review comment:
I think these changes in the mapreduce module are not related to this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-638680505
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 23m 22s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 10s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 19m 32s | trunk passed |
| +1 :green_heart: | compile | 1m 56s | trunk passed |
| +1 :green_heart: | mvnsite | 0m 31s | trunk passed |
| +1 :green_heart: | shadedclient | 14m 1s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 28s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 19s | the patch passed |
| -1 :x: | compile | 0m 38s | hadoop-hdfs-native-client in the patch failed. |
| -1 :x: | cc | 0m 38s | hadoop-hdfs-native-client in the patch failed. |
| -1 :x: | golang | 0m 38s | hadoop-hdfs-native-client in the patch failed. |
| -1 :x: | javac | 0m 38s | hadoop-hdfs-native-client in the patch failed. |
| +1 :green_heart: | hadolint | 0m 5s | There were no new hadolint issues. |
| +1 :green_heart: | mvnsite | 0m 20s | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | shelldocs | 0m 18s | The patch generated 0 new + 104 unchanged - 132 fixed = 104 total (was 236) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 14m 2s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 22s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 44s | hadoop-hdfs-native-client in the patch failed. |
| +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. |
| | | 82m 10s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2051 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs compile cc mvnsite javac unit golang javadoc mvninstall shadedclient |
| uname | Linux 1305e955d5fb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 704409d53bf |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/2/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client.txt |
| cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/2/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client.txt |
| golang | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/2/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client.txt |
| javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/2/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-native-client.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/2/testReport/ |
| Max. process+thread count | 414 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/2/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-657416339
Hi @GauthamBanasandra
Thank you for your update. The patch mostly looks good.
Would you rebase the latest patch and address the above comments from me? I'm +1 those are addressed.
Sorry for the late response.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-640100826
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 26m 0s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 10s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 1s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 19m 27s | trunk passed |
| +1 :green_heart: | compile | 1m 55s | trunk passed |
| +1 :green_heart: | mvnsite | 0m 30s | trunk passed |
| +1 :green_heart: | shadedclient | 14m 38s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 24s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 16s | the patch passed |
| +1 :green_heart: | compile | 1m 56s | the patch passed |
| +1 :green_heart: | cc | 1m 56s | the patch passed |
| +1 :green_heart: | golang | 1m 56s | the patch passed |
| +1 :green_heart: | javac | 1m 56s | the patch passed |
| +1 :green_heart: | hadolint | 0m 5s | There were no new hadolint issues. |
| +1 :green_heart: | mvnsite | 0m 17s | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | shelldocs | 0m 16s | The patch generated 0 new + 104 unchanged - 132 fixed = 104 total (was 236) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 13m 49s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 19s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 8m 0s | hadoop-hdfs-native-client in the patch passed. |
| +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. |
| | | 93m 14s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/6/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2051 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs compile cc mvnsite javac unit golang javadoc mvninstall shadedclient |
| uname | Linux e45419e0bbf7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 3ca15292c55 |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/6/testReport/ |
| Max. process+thread count | 454 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/6/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-650573895
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/12/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-638901440
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 5m 52s | Docker failed to build yetus/hadoop:5157118bd7f. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hadoop/pull/2051 |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/4/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-640165168
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/7/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-638840604
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/3/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-639090777
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 34m 7s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 9s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 25m 34s | trunk passed |
| +1 :green_heart: | compile | 2m 25s | trunk passed |
| +1 :green_heart: | mvnsite | 0m 29s | trunk passed |
| +1 :green_heart: | shadedclient | 17m 39s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 26s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 20s | the patch passed |
| +1 :green_heart: | compile | 2m 19s | the patch passed |
| +1 :green_heart: | cc | 2m 19s | the patch passed |
| +1 :green_heart: | golang | 2m 19s | the patch passed |
| +1 :green_heart: | javac | 2m 19s | the patch passed |
| -1 :x: | hadolint | 0m 7s | The patch generated 27 new + 0 unchanged - 0 fixed = 27 total (was 0) |
| +1 :green_heart: | mvnsite | 0m 21s | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | shelldocs | 0m 18s | The patch generated 0 new + 104 unchanged - 132 fixed = 104 total (was 236) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 17m 52s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 23s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 8m 19s | hadoop-hdfs-native-client in the patch passed. |
| +1 :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. |
| | | 116m 13s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/5/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2051 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs compile cc mvnsite javac unit golang javadoc mvninstall shadedclient |
| uname | Linux e3463c1b9185 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 5157118bd7f |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| hadolint | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/5/artifact/out/diff-patch-hadolint.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/5/testReport/ |
| Max. process+thread count | 414 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/5/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-638344405
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 9s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 19m 13s | trunk passed |
| +1 :green_heart: | compile | 1m 51s | trunk passed |
| +1 :green_heart: | mvnsite | 0m 26s | trunk passed |
| +1 :green_heart: | shadedclient | 36m 6s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 23s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 16s | the patch passed |
| -1 :x: | compile | 0m 21s | hadoop-hdfs-native-client in the patch failed. |
| -1 :x: | cc | 0m 21s | hadoop-hdfs-native-client in the patch failed. |
| -1 :x: | golang | 0m 21s | hadoop-hdfs-native-client in the patch failed. |
| -1 :x: | javac | 0m 21s | hadoop-hdfs-native-client in the patch failed. |
| +1 :green_heart: | mvnsite | 0m 16s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 13m 42s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 18s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 26s | hadoop-hdfs-native-client in the patch failed. |
| +1 :green_heart: | asflicense | 0m 33s | The patch does not generate ASF License warnings. |
| | | 57m 2s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2051 |
| Optional Tests | dupname asflicense compile cc mvnsite javac unit golang javadoc mvninstall shadedclient |
| uname | Linux 216787dedfe4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 40d63e02f04 |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client.txt |
| cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client.txt |
| golang | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client.txt |
| javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-native-client.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/1/testReport/ |
| Max. process+thread count | 413 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/1/console |
| versions | git=2.17.1 maven=3.6.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-647277355
@aajisaka it seems like the unit tests were running and were making progress. I think the CI needs to run a bit longer to finish. I'm not sure how to do this, would it be possible for you to please increase the time duration of the CI for this run?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-647287812
The timeout setting is here:
https://github.com/apache/hadoop/blob/9821b94c946b5102f34e39f58493d31a0bb93547/Jenkinsfile#L26
I think the timeout can be increased to 20 hours.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-646441382
> Thank you @GauthamBanasandra for cleaning up the code!
It's my pleasure @aajisaka 😄. I believe Hadoop is a very mature code base. Even though I just started with Hadoop quite recently, it has really taught me a lot. I think there's a lot to be gained by contributing to this wonderful community.
I've been working on some more library upgrades. I'll be pushing them out soon, I'm hoping that you would get a chance to review it 😁.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on a change in pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on a change in pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#discussion_r442633139
##########
File path: dev-support/docker/Dockerfile
##########
@@ -86,6 +86,15 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
+#######
+# Boost 1.76 (1.65 ships with Bionic)
+#######
+WORKDIR /root/boost-library
+RUN curl -L https://sourceforge.net/projects/boost/files/boost/1.72.0/boost_1_72_0.tar.bz2/download > boost_1_72_0.tar.bz2 \
+ && tar --bzip2 -xf boost_1_72_0.tar.bz2
+WORKDIR /root/boost-library/boost_1_72_0
Review comment:
> The versions are not consistent. The comment says boost 1.76 but downloads boost 1.72.
Thanks for the catch @aajisaka. I've rectified it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on a change in pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on a change in pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#discussion_r442634441
##########
File path: dev-support/docker/Dockerfile
##########
@@ -86,6 +86,15 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
+#######
+# Boost 1.76 (1.65 ships with Bionic)
+#######
+WORKDIR /root/boost-library
+RUN curl -L https://sourceforge.net/projects/boost/files/boost/1.72.0/boost_1_72_0.tar.bz2/download > boost_1_72_0.tar.bz2 \
+ && tar --bzip2 -xf boost_1_72_0.tar.bz2
+WORKDIR /root/boost-library/boost_1_72_0
Review comment:
> Is there any specific reason to use the latest version of boost? If not, the version provided and maintained in Ubuntu Bionic is better.
Yes @aajisaka. As part of the upgrade, I needed to use boos::asiot::system_executor - https://github.com/apache/hadoop/pull/2051/commits/4dcc89a170ec5bdb98960c20ba40d8ce05871071#diff-365634cc5fad269ad19308bd99357403R43. It's available in Boost 1.72 but not in Boost 1.65.
(Also, it saves us from having to upgrade from 1.65 to 1.7x in the future :grin:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-657693238
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/13/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka merged pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka merged pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-658017562
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 23m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 7s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 1m 15s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 22m 4s | trunk passed |
| +1 :green_heart: | compile | 20m 37s | trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 |
| +1 :green_heart: | compile | 17m 32s | trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| +1 :green_heart: | mvnsite | 18m 8s | trunk passed |
| +1 :green_heart: | shadedclient | 15m 46s | branch has no errors when building and testing our client artifacts. |
| -1 :x: | javadoc | 0m 31s | root in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04. |
| +1 :green_heart: | javadoc | 5m 35s | trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| -0 :warning: | patch | 22m 13s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 21m 54s | the patch passed |
| +1 :green_heart: | compile | 20m 17s | the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 |
| -1 :x: | cc | 20m 17s | root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 generated 9 new + 153 unchanged - 9 fixed = 162 total (was 162) |
| +1 :green_heart: | golang | 20m 17s | the patch passed |
| +1 :green_heart: | javac | 20m 17s | the patch passed |
| +1 :green_heart: | compile | 17m 43s | the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| -1 :x: | cc | 17m 43s | root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 generated 27 new + 135 unchanged - 27 fixed = 162 total (was 162) |
| +1 :green_heart: | golang | 17m 43s | the patch passed |
| +1 :green_heart: | javac | 17m 43s | the patch passed |
| -1 :x: | hadolint | 0m 4s | The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | mvnsite | 18m 2s | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | shelldocs | 0m 13s | There were no new shelldocs issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 15m 35s | patch has no errors when building and testing our client artifacts. |
| -1 :x: | javadoc | 0m 31s | root in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04. |
| +1 :green_heart: | javadoc | 5m 30s | the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
||| _ Other Tests _ |
| -1 :x: | unit | 595m 42s | root in the patch passed. |
| -1 :x: | asflicense | 2m 28s | The patch generated 1 ASF License warnings. |
| | | 831m 59s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.mapreduce.lib.input.TestCombineFileInputFormat |
| | hadoop.yarn.sls.appmaster.TestAMSimulator |
| | hadoop.yarn.applications.distributedshell.TestDistributedShell |
| | hadoop.yarn.server.resourcemanager.placement.TestUserGroupMappingPlacementRule |
| | hadoop.security.TestFixKerberosTicketOrder |
| | hadoop.security.TestRaceWhenRelogin |
| | hadoop.hdfs.server.federation.router.TestRouterRpc |
| | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped |
| | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics |
| | hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/13/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2051 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs compile cc mvnsite javac unit golang javadoc mvninstall shadedclient |
| uname | Linux 0daecfc694a4 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / b9fa5e0182c |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/13/artifact/out/branch-javadoc-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/13/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/13/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt |
| hadolint | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/13/artifact/out/diff-patch-hadolint.txt |
| javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/13/artifact/out/patch-javadoc-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/13/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/13/testReport/ |
| asflicense | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/13/artifact/out/patch-asflicense-problems.txt |
| Max. process+thread count | 3665 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client . U: . |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/13/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-647345550
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/11/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-638897056
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/4/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on a change in pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#discussion_r453468716
##########
File path: dev-support/docker/Dockerfile
##########
@@ -84,6 +84,16 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
+#######
+# Boost 1.72 (1.65 ships with Bionic)
+#######
+WORKDIR /root/boost-library
Review comment:
WORKDIR is `/root` in other places. Would you remove the overrides?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on a change in pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#discussion_r453490640
##########
File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/StringUtil.cc
##########
@@ -36,19 +36,19 @@ string StringUtil::ToString(uint32_t v) {
string StringUtil::ToString(int64_t v) {
char tmp[32];
- snprintf(tmp, 32, "%"PRId64, v);
+ snprintf(tmp, 32, "%" PRId64, v);
return tmp;
}
string StringUtil::ToString(int64_t v, char pad, int64_t len) {
char tmp[32];
- snprintf(tmp, 32, "%%%c%"PRId64""PRId64, pad, len);
+ snprintf(tmp, 32, "%%%c%" PRId64 "" PRId64, pad, len);
return Format(tmp, v);
}
string StringUtil::ToString(uint64_t v) {
char tmp[32];
- snprintf(tmp, 32, "%"PRIu64, v);
+ snprintf(tmp, 32, "%" PRIu64, v);
return tmp;
}
Review comment:
I think these changes are not related to this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-646446615
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/10/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-646433909
Thank you @GauthamBanasandra for cleaning up the code!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on a change in pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on a change in pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#discussion_r453794706
##########
File path: dev-support/docker/Dockerfile
##########
@@ -84,6 +84,16 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
+#######
+# Boost 1.72 (1.65 ships with Bionic)
+#######
+WORKDIR /root/boost-library
Review comment:
Done @aajisaka. I've removed the WORKDIR overrides.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-658465685
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 22m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 9s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 1m 19s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 21m 3s | trunk passed |
| +1 :green_heart: | compile | 19m 22s | trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 |
| +1 :green_heart: | compile | 17m 8s | trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| +1 :green_heart: | mvnsite | 17m 36s | trunk passed |
| +1 :green_heart: | shadedclient | 14m 8s | branch has no errors when building and testing our client artifacts. |
| -1 :x: | javadoc | 0m 40s | root in trunk failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04. |
| +1 :green_heart: | javadoc | 5m 40s | trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| -0 :warning: | patch | 20m 50s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 19m 56s | the patch passed |
| +1 :green_heart: | compile | 19m 56s | the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 |
| -1 :x: | cc | 19m 56s | root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 generated 26 new + 136 unchanged - 26 fixed = 162 total (was 162) |
| +1 :green_heart: | golang | 19m 56s | the patch passed |
| +1 :green_heart: | javac | 19m 56s | the patch passed |
| +1 :green_heart: | compile | 22m 35s | the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| -1 :x: | cc | 22m 35s | root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09 with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 generated 13 new + 149 unchanged - 13 fixed = 162 total (was 162) |
| +1 :green_heart: | golang | 22m 35s | the patch passed |
| +1 :green_heart: | javac | 22m 35s | the patch passed |
| +1 :green_heart: | hadolint | 0m 5s | There were no new hadolint issues. |
| +1 :green_heart: | mvnsite | 22m 59s | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | shelldocs | 0m 18s | There were no new shelldocs issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 17m 33s | patch has no errors when building and testing our client artifacts. |
| -1 :x: | javadoc | 0m 32s | root in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04. |
| +1 :green_heart: | javadoc | 6m 55s | the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
||| _ Other Tests _ |
| -1 :x: | unit | 578m 11s | root in the patch passed. |
| -1 :x: | asflicense | 1m 51s | The patch generated 1 ASF License warnings. |
| | | 816m 25s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.yarn.applications.distributedshell.TestDistributedShell |
| | hadoop.yarn.server.resourcemanager.placement.TestUserGroupMappingPlacementRule |
| | hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer |
| | hadoop.yarn.sls.TestReservationSystemInvariants |
| | hadoop.hdfs.server.namenode.ha.TestPipelinesFailover |
| | hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader |
| | hadoop.hdfs.TestErasureCodingMultipleRacks |
| | hadoop.hdfs.qjournal.client.TestQuorumJournalManager |
| | hadoop.hdfs.qjournal.client.TestQuorumJournalManagerUnit |
| | hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier |
| | hadoop.hdfs.TestDistributedFileSystem |
| | hadoop.hdfs.TestDecommissionWithStriped |
| | hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy |
| | hadoop.fs.http.client.TestHttpFSFWithSWebhdfsFileSystem |
| | hadoop.mapreduce.lib.input.TestCombineFileInputFormat |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/14/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2051 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs compile cc mvnsite javac unit golang javadoc mvninstall shadedclient |
| uname | Linux 215503cde4c1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 48f90115b5e |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/14/artifact/out/branch-javadoc-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/14/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| cc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/14/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt |
| javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/14/artifact/out/patch-javadoc-root-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/14/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/14/testReport/ |
| asflicense | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/14/artifact/out/patch-asflicense-problems.txt |
| Max. process+thread count | 4947 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client . U: . |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/14/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-640247532
I've addressed all the mentioned issues and the build + tests are passing - https://github.com/apache/hadoop/pull/2051#issuecomment-640100826 except for the `test4tests`. I believe this patch doesn't require any tests to be added as it doesn't change any of the component's behaviour(s). Passing of the existing tests itself should be sufficient.
@aajisaka could you please have a look at my patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-638840709
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 0m 6s | Docker failed to build yetus/hadoop:5157118bd7f. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hadoop/pull/2051 |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/3/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-658094213
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2051/14/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] GauthamBanasandra commented on pull request #2051: HDFS-15385 Upgrade boost library
Posted by GitBox <gi...@apache.org>.
GauthamBanasandra commented on pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#issuecomment-658088447
@aajisaka I've now added `# hadolint ignore=DL3003` to suppress the hadolint warnings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org