[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9569: [vec](load) fix core of segment_writer while it is not thread-safe

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #9569:
URL: https://github.com/apache/incubator-doris/pull/9569#discussion_r873051161


##########
be/src/olap/memtable.cpp:
##########
@@ -302,7 +302,7 @@ Status MemTable::_do_flush(int64_t& duration_ns) {
         }
     } else {
         vectorized::Block block = _collect_vskiplist_results();
-        RETURN_NOT_OK(_rowset_writer->add_block(&block));

Review Comment:
   add some comment here to explain the multi thread problem. So that other person will notice this problem when he or she want to modify or refactor it in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org