You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Kirill Safonov (JIRA)" <ji...@apache.org> on 2009/03/23 16:33:50 UTC

[jira] Created: (HTTPCLIENT-837) Wire produces invalid log skipping zero bytes in certain cases

Wire produces invalid log skipping zero bytes in certain cases
--------------------------------------------------------------

                 Key: HTTPCLIENT-837
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-837
             Project: HttpComponents HttpClient
          Issue Type: Bug
            Reporter: Kirill Safonov
            Priority: Critical
             Fix For: 3.1.1


WireLogInputStream class line 82 check if the byte returned is not -1 meaning end of stream. But the condition is wrong in case if this byte is 0, it should look like
{code}
if (l != -1) {
//...
}
{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Updated: (HTTPCLIENT-837) Wire produces invalid log skipping zero bytes in certain cases

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCLIENT-837:
-----------------------------------------

    Component/s: HttpConn
       Priority: Minor  (was: Critical)

> Wire produces invalid log skipping zero bytes in certain cases
> --------------------------------------------------------------
>
>                 Key: HTTPCLIENT-837
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-837
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpConn
>            Reporter: Kirill Safonov
>            Priority: Minor
>             Fix For: 4.0 Beta 3
>
>
> WireLogInputStream class line 82 check if the byte returned is not -1 meaning end of stream. But the condition is wrong in case if this byte is 0, it should look like
> if (l != -1) {
> //...
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Updated: (HTTPCLIENT-837) Wire produces invalid log skipping zero bytes in certain cases

Posted by "Kirill Safonov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kirill Safonov updated HTTPCLIENT-837:
--------------------------------------

    Description: 
WireLogInputStream class line 82 check if the byte returned is not -1 meaning end of stream. But the condition is wrong in case if this byte is 0, it should look like

if (l != -1) {
//...
}


  was:
WireLogInputStream class line 82 check if the byte returned is not -1 meaning end of stream. But the condition is wrong in case if this byte is 0, it should look like
{code}
if (l != -1) {
//...
}
{code}


> Wire produces invalid log skipping zero bytes in certain cases
> --------------------------------------------------------------
>
>                 Key: HTTPCLIENT-837
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-837
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>            Reporter: Kirill Safonov
>            Priority: Critical
>             Fix For: 3.1.1
>
>
> WireLogInputStream class line 82 check if the byte returned is not -1 meaning end of stream. But the condition is wrong in case if this byte is 0, it should look like
> if (l != -1) {
> //...
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Resolved: (HTTPCLIENT-837) Wire produces invalid log skipping zero bytes in certain cases

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-837.
------------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 3.1.1)
                   4.0 Beta 3

Fixed in 3.x and trunk. Many thanks for reporting the bug. Please note, though, it is very unlikely there will ever be a new release off the 3.x branch.

Oleg

> Wire produces invalid log skipping zero bytes in certain cases
> --------------------------------------------------------------
>
>                 Key: HTTPCLIENT-837
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-837
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpConn
>            Reporter: Kirill Safonov
>            Priority: Critical
>             Fix For: 4.0 Beta 3
>
>
> WireLogInputStream class line 82 check if the byte returned is not -1 meaning end of stream. But the condition is wrong in case if this byte is 0, it should look like
> if (l != -1) {
> //...
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org