You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2009/03/06 22:30:43 UTC

svn commit: r751076 - in /hadoop/hbase/trunk: CHANGES.txt src/java/org/apache/hadoop/hbase/regionserver/Store.java

Author: stack
Date: Fri Mar  6 21:30:40 2009
New Revision: 751076

URL: http://svn.apache.org/viewvc?rev=751076&view=rev
Log:
HBASE-1243 oldlogfile.dat is screwed, so is it's region

Modified:
    hadoop/hbase/trunk/CHANGES.txt
    hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/Store.java

Modified: hadoop/hbase/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/CHANGES.txt?rev=751076&r1=751075&r2=751076&view=diff
==============================================================================
--- hadoop/hbase/trunk/CHANGES.txt (original)
+++ hadoop/hbase/trunk/CHANGES.txt Fri Mar  6 21:30:40 2009
@@ -38,6 +38,7 @@
    HBASE-1238  Under upload, region servers are unable
                to compact when loaded with hundreds of regions
    HBASE-1247  checkAndSave doesn't Write Ahead Log
+   HBASE-1243  oldlogfile.dat is screwed, so is it's region
 
   IMPROVEMENTS
    HBASE-1089  Add count of regions on filesystem to master UI; add percentage

Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/Store.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/Store.java?rev=751076&r1=751075&r2=751076&view=diff
==============================================================================
--- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/Store.java (original)
+++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/Store.java Fri Mar  6 21:30:40 2009
@@ -295,8 +295,15 @@
     long maxSeqIdInLog = -1;
     NavigableMap<HStoreKey, byte []> reconstructedCache =
       new TreeMap<HStoreKey, byte []>(this.comparator);
-    SequenceFile.Reader logReader = new SequenceFile.Reader(this.fs,
-      reconstructionLog, this.conf);
+    SequenceFile.Reader logReader = null;
+    try {
+      logReader = new SequenceFile.Reader(this.fs, reconstructionLog, this.conf);
+    } catch (IOException e) {
+      LOG.warn("Failed opening reconstruction log though check for null-size passed. " +
+        "POSSIBLE DATA LOSS!! Soldiering on", e);
+      return;
+    }
+
     try {
       HLogKey key = new HLogKey();
       HLogEdit val = new HLogEdit();
@@ -1842,4 +1849,4 @@
     }
     return true;
   }
-}
\ No newline at end of file
+}