[GitHub] tysonnorris commented on issue #3198: move network + dns container args to pureconfig

[GitBox <gi...@apache.org>]

tysonnorris commented on issue #3198: move network + dns container args to pureconfig
URL: https://github.com/apache/incubator-openwhisk/pull/3198#issuecomment-359117993
 
 
   @markusthoemmes I updated to remove ContainerArgsConfig from InvokerReactive, and also verified that the dnsServers config is adjustable from env vars. 
   
   In order to leave the existing ansible config for dns functional, I had to add some changes to the deploy.yml for invoker, specifically:
   ```        {% for item in (invoker_container_network_dns_servers | default()).split(' ')  %}
           -e CONFIG_whisk_containerFactory_containerArgs_dnsServers_{{loop.index0}}={{ item }}
           {% endfor %}
   ```
   Let me know if you have concerns. Tested locally fine, FWIW.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services