You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/02/08 19:37:18 UTC

[GitHub] pasha-kuznetsov commented on a change in pull request #1941: (WIP) Exclude defaultrack bookies when enforceMinNumRacksPerWriteQuorum is enabled

pasha-kuznetsov commented on a change in pull request #1941: (WIP) Exclude defaultrack bookies when enforceMinNumRacksPerWriteQuorum is enabled
URL: https://github.com/apache/bookkeeper/pull/1941#discussion_r255210560
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperClientStats.java
 ##########
 @@ -93,6 +93,9 @@
     String FAILED_CONNECTION_COUNTER = "FAILED_CONNECTION_COUNTER";
     String FAILED_TLS_HANDSHAKE_COUNTER = "FAILED_TLS_HANDSHAKE_COUNTER";
 
+    // placementpolicy stats
+    String NUM_BOOKIES_IN_DEFAULT_FAULTZONE = "NUM_BOOKIES_IN_DEFAULT_FAULTZONE";
 
 Review comment:
   Shouldn't we have similar stats for each fault zone, including number of writable bookies there? Then we could alert on a fault zone not having enough (writable) bookies in a fault zone.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services