You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by "Brad Whitaker (JIRA)" <ji...@apache.org> on 2009/02/26 19:25:01 UTC
[jira] Created: (JSEC-64) removeMe cookie path is wrong at deletion
if servlet context path is root ("/")
removeMe cookie path is wrong at deletion if servlet context path is root ("/")
-------------------------------------------------------------------------------
Key: JSEC-64
URL: https://issues.apache.org/jira/browse/JSEC-64
Project: JSecurity
Issue Type: Bug
Affects Versions: Incubation
Reporter: Brad Whitaker
Attachments: CookeiAttribute.calculatePath.patch
The fix for JSEC-34 changes the cookie path from "" (empty string) to "/" when the rememberMe cookie is created. The change to the path is not made, however, when the cookie is removed. This prevents the cookie from being removed. The attached patch introduces a new method "calculatePath()" that supplies the path both when the cookie is created and when it is removed. (Feel free to rename the method or make any other change.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (JSEC-64) removeMe cookie path is wrong at
deletion if servlet context path is root ("/")
Posted by "Les Hazlewood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSEC-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Les Hazlewood reopened JSEC-64:
-------------------------------
When looking at this:
https://svn.apache.org/repos/asf/incubator/jsecurity/trunk/web/src/org/jsecurity/web/attr/CookieAttribute.java
I don't see the patch applied. Was another class modified instead? I'm confused...
> removeMe cookie path is wrong at deletion if servlet context path is root ("/")
> -------------------------------------------------------------------------------
>
> Key: JSEC-64
> URL: https://issues.apache.org/jira/browse/JSEC-64
> Project: JSecurity
> Issue Type: Bug
> Affects Versions: Incubation
> Reporter: Brad Whitaker
> Assignee: Jeremy Haile
> Fix For: 1.0
>
> Attachments: CookeiAttribute.calculatePath.patch
>
>
> The fix for JSEC-34 changes the cookie path from "" (empty string) to "/" when the rememberMe cookie is created. The change to the path is not made, however, when the cookie is removed. This prevents the cookie from being removed. The attached patch introduces a new method "calculatePath()" that supplies the path both when the cookie is created and when it is removed. (Feel free to rename the method or make any other change.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JSEC-64) removeMe cookie path is wrong at
deletion if servlet context path is root ("/")
Posted by "Jeremy Haile (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSEC-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Haile resolved JSEC-64.
------------------------------
Resolution: Fixed
Fix Version/s: 1.0
Assignee: Jeremy Haile
Patch applied and I also added a unit test to verify fix.
> removeMe cookie path is wrong at deletion if servlet context path is root ("/")
> -------------------------------------------------------------------------------
>
> Key: JSEC-64
> URL: https://issues.apache.org/jira/browse/JSEC-64
> Project: JSecurity
> Issue Type: Bug
> Affects Versions: Incubation
> Reporter: Brad Whitaker
> Assignee: Jeremy Haile
> Fix For: 1.0
>
> Attachments: CookeiAttribute.calculatePath.patch
>
>
> The fix for JSEC-34 changes the cookie path from "" (empty string) to "/" when the rememberMe cookie is created. The change to the path is not made, however, when the cookie is removed. This prevents the cookie from being removed. The attached patch introduces a new method "calculatePath()" that supplies the path both when the cookie is created and when it is removed. (Feel free to rename the method or make any other change.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JSEC-64) removeMe cookie path is wrong at
deletion if servlet context path is root ("/")
Posted by "Jeremy Haile (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSEC-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Haile resolved JSEC-64.
------------------------------
Resolution: Fixed
Merged accidental commit from import branch.
> removeMe cookie path is wrong at deletion if servlet context path is root ("/")
> -------------------------------------------------------------------------------
>
> Key: JSEC-64
> URL: https://issues.apache.org/jira/browse/JSEC-64
> Project: JSecurity
> Issue Type: Bug
> Affects Versions: Incubation
> Reporter: Brad Whitaker
> Assignee: Jeremy Haile
> Fix For: 1.0
>
> Attachments: CookeiAttribute.calculatePath.patch
>
>
> The fix for JSEC-34 changes the cookie path from "" (empty string) to "/" when the rememberMe cookie is created. The change to the path is not made, however, when the cookie is removed. This prevents the cookie from being removed. The attached patch introduces a new method "calculatePath()" that supplies the path both when the cookie is created and when it is removed. (Feel free to rename the method or make any other change.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Moved: (KI-14) removeMe cookie path is wrong at deletion if
servlet context path is root ("/")
Posted by "Alan Cabrera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KI-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Cabrera moved JSEC-64 to KI-14:
------------------------------------
Fix Version/s: (was: 1.0)
Affects Version/s: (was: Incubation)
Key: KI-14 (was: JSEC-64)
Project: Ki (was: JSecurity)
> removeMe cookie path is wrong at deletion if servlet context path is root ("/")
> -------------------------------------------------------------------------------
>
> Key: KI-14
> URL: https://issues.apache.org/jira/browse/KI-14
> Project: Ki
> Issue Type: Bug
> Reporter: Brad Whitaker
> Assignee: Jeremy Haile
> Attachments: CookeiAttribute.calculatePath.patch
>
>
> The fix for JSEC-34 changes the cookie path from "" (empty string) to "/" when the rememberMe cookie is created. The change to the path is not made, however, when the cookie is removed. This prevents the cookie from being removed. The attached patch introduces a new method "calculatePath()" that supplies the path both when the cookie is created and when it is removed. (Feel free to rename the method or make any other change.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSEC-64) removeMe cookie path is wrong at
deletion if servlet context path is root ("/")
Posted by "Les Hazlewood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSEC-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677098#action_12677098 ]
Les Hazlewood commented on JSEC-64:
-----------------------------------
Thanks very much for adding this! We'll get to it as soon as we can.
> removeMe cookie path is wrong at deletion if servlet context path is root ("/")
> -------------------------------------------------------------------------------
>
> Key: JSEC-64
> URL: https://issues.apache.org/jira/browse/JSEC-64
> Project: JSecurity
> Issue Type: Bug
> Affects Versions: Incubation
> Reporter: Brad Whitaker
> Attachments: CookeiAttribute.calculatePath.patch
>
>
> The fix for JSEC-34 changes the cookie path from "" (empty string) to "/" when the rememberMe cookie is created. The change to the path is not made, however, when the cookie is removed. This prevents the cookie from being removed. The attached patch introduces a new method "calculatePath()" that supplies the path both when the cookie is created and when it is removed. (Feel free to rename the method or make any other change.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSEC-64) removeMe cookie path is wrong at deletion
if servlet context path is root ("/")
Posted by "Brad Whitaker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSEC-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brad Whitaker updated JSEC-64:
------------------------------
Attachment: CookeiAttribute.calculatePath.patch
> removeMe cookie path is wrong at deletion if servlet context path is root ("/")
> -------------------------------------------------------------------------------
>
> Key: JSEC-64
> URL: https://issues.apache.org/jira/browse/JSEC-64
> Project: JSecurity
> Issue Type: Bug
> Affects Versions: Incubation
> Reporter: Brad Whitaker
> Attachments: CookeiAttribute.calculatePath.patch
>
>
> The fix for JSEC-34 changes the cookie path from "" (empty string) to "/" when the rememberMe cookie is created. The change to the path is not made, however, when the cookie is removed. This prevents the cookie from being removed. The attached patch introduces a new method "calculatePath()" that supplies the path both when the cookie is created and when it is removed. (Feel free to rename the method or make any other change.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.