You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/14 02:21:49 UTC

[GitHub] [shardingsphere-elasticjob] y553546436 commented on pull request #1774: Update GsonFactoryTest.java

y553546436 commented on pull request #1774:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1774#issuecomment-744125342


   > Hi @y553546436 ,
   > 
   > I can't get your point. Could you clarify what the problem is?
   
   Hi @TeslaCN, this test modifies GsonFactory, which contains (static) fields shared among tests. If other tests are added later on which assume the default behavior of GsonFactory, they would fail. In another word, this test "pollutes" the shared program state and could potentially lead other tests run after it to fail. Though there is no severe problem now, it would be good to clean the state (remove the "pollution") at the end of the test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org