You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "montu376 (via GitHub)" <gi...@apache.org> on 2025/05/29 08:51:05 UTC
[PR] MWRAPPER-162 - Removed dead link was getting 404 [maven-wrapper]
montu376 opened a new pull request, #167:
URL: https://github.com/apache/maven-wrapper/pull/167
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MWRAPPER-162 - Removed dead link was getting 404 [maven-wrapper]
Posted by "montu376 (via GitHub)" <gi...@apache.org>.
montu376 commented on PR #167:
URL: https://github.com/apache/maven-wrapper/pull/167#issuecomment-2918754505
This PR removes a dead link from the Maven Wrapper documentation:- https://maven.apache.org/wrapper/#specifying-maven-distribution-base-path
Removed Link: https://www.lewuathe.com/maven-wrapper-home.html
The link currently returns a 404 error and no longer provides relevant content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MWRAPPER-162] - Removed dead link was getting 404 [maven-wrapper]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #167:
URL: https://github.com/apache/maven-wrapper/pull/167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MWRAPPER-162] - Removed dead link was getting 404 [maven-wrapper]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #167:
URL: https://github.com/apache/maven-wrapper/pull/167#issuecomment-2921339471
The commit subject should be also the same as for PR,
I will override by squash
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MWRAPPER-162] - Removed dead link was getting 404 [maven-wrapper]
Posted by "montu376 (via GitHub)" <gi...@apache.org>.
montu376 commented on PR #167:
URL: https://github.com/apache/maven-wrapper/pull/167#issuecomment-2921364877
> The commit subject should be also the same as for PR, I will override by squash
okay Thank you.. I think i also need to re-run these failed checks becuase of [POSIX conformity / shellcheck] issue
which is fixed now. but i dont think I have the access to run that job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MWRAPPER-162] - Removed dead link was getting 404 [maven-wrapper]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #167:
URL: https://github.com/apache/maven-wrapper/pull/167#issuecomment-2921370705
No problem, to build pass you also need to rebase your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org