You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/11/13 00:32:42 UTC
[GitHub] [systemds] Baunsgaard opened a new pull request #1102: [SYSTEMDS-2727-9] Federated CM, qsort & qpick
Baunsgaard opened a new pull request #1102:
URL: https://github.com/apache/systemds/pull/1102
Thanks to Olga in setting these up in #1091.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on pull request #1102: [SYSTEMDS-2727-9] Federated CM, qsort & qpick
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1102:
URL: https://github.com/apache/systemds/pull/1102#issuecomment-726431330
Hi, @OlgaOvcharenko
I have taken your code and merged it with master,
there are some things we need to clean up in federationUtils (partially because i reintroduced some of our working aggregate functions), but otherwise the code looks fine.
Tomorrow either you or me have to finish this up to be ready to merge with master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on a change in pull request #1102: [SYSTEMDS-2727-9] Federated CM, qsort & qpick
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #1102:
URL: https://github.com/apache/systemds/pull/1102#discussion_r522528704
##########
File path: scripts/builtin/dist.dml
##########
@@ -23,7 +23,8 @@
m_dist = function(Matrix[Double] X) return (Matrix[Double] Y) {
G = X %*% t(X);
I = matrix(1, rows = nrow(G), cols = ncol(G));
- Y = -2 * (G) + t(I %*% diag(diag(G))) + t(diag(diag(G)) %*% I);
+ Y = -2 * (G) + (diag(G) * I) + (I * t(diag(G)));
+# Y = -2 * (G) + t(I %*% diag(diag(G))) + t(diag(diag(G)) %*% I);
Review comment:
why change this @OlgaOvcharenko
I think it does the same but did not verify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard closed pull request #1102: [SYSTEMDS-2727-9] Federated CM, qsort & qpick
Posted by GitBox <gi...@apache.org>.
Baunsgaard closed pull request #1102:
URL: https://github.com/apache/systemds/pull/1102
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] OlgaOvcharenko commented on a change in pull request #1102: [SYSTEMDS-2727-9] Federated CM, qsort & qpick
Posted by GitBox <gi...@apache.org>.
OlgaOvcharenko commented on a change in pull request #1102:
URL: https://github.com/apache/systemds/pull/1102#discussion_r522547591
##########
File path: scripts/builtin/dist.dml
##########
@@ -23,7 +23,8 @@
m_dist = function(Matrix[Double] X) return (Matrix[Double] Y) {
G = X %*% t(X);
I = matrix(1, rows = nrow(G), cols = ncol(G));
- Y = -2 * (G) + t(I %*% diag(diag(G))) + t(diag(diag(G)) %*% I);
+ Y = -2 * (G) + (diag(G) * I) + (I * t(diag(G)));
+# Y = -2 * (G) + t(I %*% diag(diag(G))) + t(diag(diag(G)) %*% I);
Review comment:
Right, the same, just thought it would be simpler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org