You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/02/14 07:48:30 UTC

[GitHub] [carbondata] jackylk commented on a change in pull request #3619: [HOTFIX] Remove unused fields in TableInfo

jackylk commented on a change in pull request #3619: [HOTFIX] Remove unused fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619#discussion_r379289159
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDropTableCommand.scala
 ##########
 @@ -110,28 +97,6 @@ case class CarbonDropTableCommand(
 
       CarbonEnv.getInstance(sparkSession).carbonMetaStore.dropTable(identifier)(sparkSession)
 
-      if (carbonTable.hasDataMapSchema) {
-        // drop all child tables
-       val childSchemas = carbonTable.getTableInfo.getDataMapSchemaList
-
-        childDropCommands = childSchemas.asScala
-          .filter(_.getRelationIdentifier != null)
-          .map { childSchema =>
-            val childTable =
-              CarbonEnv.getCarbonTable(
-                TableIdentifier(childSchema.getRelationIdentifier.getTableName,
-                  Some(childSchema.getRelationIdentifier.getDatabaseName)))(sparkSession)
-            val dropCommand = CarbonDropTableCommand(
-              ifExistsSet = true,
-              Some(childSchema.getRelationIdentifier.getDatabaseName),
-              childSchema.getRelationIdentifier.getTableName,
-              dropChildTable = true
-            )
-            dropCommand.carbonTable = childTable
-            dropCommand
-          }
-        childDropCommands.foreach(_.processMetadata(sparkSession))
-      }
       val indexDatamapSchemas =
 
 Review comment:
   fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services