You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "Otto Fowler (JIRA)" <ji...@apache.org> on 2017/07/08 16:21:00 UTC
[jira] [Commented] (METRON-1013) StellarShell does not validate
parameters
[ https://issues.apache.org/jira/browse/METRON-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079211#comment-16079211 ]
Otto Fowler commented on METRON-1013:
-------------------------------------
[~nickwallen]I have only added validation for parameters
> StellarShell does not validate parameters
> -----------------------------------------
>
> Key: METRON-1013
> URL: https://issues.apache.org/jira/browse/METRON-1013
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Otto Fowler
>
> If you pass an invalid url to -z for example - you will get a wait and then an exception crashing the shell.
> In the case of -z, I am not sure url is the right name, since we want host:port, with host being a valid name or ip address and port.
> We also do use a default port if none is provided, we probably should.
> A 'dev' default for the whole thing would be 'node1:2181', to match our vagrant environments. I propose that we use that.
> Thus:
> * no -z => node1:2181
> * -z -> validate host name, if no port then 2181
> * if port then validate port
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)