[GitHub] [netbeans] mbien commented on pull request #4206: Make one connection to download a file, not three

[GitBox <gi...@apache.org>]

mbien commented on PR #4206:
URL: https://github.com/apache/netbeans/pull/4206#issuecomment-1149259371

   Hi @jgneff,
   
   > The `openConnection` method of `ConfigureProxy` makes up to three connections to a remote host for each external file, yet only one is ever used. The extra connections cause the build to fail when the proxy or host responds with status code "503 Service Unavailable."
   
   I am not sure why it connects in parallel, I tracked it down to the pre-apache repo to this commit: https://github.com/emilianbold/netbeans-releases/commit/3050498b5d0ee3fae4fd8b34343fe637b22d2b91, unfortunately that doesn't help a lot. Maybe @jtulach remembers. It might have been performance reasons, e.g one thread timing out would not influence the others - but that is only speculation.
   
   However I have to wonder: wouldn't the safer fix be to simply ignore errors unless all tasks fail? I can't imagine 1500 connections would be a problem in a ~10min build. Thats probably similar to reading an article online without an add blocker active :)
   
   If we end up deciding to change this to an sequential approach, I believe we should use one task which does all sequentially. Having a countdown latch, thee tasks on one thread is probably not necessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists