You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Julien Lavigne du Cadet (JIRA)" <qp...@incubator.apache.org> on 2009/12/04 18:38:20 UTC
[jira] Created: (QPID-2240) [.Net 0-10] When authentication fails
on connect(), the api should raise an exception
[.Net 0-10] When authentication fails on connect(), the api should raise an exception
--------------------------------------------------------------------------------------
Key: QPID-2240
URL: https://issues.apache.org/jira/browse/QPID-2240
Project: Qpid
Issue Type: Bug
Components: Dot Net Client
Affects Versions: 0.5
Reporter: Julien Lavigne du Cadet
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2240) [.Net 0-10] When authentication fails
on connect(), the api should raise an exception
Posted by "Julien Lavigne du Cadet (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Lavigne du Cadet updated QPID-2240:
------------------------------------------
Attachment: qpid-dotnet.patch
This patch also fixes QPID-2239.
As explained to Aidan, this stuff is probably a bit hacky as I'm not that familiar with the structure of the code... That's also why this patch covers 2 issues at once, as I'm not 100% which part applies to what (it's 6 months old... !)
Anyway, all I'm saying is there's probably a better way to handle that and I won't mind at all if this stuff is rejected due to bad quality :-).
> [.Net 0-10] When authentication fails on connect(), the api should raise an exception
> --------------------------------------------------------------------------------------
>
> Key: QPID-2240
> URL: https://issues.apache.org/jira/browse/QPID-2240
> Project: Qpid
> Issue Type: Bug
> Components: Dot Net Client
> Affects Versions: 0.5
> Reporter: Julien Lavigne du Cadet
> Attachments: qpid-dotnet.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2240) [.Net 0-10] When authentication fails
on connect(), the api should raise an exception
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787228#action_12787228 ]
Aidan Skinner commented on QPID-2240:
-------------------------------------
I think this patch is OK in principle, a couple of minor nits:
chunks of commented out code, these should just be removed instead.
Qpid style preference is to always use braces for one line blocks:
if (foo) {
bar()
}
instead of
if (foo)
bar()
Other than that I don't see a problem with it, it's definitely better than leaving the bugs unfixed. It'd be good to get another set of eyes on it though since I'm not *hugely* familiar with this part of the codebase.
> [.Net 0-10] When authentication fails on connect(), the api should raise an exception
> --------------------------------------------------------------------------------------
>
> Key: QPID-2240
> URL: https://issues.apache.org/jira/browse/QPID-2240
> Project: Qpid
> Issue Type: Bug
> Components: Dot Net Client
> Affects Versions: 0.5
> Reporter: Julien Lavigne du Cadet
> Attachments: qpid-dotnet.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2240) [.Net 0-10] When authentication fails
on connect(), the api should raise an exception
Posted by "Julien Lavigne du Cadet (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Lavigne du Cadet updated QPID-2240:
------------------------------------------
Attachment: missing files.patch
The missing files from the first patch, sorry about that !
Let me know if there is any other problem
> [.Net 0-10] When authentication fails on connect(), the api should raise an exception
> --------------------------------------------------------------------------------------
>
> Key: QPID-2240
> URL: https://issues.apache.org/jira/browse/QPID-2240
> Project: Qpid
> Issue Type: Bug
> Components: Dot Net Client
> Affects Versions: 0.5
> Reporter: Julien Lavigne du Cadet
> Attachments: missing files.patch, qpid-dotnet.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2240) [.Net 0-10] When authentication fails
on connect(), the api should raise an exception
Posted by "Julien Lavigne du Cadet (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787368#action_12787368 ]
Julien Lavigne du Cadet commented on QPID-2240:
-----------------------------------------------
Thanks for the feedback, I'll keep your remarks in mind for any new patch !
> [.Net 0-10] When authentication fails on connect(), the api should raise an exception
> --------------------------------------------------------------------------------------
>
> Key: QPID-2240
> URL: https://issues.apache.org/jira/browse/QPID-2240
> Project: Qpid
> Issue Type: Bug
> Components: Dot Net Client
> Affects Versions: 0.5
> Reporter: Julien Lavigne du Cadet
> Attachments: qpid-dotnet.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Resolved: (QPID-2240) [.Net 0-10] When authentication fails
on connect(), the api should raise an exception
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Stitcher resolved QPID-2240.
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.6
In 0.6rc2
> [.Net 0-10] When authentication fails on connect(), the api should raise an exception
> --------------------------------------------------------------------------------------
>
> Key: QPID-2240
> URL: https://issues.apache.org/jira/browse/QPID-2240
> Project: Qpid
> Issue Type: Bug
> Components: Dot Net Client
> Affects Versions: 0.5
> Reporter: Julien Lavigne du Cadet
> Fix For: 0.6
>
> Attachments: missing files.patch, qpid-dotnet.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2240) [.Net 0-10] When authentication fails
on connect(), the api should raise an exception
Posted by "Slava T (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787385#action_12787385 ]
Slava T commented on QPID-2240:
-------------------------------
Thanks, Julien, for the patch.
Helpers/ConfigHelpers.cs and interop/ConnectionTests.cs are missing in the Test project. Can you please fix?
> [.Net 0-10] When authentication fails on connect(), the api should raise an exception
> --------------------------------------------------------------------------------------
>
> Key: QPID-2240
> URL: https://issues.apache.org/jira/browse/QPID-2240
> Project: Qpid
> Issue Type: Bug
> Components: Dot Net Client
> Affects Versions: 0.5
> Reporter: Julien Lavigne du Cadet
> Attachments: qpid-dotnet.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org