You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/11 12:38:45 UTC

[GitHub] [flink] aljoscha opened a new pull request #11062: [FLINK-15993]/[FLINK-15997] Rework documentation 404 page

aljoscha opened a new pull request #11062: [FLINK-15993]/[FLINK-15997] Rework documentation 404 page
URL: https://github.com/apache/flink/pull/11062
 
 
   Before, we would immediately redirect without the user knowing what's going on. Now we redirect after 5 seconds. This also adds explanatory text and makes the 404 page look like a regular documentation page, with sidenav and everything.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha merged pull request #11062: [FLINK-15993]/[FLINK-15997] Rework documentation 404 page

Posted by GitBox <gi...@apache.org>.
aljoscha merged pull request #11062: [FLINK-15993]/[FLINK-15997] Rework documentation 404 page
URL: https://github.com/apache/flink/pull/11062
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11062: [FLINK-15993]/[FLINK-15997] Rework documentation 404 page

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11062: [FLINK-15993]/[FLINK-15997] Rework documentation 404 page
URL: https://github.com/apache/flink/pull/11062#issuecomment-584634042
 
 
   <!--
   Meta data
   Hash:5a3754b60be803332c157af9f8606e55ea188845 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148375181 TriggerType:PUSH TriggerID:5a3754b60be803332c157af9f8606e55ea188845
   Hash:5a3754b60be803332c157af9f8606e55ea188845 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5059 TriggerType:PUSH TriggerID:5a3754b60be803332c157af9f8606e55ea188845
   -->
   ## CI report:
   
   * 5a3754b60be803332c157af9f8606e55ea188845 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148375181) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5059) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11062: [FLINK-15993]/[FLINK-15997] Rework documentation 404 page

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11062: [FLINK-15993]/[FLINK-15997] Rework documentation 404 page
URL: https://github.com/apache/flink/pull/11062#issuecomment-584616127
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 5a3754b60be803332c157af9f8606e55ea188845 (Tue Feb 11 12:41:38 UTC 2020)
   
   **Warnings:**
    * Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11062: [FLINK-15993]/[FLINK-15997] Rework documentation 404 page

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11062: [FLINK-15993]/[FLINK-15997] Rework documentation 404 page
URL: https://github.com/apache/flink/pull/11062#issuecomment-584634042
 
 
   <!--
   Meta data
   Hash:5a3754b60be803332c157af9f8606e55ea188845 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148375181 TriggerType:PUSH TriggerID:5a3754b60be803332c157af9f8606e55ea188845
   Hash:5a3754b60be803332c157af9f8606e55ea188845 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5059 TriggerType:PUSH TriggerID:5a3754b60be803332c157af9f8606e55ea188845
   -->
   ## CI report:
   
   * 5a3754b60be803332c157af9f8606e55ea188845 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148375181) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5059) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11062: [FLINK-15993]/[FLINK-15997] Rework documentation 404 page

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11062: [FLINK-15993]/[FLINK-15997] Rework documentation 404 page
URL: https://github.com/apache/flink/pull/11062#issuecomment-584634042
 
 
   <!--
   Meta data
   Hash:5a3754b60be803332c157af9f8606e55ea188845 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:5a3754b60be803332c157af9f8606e55ea188845
   -->
   ## CI report:
   
   * 5a3754b60be803332c157af9f8606e55ea188845 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services