[GitHub] [dubbo-go] gaoxinge commented on issue #1044: registry simplified ignore user params

[GitBox <gi...@apache.org>]

gaoxinge commented on issue #1044:
URL: https://github.com/apache/dubbo-go/issues/1044#issuecomment-827391745


   https://github.com/apache/dubbo-go/blob/3a9956a2a24c6736caae198b466a77ee979a5fd4/registry/protocol/protocol.go#L96-L102
   
   In go version code, provider url will only reserve `reserveParams` if there is `simplified` keyword in registry url. This is the same as java version ([[1](https://github.com/apache/dubbo/blob/936c6624d3ce99cd05ebe03ede62dc671cf7b702/dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java#L405)], [[2](https://github.com/apache/dubbo/blob/936c6624d3ce99cd05ebe03ede62dc671cf7b702/dubbo-common/src/main/java/org/apache/dubbo/common/URL.java#L395-L402)]).
   
   In my opinion:
   
   - removing params, which is not reserved keyword, is by design
   - the problem is that consul can not work without setting `simplified` keyword, because dubbo-go (or dubbo) register with too many parameters in registry


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org