You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/11/23 04:19:00 UTC
[kudu-CR] [tablet] a small cleanup on DeltaTracker and around
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19269
Change subject: [tablet] a small cleanup on DeltaTracker and around
......................................................................
[tablet] a small cleanup on DeltaTracker and around
I was briefly looking at the compaction-related code and noticed a bit
of room for improvement. This patch is the result. It introduces
a bunch of minor changes to DeltaTracker and compaction-related code:
* updated DeltaTracker::Update() to accept nullptr for the
OperationResultPB output parameter
* removed per-block heap allocated instance of OperationResultPB
in ReupdateMissedDeltas()
* switched to std::atomic<bool> instead of AtomicBool for the
DeltaTracker::dms_exists_ field
* renamed delta_tracker() --> mutable_delta_tracker() for DiskRowSet
* introduced DiskRowSet::delta_tracker() to return const reference
(this is going to be used in a follow-up patch)
* updated RowSetMetadata::Commit{Redo,Undo}DeltaDataBlock() to
return 'void' instead of 'Status'
* added a few DCHECK macros to spot inconsistencies
* updated related code to be more style-compliant
Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
---
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/delta_store.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/diskrowset.h
M src/kudu/tablet/metadata-test.cc
M src/kudu/tablet/rowset_metadata.cc
M src/kudu/tablet/rowset_metadata.h
M src/kudu/tablet/tablet.cc
13 files changed, 85 insertions(+), 80 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/19269/1
--
To view, visit http://gerrit.cloudera.org:8080/19269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
Gerrit-Change-Number: 19269
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [tablet] a small cleanup on DeltaTracker and around
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19269 )
Change subject: [tablet] a small cleanup on DeltaTracker and around
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
Gerrit-Change-Number: 19269
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 07:56:51 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] a small cleanup on DeltaTracker and around
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tablet] a small cleanup on DeltaTracker and around
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
Gerrit-Change-Number: 19269
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [tablet] a small cleanup on DeltaTracker and around
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19269 )
Change subject: [tablet] a small cleanup on DeltaTracker and around
......................................................................
Patch Set 2: Verified+1
unrelated test failures:
* LocationAwareRebalancingParamTest.RebalanceWithIgnoredTServer
* MasterReplicationAndRpcSizeLimitTest.TabletReports
--
To view, visit http://gerrit.cloudera.org:8080/19269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
Gerrit-Change-Number: 19269
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 05:31:30 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] a small cleanup on DeltaTracker and around
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19269 )
Change subject: [tablet] a small cleanup on DeltaTracker and around
......................................................................
[tablet] a small cleanup on DeltaTracker and around
I was briefly looking at the compaction-related code and noticed a bit
of room for improvement. This patch is the result. It introduces
a bunch of minor changes to DeltaTracker and compaction-related code:
* updated DeltaTracker::Update() to accept nullptr for the
OperationResultPB output parameter
* removed per-block heap allocated instance of OperationResultPB
in ReupdateMissedDeltas()
* switched to std::atomic<bool> instead of AtomicBool for the
DeltaTracker::dms_exists_ field
* renamed delta_tracker() --> mutable_delta_tracker() for DiskRowSet
* introduced DiskRowSet::delta_tracker() to return const reference
(this is going to be used in a follow-up patch)
* updated RowSetMetadata::Commit{Redo,Undo}DeltaDataBlock() to
return 'void' instead of 'Status'
* added a few DCHECK macros to spot inconsistencies
* updated related code to be more style-compliant
Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
Reviewed-on: http://gerrit.cloudera.org:8080/19269
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/delta_store.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/diskrowset.h
M src/kudu/tablet/metadata-test.cc
M src/kudu/tablet/rowset_metadata.cc
M src/kudu/tablet/rowset_metadata.h
M src/kudu/tablet/tablet.cc
13 files changed, 86 insertions(+), 81 deletions(-)
Approvals:
Alexey Serbin: Verified
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
Gerrit-Change-Number: 19269
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [tablet] a small cleanup on DeltaTracker and around
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19269 )
Change subject: [tablet] a small cleanup on DeltaTracker and around
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19269/1/src/kudu/tablet/delta_tracker.cc
File src/kudu/tablet/delta_tracker.cc:
http://gerrit.cloudera.org:8080/#/c/19269/1/src/kudu/tablet/delta_tracker.cc@686
PS1, Line 686: &
nit: left-align & here too
--
To view, visit http://gerrit.cloudera.org:8080/19269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
Gerrit-Change-Number: 19269
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 14:11:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tablet] a small cleanup on DeltaTracker and around
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19269 )
Change subject: [tablet] a small cleanup on DeltaTracker and around
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
Gerrit-Change-Number: 19269
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 29 Nov 2022 03:20:11 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] a small cleanup on DeltaTracker and around
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Ashwani Raina, Attila Bukor, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19269
to look at the new patch set (#2).
Change subject: [tablet] a small cleanup on DeltaTracker and around
......................................................................
[tablet] a small cleanup on DeltaTracker and around
I was briefly looking at the compaction-related code and noticed a bit
of room for improvement. This patch is the result. It introduces
a bunch of minor changes to DeltaTracker and compaction-related code:
* updated DeltaTracker::Update() to accept nullptr for the
OperationResultPB output parameter
* removed per-block heap allocated instance of OperationResultPB
in ReupdateMissedDeltas()
* switched to std::atomic<bool> instead of AtomicBool for the
DeltaTracker::dms_exists_ field
* renamed delta_tracker() --> mutable_delta_tracker() for DiskRowSet
* introduced DiskRowSet::delta_tracker() to return const reference
(this is going to be used in a follow-up patch)
* updated RowSetMetadata::Commit{Redo,Undo}DeltaDataBlock() to
return 'void' instead of 'Status'
* added a few DCHECK macros to spot inconsistencies
* updated related code to be more style-compliant
Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
---
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/delta_store.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/diskrowset.h
M src/kudu/tablet/metadata-test.cc
M src/kudu/tablet/rowset_metadata.cc
M src/kudu/tablet/rowset_metadata.h
M src/kudu/tablet/tablet.cc
13 files changed, 86 insertions(+), 81 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/19269/2
--
To view, visit http://gerrit.cloudera.org:8080/19269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
Gerrit-Change-Number: 19269
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [tablet] a small cleanup on DeltaTracker and around
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19269 )
Change subject: [tablet] a small cleanup on DeltaTracker and around
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19269/1/src/kudu/tablet/delta_tracker.cc
File src/kudu/tablet/delta_tracker.cc:
http://gerrit.cloudera.org:8080/#/c/19269/1/src/kudu/tablet/delta_tracker.cc@686
PS1, Line 686: &
> nit: left-align & here too
Done
--
To view, visit http://gerrit.cloudera.org:8080/19269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
Gerrit-Change-Number: 19269
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 00:04:45 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tablet] a small cleanup on DeltaTracker and around
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19269 )
Change subject: [tablet] a small cleanup on DeltaTracker and around
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e42c72664c07e126f8cce5f071db56c0b4fe48c
Gerrit-Change-Number: 19269
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 23 Nov 2022 15:24:31 +0000
Gerrit-HasComments: No