[GitHub] [pulsar] sijie commented on a change in pull request #4374: [rest] improve clusters rest endpoint by documenting the endpoints with more swagger annotations

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #4374: [rest] improve clusters rest endpoint by documenting the endpoints with more swagger annotations
URL: https://github.com/apache/pulsar/pull/4374#discussion_r288003526
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java
 ##########
 @@ -434,12 +605,29 @@ public NamespaceIsolationData getNamespaceIsolationPolicy(@PathParam("cluster")
 
     @GET
     @Path("/{cluster}/namespaceIsolationPolicies/brokers/{broker}")
-    @ApiOperation(value = "Get a broker with namespace-isolation policies attached to it", response = BrokerNamespaceIsolationData.class)
-    @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"),
-            @ApiResponse(code = 404, message = "Namespace-isolation policies/ Broker not found"),
-            @ApiResponse(code = 412, message = "Cluster doesn't exist") })
-    public BrokerNamespaceIsolationData getBrokerWithNamespaceIsolationPolicy(@PathParam("cluster") String cluster,
-            @PathParam("broker") String broker) {
+    @ApiOperation(
+        value = "Get a broker with namespace-isolation policies attached to it",
+        response = BrokerNamespaceIsolationData.class,
+        notes = "This operation requires Pulsar super-user privileges."
+    )
+    @ApiResponses(value = {
+        @ApiResponse(code = 403, message = "Don't have admin permission"),
+        @ApiResponse(code = 404, message = "Namespace-isolation policies/ Broker not found"),
 
 Review comment:
   yes in either case, pulsar returns 404

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services