[jira] Commented: (MYFACES-2541) Support for actionlistener method without ActionEvent parameter

["Jakob Korherr (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832453#action_12832453 ] 

Jakob Korherr commented on MYFACES-2541:
----------------------------------------

Martin,

PLEASE try to write the code in a constant style and also really try to follow the code style guidelines. Your { } brackets are mostly set wrong (especially in the test case) and you also tend to include lots of unnecessary blanks (e.g. EasyMock.aryEq(  new Object [] {})). Of course, this is not wrong, but it looks very odd. Furthermore the license information was missing in the test case. I also noticed two static variables at the bottom of the class. Static variables and methods should always be at the top of the class.

I also noticed that you did not write the tearDown() method as supposed (set all instances created in setUp() to null) and I also completed the last test case testRestoreState() by using reflection to verify that the state is restored correctly.

> Support for actionlistener method without ActionEvent parameter
> ---------------------------------------------------------------
>
>                 Key: MYFACES-2541
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2541
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>         Environment: myfaces trunk
>            Reporter: Martin Koci
>            Assignee: Jakob Korherr
>         Attachments: MYFACES-2541.patch
>
>
> With JSF 2.0 is possible to have actionListener method without ActionEvent param: https://javaserverfaces.dev.java.net/nonav/docs/2.0/javadocs/javax/faces/event/MethodExpressionActionListener.html#MethodExpressionActionListener

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.