You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by tdurand <gi...@git.apache.org> on 2014/10/02 17:55:52 UTC
[GitHub] cordova-plugin-file pull request: Evo: Document the iosExtraFilesy...
GitHub user tdurand opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/82
Evo: Document the iosExtraFilesystems usage
This feature was undocumented, here is a stackoverflow discussion about this subject: https://stackoverflow.com/questions/26151731/cordova-phonegap-ios-filesystem-custom-root-path-iosextrafilesystems-is-not
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tdurand/cordova-plugin-file patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
----
commit 8c2297d69b01efff3e4215270331054702a3bee3
Author: Thibault Durand <ti...@gmail.com>
Date: 2014-10-02T15:55:00Z
Evo: Document the iosExtraFilesystems usage
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: Evo: Document the iosExtraFilesy...
Posted by clelland <gi...@git.apache.org>.
Github user clelland commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/82#issuecomment-58092692
I don't think that recommending `window.requestFileSystem(3,...)` is the right way to go here. Off the top of my head, I can think of two better ways to access these extra filesystem roots:
1. Use a `cdvfile://` URL:
resolveLocalFileSystemURL("cdvfile://localhost/library-nosync/", function(entry) {
// Successful, use entry
}, function(err) {
// Error, do something
});
2. Use the `cordova.file.*Directory` properties:
resolveLocalFileSystemURL(cordova.file.dataDirectory, function(entry) {
// Successful, use entry
}, function(err) {
// Error, do something
});
Both of these could be better-documented (one requires you to know how to construct a cdvfile: URL; the other requires you to now that `dataDirectory` maps to Library-nosync). I don't want to add instructions that tell people to hard code the magic constant `3`, which is, as you say, likely to change if the config preference changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Evo: Document the iosExtraFilesy...
Posted by tdurand <gi...@git.apache.org>.
Github user tdurand commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/82#issuecomment-58124232
Well, thanks, i don't know how i've missed the resolveLocalFileSystemURL in the documentation .. Maybe it can be good to put an example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org