[GitHub] [flink] rkhachatryan commented on a change in pull request #14656: [FLINK-20675][checkpointing] Ensure asynchronous checkpoint failure could fail the job by default

[GitBox <gi...@apache.org>]

rkhachatryan commented on a change in pull request #14656:
URL: https://github.com/apache/flink/pull/14656#discussion_r566178176



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/rpc/RpcCheckpointResponder.java
##########
@@ -55,7 +56,16 @@ public void declineCheckpoint(
             long checkpointId,
             Throwable cause) {
 
+        // TODO the passed parameter 'cause' is actually always instance of CheckpointException,
+        //  we should change the interfaces to narrow all declined checkpoint's throwable to
+        // CheckpointException.

Review comment:
       IIUC, the same TODO was fixed in the corresponding PR for 1.13.
   What's the reasoning behind not fixing it for 1.12?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org