You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/09 10:32:57 UTC

[GitHub] [spark] mgaido91 opened a new pull request #24564: [SPARK-27625][SQL] ScalaReflection support for annotated types

mgaido91 opened a new pull request #24564: [SPARK-27625][SQL] ScalaReflection support for annotated types
URL: https://github.com/apache/spark/pull/24564
 
 
   ## What changes were proposed in this pull request?
   
   If a type is annotated, `ScalaReflection` can fail if the datatype is an `Option`, a `Seq`, a `Map` and other similar types. This is because it assumes we are dealing with `TypeRef`, while types with annotations are `AnnotatedType`.
   
   The PR deals with the case the annotation is present.
   
   ## How was this patch tested?
   
   added UT
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org