You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by da...@apache.org on 2018/02/20 10:46:44 UTC

[kafka] branch 1.1 updated: MINOR: Fix file source task configs in system tests.

This is an automated email from the ASF dual-hosted git repository.

damianguy pushed a commit to branch 1.1
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/1.1 by this push:
     new 323e555  MINOR: Fix file source task configs in system tests.
323e555 is described below

commit 323e555074344aeddd6e747067c403833582ab06
Author: Konstantine Karantasis <ko...@confluent.io>
AuthorDate: Tue Feb 20 10:45:50 2018 +0000

    MINOR: Fix file source task configs in system tests.
    
    Another fall-through of `headers.converter` and `batch.size` properties. Here in `FileStreamSourceConnector` tests
    
    Author: Konstantine Karantasis <ko...@confluent.io>
    
    Reviewers: Randall Hauch <rh...@gmail.com>, Damian Guy <da...@gmail.com>
    
    Closes #4590 from kkonstantine/MINOR-Fix-file-source-task-config-in-system-tests
    
    (cherry picked from commit f10c0d38634822ab4c9abc4744268c9fd5b50a2c)
    Signed-off-by: Damian Guy <da...@gmail.com>
---
 tests/kafkatest/tests/connect/connect_rest_test.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/kafkatest/tests/connect/connect_rest_test.py b/tests/kafkatest/tests/connect/connect_rest_test.py
index 8172df3..3c7cd89 100644
--- a/tests/kafkatest/tests/connect/connect_rest_test.py
+++ b/tests/kafkatest/tests/connect/connect_rest_test.py
@@ -31,14 +31,15 @@ class ConnectRestApiTest(KafkaTest):
     FILE_SOURCE_CONNECTOR = 'org.apache.kafka.connect.file.FileStreamSourceConnector'
     FILE_SINK_CONNECTOR = 'org.apache.kafka.connect.file.FileStreamSinkConnector'
 
-    FILE_SOURCE_CONFIGS = {'name', 'connector.class', 'tasks.max', 'key.converter', 'value.converter', 'topic', 'file', 'transforms'}
-    FILE_SINK_CONFIGS = {'name', 'connector.class', 'tasks.max', 'key.converter', 'value.converter', 'topics', 'file', 'transforms', 'topics.regex'}
+    FILE_SOURCE_CONFIGS = {'name', 'connector.class', 'tasks.max', 'key.converter', 'value.converter', 'header.converter', 'batch.size', 'topic', 'file', 'transforms'}
+    FILE_SINK_CONFIGS = {'name', 'connector.class', 'tasks.max', 'key.converter', 'value.converter', 'header.converter', 'topics', 'file', 'transforms', 'topics.regex'}
 
     INPUT_FILE = "/mnt/connect.input"
     INPUT_FILE2 = "/mnt/connect.input2"
     OUTPUT_FILE = "/mnt/connect.output"
 
     TOPIC = "test"
+    DEFAULT_BATCH_SIZE = "2000"
     OFFSETS_TOPIC = "connect-offsets"
     OFFSETS_REPLICATION_FACTOR = "1"
     OFFSETS_PARTITIONS = "1"
@@ -141,7 +142,8 @@ class ConnectRestApiTest(KafkaTest):
             'config': {
                 'task.class': 'org.apache.kafka.connect.file.FileStreamSourceTask',
                 'file': self.INPUT_FILE,
-                'topic': self.TOPIC
+                'topic': self.TOPIC,
+                'batch.size': self.DEFAULT_BATCH_SIZE
             }
         }]
         source_task_info = self.cc.get_connector_tasks("local-file-source")

-- 
To stop receiving notification emails like this one, please contact
damianguy@apache.org.