[GitHub] [spark] MaxGekk commented on a change in pull request #24567: [SPARK-27638][SQL]: date format 'yyyy-M-dd' string comparison not handled properly

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #24567: [SPARK-27638][SQL]: date format 'yyyy-M-dd' string comparison not handled properly
URL: https://github.com/apache/spark/pull/24567#discussion_r283127394
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
 ##########
 @@ -120,11 +120,11 @@ object TypeCoercion {
    */
   private def findCommonTypeForBinaryComparison(
       dt1: DataType, dt2: DataType, conf: SQLConf): Option[DataType] = (dt1, dt2) match {
-    // We should cast all relative timestamp/date/string comparison into string comparisons
+    case (StringType, DateType) => Some(DateType)
 
 Review comment:
   I have removed these 2 cases but the added test still completes successfully. We need a few tests that fail without the changes in `findCommonTypeForBinaryComparison`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org