You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/19 15:49:02 UTC
[GitHub] [doris] mrhhsg opened a new pull request, #10249: [improvement]Separate input and output parameters in ColumnPredicate
mrhhsg opened a new pull request, #10249:
URL: https://github.com/apache/doris/pull/10249
This code:
```cpp
for (uint16_t i = 0; i < *size; ++i) {
// some code here
}
```
The value of size is read for each conditional test, which also prevents possible vectorization.
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Test with ssb-flat 100g q2.3:
```sql
SELECT
SUM(LO_REVENUE), (LO_ORDERDATE DIV 10000) AS YEAR,
P_BRAND
FROM lineorder_flat
WHERE
P_BRAND = 'MFGR#2239'
AND S_REGION ='EUROPE'
GROUP BY YEAR, P_BRAND
ORDER BY YEAR, P_BRAND;
```
|master|column_predicate_opt|
|-|-|
|<img width="241" alt="image" src="https://user-images.githubusercontent.com/1179834/174489400-097402a9-9cd6-456e-a8a7-305c74f61a9a.png">|<img width="239" alt="image" src="https://user-images.githubusercontent.com/1179834/174489452-5c66a168-8093-4e52-a937-edf38c65907a.png">|
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10249: [improvement]Separate input and output parameters in ColumnPredicate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10249:
URL: https://github.com/apache/doris/pull/10249#issuecomment-1159860154
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10249: [improvement]Separate input and output parameters in ColumnPredicate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10249:
URL: https://github.com/apache/doris/pull/10249#issuecomment-1159860179
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #10249: [improvement]Separate input and output parameters in ColumnPredicate
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10249:
URL: https://github.com/apache/doris/pull/10249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org