You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/11/25 02:07:00 UTC

[GitHub] [trafficcontrol] mitchell852 opened a new issue #5333: Suppress DS consistent hash query params change log entry if nothing changed

mitchell852 opened a new issue #5333:
URL: https://github.com/apache/trafficcontrol/issues/5333


   ## I'm submitting a ...
   -  improvement request (usability, performance, tech debt, etc.)
   
   ## Traffic Control components affected ...
   -  Traffic Ops
   
   ## Current behavior:
   Every time a DS is created or updated, the following change log entry is created when no consistent hash query params are created.
   
   ```
   DS: my-ds-xml-id, ID: 999, ACTION: Created 0 consistent hash query params
   ```
   
   Doesn't make much sense to me.
   
   ## New behavior:
   Don't do that if nothing changed with regards to a delivery service's consistent hash query params. If it went from 0 to 1 or 1 to 0 or 2 to 4, then the change log makes sense, otherwise, nobody cares. :)
   
   ## Minimal reproduction of the problem with instructions:
   Create or update a delivery service. Notice the consistent hash query params change log entry.
   
   ## Anything else:
   <!--
   e.g. additional context, related issues, suggestions about how to approach (feel
   free to delete this section)
   -->
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
       https://apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mitchell852 closed issue #5333: Suppress DS consistent hash query params change log entry if nothing changed

Posted by GitBox <gi...@apache.org>.
mitchell852 closed issue #5333:
URL: https://github.com/apache/trafficcontrol/issues/5333


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp commented on issue #5333: Suppress DS consistent hash query params change log entry if nothing changed

Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #5333:
URL: https://github.com/apache/trafficcontrol/issues/5333#issuecomment-733952765


   Done - https://github.com/apache/trafficcontrol/issues/5335.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mitchell852 commented on issue #5333: Suppress DS consistent hash query params change log entry if nothing changed

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #5333:
URL: https://github.com/apache/trafficcontrol/issues/5333#issuecomment-733883950


   > Also, we should probably suppress the `DS: demo, ID: 442, ACTION: Updated primary origin: demo` changelog entry if the `orgServerFqdn` wasn't changed.
   
   Agree. Want to create a separate issue for that @rawlinp ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp commented on issue #5333: Suppress DS consistent hash query params change log entry if nothing changed

Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #5333:
URL: https://github.com/apache/trafficcontrol/issues/5333#issuecomment-733427966


   I agree, but even if the CHQPs change, do we care enough to give it its own changelog entry? Or is the single DS entry enough?
   
   Also, we should probably suppress the `DS: demo, ID: 442, ACTION: Updated primary origin: demo` changelog entry if the `orgServerFqdn` wasn't changed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mitchell852 closed issue #5333: Suppress DS consistent hash query params change log entry if nothing changed

Posted by GitBox <gi...@apache.org>.
mitchell852 closed issue #5333:
URL: https://github.com/apache/trafficcontrol/issues/5333


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mitchell852 commented on issue #5333: Suppress DS consistent hash query params change log entry if nothing changed

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #5333:
URL: https://github.com/apache/trafficcontrol/issues/5333#issuecomment-733883402


   > but even if the CHQPs change, do we care enough to give it its own changelog entry? Or is the single DS entry enough?
   
   Yes, I think the DS entry is sufficient.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org