You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Aitozi (via GitHub)" <gi...@apache.org> on 2023/04/13 02:08:03 UTC
[GitHub] [flink] Aitozi opened a new pull request, #22386: [FLINK-31787][doc] Add explicit ROW constructor to sql functions doc
Aitozi opened a new pull request, #22386:
URL: https://github.com/apache/flink/pull/22386
## What is the purpose of the change
Add back the explicit ROW constructor to doc
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on a diff in pull request #22386: [FLINK-31787][doc] Add explicit ROW constructor to sql functions doc
Posted by "Aitozi (via GitHub)" <gi...@apache.org>.
Aitozi commented on code in PR #22386:
URL: https://github.com/apache/flink/pull/22386#discussion_r1165694629
##########
docs/data/sql_functions.yml:
##########
@@ -933,11 +933,13 @@ valueconstruction:
- sql: |
-- implicit constructor with parenthesis
(value1 [, value2]*)
+ -- explicit ROW constructor
Review Comment:
Fixed. Current style:
<img width="866" alt="image" src="https://user-images.githubusercontent.com/9486140/231807342-bc76ee7c-97c9-47b7-933f-5738bd69fd73.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on a diff in pull request #22386: [FLINK-31787][doc] Add explicit ROW constructor to sql functions doc
Posted by "Aitozi (via GitHub)" <gi...@apache.org>.
Aitozi commented on code in PR #22386:
URL: https://github.com/apache/flink/pull/22386#discussion_r1165532653
##########
docs/data/sql_functions.yml:
##########
@@ -933,11 +933,13 @@ valueconstruction:
- sql: |
-- implicit constructor with parenthesis
(value1 [, value2]*)
+ -- explicit ROW constructor
Review Comment:
how do you see the rendered doc ? build locally ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao closed pull request #22386: [FLINK-31787][doc] Add explicit ROW constructor to sql functions doc
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao closed pull request #22386: [FLINK-31787][doc] Add explicit ROW constructor to sql functions doc
URL: https://github.com/apache/flink/pull/22386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao commented on a diff in pull request #22386: [FLINK-31787][doc] Add explicit ROW constructor to sql functions doc
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao commented on code in PR #22386:
URL: https://github.com/apache/flink/pull/22386#discussion_r1165466847
##########
docs/data/sql_functions.yml:
##########
@@ -933,11 +933,13 @@ valueconstruction:
- sql: |
-- implicit constructor with parenthesis
(value1 [, value2]*)
+ -- explicit ROW constructor
Review Comment:
The rendered doc seems not respecting newlines, could you fix that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on pull request #22386: [FLINK-31787][doc] Add explicit ROW constructor to sql functions doc
Posted by "Aitozi (via GitHub)" <gi...@apache.org>.
Aitozi commented on PR #22386:
URL: https://github.com/apache/flink/pull/22386#issuecomment-1506815970
CC @libenchao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22386: [FLINK-31787][doc] Add explicit ROW constructor to sql functions doc
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22386:
URL: https://github.com/apache/flink/pull/22386#issuecomment-1506226134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a350087241b4eee9260a12f3f91181d3bc10109b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a350087241b4eee9260a12f3f91181d3bc10109b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a350087241b4eee9260a12f3f91181d3bc10109b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org