You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/20 03:37:23 UTC
[GitHub] [pulsar] murong00 opened a new pull request #6998: Add multi-hosts example for bookkeeperMetadataServiceUri
murong00 opened a new pull request #6998:
URL: https://github.com/apache/pulsar/pull/6998
### Motivation
Some users may be confused by `bookkeeperMetadataServiceUri` in multi-hosts case (e.g. comma list like `zk+hierarchical://zk1:2181,zk2:2181/ledgers`) since bookkeeper only support semicolon separated values currently ( my colleague is tracing this in bookkeeper master, we can overcome this in future).
### Modifications
Add multi-hosts usage example in `broker.conf`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #6998: Add multi-hosts example for bookkeeperMetadataServiceUri
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #6998:
URL: https://github.com/apache/pulsar/pull/6998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #6998: Add multi-hosts example for bookkeeperMetadataServiceUri
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #6998:
URL: https://github.com/apache/pulsar/pull/6998#discussion_r427982456
##########
File path: site2/docs/reference-configuration.md
##########
@@ -183,7 +183,7 @@ Pulsar brokers are responsible for handling incoming messages from producers, di
|brokerClientAuthenticationParameters|||
|athenzDomainNames| Supported Athenz provider domain names(comma separated) for authentication ||
|exposePreciseBacklogInPrometheus| Enable expose the precise backlog stats, set false to use published counter and consumed counter to calculate, this would be more efficient but may be inaccurate. |false|
-|bookkeeperMetadataServiceUri| Metadata service uri that bookkeeper is used for loading corresponding metadata driver and resolving its metadata service location. For example: zk+hierarchical://localhost:2181/ledgers ||
+|bookkeeperMetadataServiceUri| Metadata service uri that bookkeeper is used for loading corresponding metadata driver and resolving its metadata service location. For example: zk+hierarchical://localhost:2181/ledgers. The metadata service uri list can also be semicolon separated values like below: zk+hierarchical://zk1:2181;zk2:2181;zk3:2181/ledgers ||
Review comment:
```suggestion
|bookkeeperMetadataServiceUri| Metadata service URI that bookkeeper is used for loading corresponding metadata driver and resolving its metadata service location. For example: zk+hierarchical://localhost:2181/ledgers. The metadata service URI list can also be semicolon separated values like below: zk+hierarchical://zk1:2181;zk2:2181;zk3:2181/ledgers ||
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on pull request #6998: Add multi-hosts example for bookkeeperMetadataServiceUri
Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #6998:
URL: https://github.com/apache/pulsar/pull/6998#issuecomment-637910426
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #6998: Add multi-hosts example for bookkeeperMetadataServiceUri
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #6998:
URL: https://github.com/apache/pulsar/pull/6998#issuecomment-637212624
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6998: Add multi-hosts example for bookkeeperMetadataServiceUri
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6998:
URL: https://github.com/apache/pulsar/pull/6998#issuecomment-637361001
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6998: Add multi-hosts example for bookkeeperMetadataServiceUri
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6998:
URL: https://github.com/apache/pulsar/pull/6998#issuecomment-633599898
@murong00 Would you please rebase the master branch since there are some new changes related to the failed CI tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on pull request #6998: Add multi-hosts example for bookkeeperMetadataServiceUri
Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #6998:
URL: https://github.com/apache/pulsar/pull/6998#issuecomment-633785601
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 removed a comment on pull request #6998: Add multi-hosts example for bookkeeperMetadataServiceUri
Posted by GitBox <gi...@apache.org>.
murong00 removed a comment on pull request #6998:
URL: https://github.com/apache/pulsar/pull/6998#issuecomment-633785601
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org