You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/02 12:39:02 UTC

[GitHub] [pulsar] BewareMyPower opened a new pull request #8788: [WebSocket] Add spotbugs plugin for websocket module

BewareMyPower opened a new pull request #8788:
URL: https://github.com/apache/pulsar/pull/8788


   ### Motivation
   
   Add spotbugs plugin for WebSocket module.
   
   ### Modifications
   
   There're 20 potential bugs after adding the plugin to check. Here're the modifications to fix:
   - MS_MUTABLE_ARRAY: Change the public static array `ENTRY_LATENCY_BUCKETS_USEC` to an unmodifiableList.
   - SE_BAD_FIELD: Make the `service` field of Servlet classes `transient` to avoid being serialized.
   - URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD: Ignore these errors because it's just an encapsulation issue and some fields are used in other modules or existed clients.
   - IS2_INCONSISTENT_SYNC: Add `synchronized` keyword to the setter of `localCluster` to make all access synchronized.
   - EI_EXPOSE_REP: Return a clone of array as a snapshot.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8788: [WebSocket] Add spotbugs plugin for websocket module

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8788:
URL: https://github.com/apache/pulsar/pull/8788#issuecomment-738557958


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8788: [WebSocket] Add spotbugs plugin for websocket module

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8788:
URL: https://github.com/apache/pulsar/pull/8788#issuecomment-737310105


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8788: [WebSocket] Add spotbugs plugin for websocket module

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8788:
URL: https://github.com/apache/pulsar/pull/8788#issuecomment-738528067


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zymap commented on pull request #8788: [WebSocket] Add spotbugs plugin for websocket module

Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8788:
URL: https://github.com/apache/pulsar/pull/8788#issuecomment-737580357


   We have a fix of the integration tests. Please rebase your code. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #8788: [WebSocket] Add spotbugs plugin for websocket module

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #8788:
URL: https://github.com/apache/pulsar/pull/8788#issuecomment-737591360


   @zymap It's better to wait for #8784 merged because this PR doesn't specify the spotbugs' version.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #8788: [WebSocket] Add spotbugs plugin for websocket module

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8788:
URL: https://github.com/apache/pulsar/pull/8788


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org