You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/04/29 14:49:39 UTC
[GitHub] [solr] janhoy opened a new pull request #105: SOLR-15384 Zookeeper admin handlers not queryable from SolrJ
janhoy opened a new pull request #105:
URL: https://github.com/apache/solr/pull/105
See https://issues.apache.org/jira/browse/SOLR-15384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #105: SOLR-15384 Zookeeper admin handlers not queryable from SolrJ
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #105:
URL: https://github.com/apache/solr/pull/105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy edited a comment on pull request #105: SOLR-15384 Zookeeper admin handlers not queryable from SolrJ
Posted by GitBox <gi...@apache.org>.
janhoy edited a comment on pull request #105:
URL: https://github.com/apache/solr/pull/105#issuecomment-829590931
Thanks for the review @madrob . The issue occurs in https://github.com/apache/solr/blob/main/solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java#L1095 when SolrJ tries to identiy a path as admin or not. I wonder why we compare with a hard-coded set of absolute paths instead of doing pattern matching, e.g. `request.getPath().startsWith("/admin/")`? The `/solr/admin/*` path is reserved for admin, there cannot be a core/collection named "admin", can there?
@madrob andy thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #105: SOLR-15384 Zookeeper admin handlers not queryable from SolrJ
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #105:
URL: https://github.com/apache/solr/pull/105#issuecomment-829590931
Thanks for the review @madrob . The issue occurs in https://github.com/apache/solr/blob/main/solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java#L1095 when SolrJ tries to identiy a path as admin or not. I wonder why we compare with a hard-coded set of absolute paths instead of doing pattern matching, e.g. `request.getPath().startsWith("/admin/")`? The `/solr/admin/*` path is reserved for admin, there cannot be a core/collection named "admin", can there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org