[GitHub] [spark] gyogal commented on pull request #33936: [SPARK-36693][REPL] Implement spark-shell idle timeouts

[GitBox <gi...@apache.org>]

gyogal commented on pull request #33936:
URL: https://github.com/apache/spark/pull/33936#issuecomment-947804864


   Thanks for the review and testing @attilapiros, unfortunately this is an issue that is difficult to work around because the `SplashLoop` is only initialized after it receives its first non-empty line of input. This logic resides not in the Spark code base but in Scala, where the base class `ILoop` is coming from.
   
   Another issue I found during testing is that if the user starts a multi-line input (for example, by entering paste mode or opening a curly brace and pressing Enter), the timeout will not trigger because prompts for incomplete statements are also handled in the base class in `processLine()`, so it cannot be easily distinguished from actual processing: https://github.com/scala/scala/blob/v2.12.10/src/repl/scala/tools/nsc/interpreter/ILoop.scala#L904 - unfortunately most of the methods that would be needed to fix this logic are final or private and are located not in Spark but in Scala's REPL code base, so it may not be possible to fully implement this feature with this approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org