You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by ptgoetz <gi...@git.apache.org> on 2017/03/17 20:51:33 UTC
[GitHub] storm pull request #2018: STORM-2416: Improve Release Packaging to Reduce Fi...
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/2018
STORM-2416: Improve Release Packaging to Reduce File Size
This brings the binary distribution file size down from > 200MB to ~79MB.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptgoetz/storm STORM-2416
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2018.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2018
----
commit d6c8298d8a596589442cfa049039ff90baa33f5f
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2017-03-16T19:14:26Z
STORM-2416: break out storm-jms-examples
commit 1b514cbd0d029f7ff4bc32b1061350fede89beab
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2017-03-16T20:47:20Z
STORM-2416: move flux-examples and refactor storm-mqtt module
commit ff93e07f0d63c4942ee398cd795006984ff8e4c7
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2017-03-17T20:04:53Z
STORM-2416: normalize provided.scope across poms; move storm-perf to examples; update packaging
commit cbf064c12fa84369da765563be26077c5edf2312
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2017-03-17T20:42:33Z
STORM-2416: fix typos; stop shading Druid connector
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2018: STORM-2416: Improve Release Packaging to Reduce Fi...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2018#discussion_r106831438
--- Diff: storm-dist/binary/src/main/assembly/binary.xml ---
@@ -77,11 +77,14 @@
<exclude>js/script.js</exclude>
</excludes>
</fileSet>
+ <!-- EXAMPLES -->
<fileSet>
<directory>${project.basedir}/../../examples</directory>
<outputDirectory>examples</outputDirectory>
<excludes>
<exclude>**/target/**</exclude>
+ <exclude>**/dependency-reduced-pom.xml</exclude>
--- End diff --
Nice catch for two lines! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2018: STORM-2416: Improve Release Packaging to Reduce File Size
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2018
@ptgoetz
Could you make the change for master branch? Maybe 1.0.x branch too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2018: STORM-2416: Improve Release Packaging to Reduce File Size
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2018
@ptgoetz
OK either applying or not applying this to 1.0.x is fine for me.
Given that you're planning to apply this to master branch as well, I think this is mergeable now.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2018: STORM-2416: Improve Release Packaging to Reduce Fi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2018
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2018: STORM-2416: Improve Release Packaging to Reduce Fi...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2018#discussion_r106933223
--- Diff: examples/storm-perf/pom.xml ---
@@ -22,8 +22,8 @@
<parent>
<artifactId>storm</artifactId>
<groupId>org.apache.storm</groupId>
- <version>1.1.1-SNAPSHOT</version>
- <relativePath>..</relativePath>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
--- End diff --
@HeartSaVioR Nice catch, fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2018: STORM-2416: Improve Release Packaging to Reduce File Size
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2018
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2018: STORM-2416: Improve Release Packaging to Reduce Fi...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2018#discussion_r106855963
--- Diff: examples/storm-perf/pom.xml ---
@@ -22,8 +22,8 @@
<parent>
<artifactId>storm</artifactId>
<groupId>org.apache.storm</groupId>
- <version>1.1.1-SNAPSHOT</version>
- <relativePath>..</relativePath>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
--- End diff --
@ptgoetz
Fixing this to `../../pom.xml` resolved the error on `mvn clean install -DskipTests`. Please address this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2018: STORM-2416: Improve Release Packaging to Reduce Fi...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2018#discussion_r106831652
--- Diff: examples/storm-perf/pom.xml ---
@@ -22,8 +22,8 @@
<parent>
<artifactId>storm</artifactId>
<groupId>org.apache.storm</groupId>
- <version>1.1.1-SNAPSHOT</version>
- <relativePath>..</relativePath>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
--- End diff --
Maybe `../../pom.xml`?
(given that storm-perf compile is failing in Travis build... https://travis-ci.org/apache/storm/jobs/212268892)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2018: STORM-2416: Improve Release Packaging to Reduce File Size
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2018
Looks great otherwise. I'd be +1 once build issue is fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2018: STORM-2416: Improve Release Packaging to Reduce File Size
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2018
@HeartSaVioR Yes, that's my plan. I prioritized the 1.1.x branch since it's needed for the 1.1.0 release.
I'm not sure we want to apply it to the 1.0.x branch since we have a number of releases from that branch and this change would change the structure of the distribution. I could go either way, though, and am open to others' opinions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---