You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/04 05:56:58 UTC
[GitHub] [skywalking-website] vcjmhg opened a new pull request #163: Seems ambiguous
vcjmhg opened a new pull request #163:
URL: https://github.com/apache/skywalking-website/pull/163
In the section of `Crash Recovery`, should it be that Writed Offset(Watermark Offset) would override Writing Offset?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] EvanLjp commented on a change in pull request #163: Seems ambiguous
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #163:
URL: https://github.com/apache/skywalking-website/pull/163#discussion_r537468355
##########
File path: content/blog/2020-11-25-skywalking-satellite-0.1.0-design/index.md
##########
@@ -166,7 +166,7 @@ There are many cases of network congestion, such as the network problem on the h
### Crash Recovery
-The crash recovery only works when the user selects MmapQueue in Gatherer because of persistent file system design. When facing a crash, Reading Offset would be overridden by Committed Offset that ensure the at least once delivery. And Writed Offset would be overridden Writing Offset that ensures the consumer always works properly and avoid encountering uncrossable defective data blocks.
+The crash recovery only works when the user selects MmapQueue in Gatherer because of persistent file system design. When facing a crash, Reading Offset would be overridden by Committed Offset that ensure the at least once delivery. And Writed Offset would override Writing Offset that ensures the consumer always works properly and avoid encountering uncrossable defective data blocks.
Review comment:
I'm aware of that. this is my mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] EvanLjp commented on pull request #163: Seems ambiguous
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #163:
URL: https://github.com/apache/skywalking-website/pull/163#issuecomment-739885532
the original naming is Written offset, but some reviewers think Kafka has a similar concept, which is named as Watermark. @vcjmhg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] EvanLjp merged pull request #163: Seems ambiguous
Posted by GitBox <gi...@apache.org>.
EvanLjp merged pull request #163:
URL: https://github.com/apache/skywalking-website/pull/163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on a change in pull request #163: Seems ambiguous
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #163:
URL: https://github.com/apache/skywalking-website/pull/163#discussion_r537467243
##########
File path: content/blog/2020-11-25-skywalking-satellite-0.1.0-design/index.md
##########
@@ -166,7 +166,7 @@ There are many cases of network congestion, such as the network problem on the h
### Crash Recovery
-The crash recovery only works when the user selects MmapQueue in Gatherer because of persistent file system design. When facing a crash, Reading Offset would be overridden by Committed Offset that ensure the at least once delivery. And Writed Offset would be overridden Writing Offset that ensures the consumer always works properly and avoid encountering uncrossable defective data blocks.
+The crash recovery only works when the user selects MmapQueue in Gatherer because of persistent file system design. When facing a crash, Reading Offset would be overridden by Committed Offset that ensure the at least once delivery. And Writed Offset would override Writing Offset that ensures the consumer always works properly and avoid encountering uncrossable defective data blocks.
Review comment:
@EvanLjp I think the key is `be overridden` VS `override`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] EvanLjp removed a comment on pull request #163: Seems ambiguous
Posted by GitBox <gi...@apache.org>.
EvanLjp removed a comment on pull request #163:
URL: https://github.com/apache/skywalking-website/pull/163#issuecomment-739885532
the original naming is Written offset, but some reviewers think Kafka has a similar concept, which is named as Watermark. @vcjmhg That is the reason why the naming is Watermark offset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] EvanLjp edited a comment on pull request #163: Seems ambiguous
Posted by GitBox <gi...@apache.org>.
EvanLjp edited a comment on pull request #163:
URL: https://github.com/apache/skywalking-website/pull/163#issuecomment-739885532
the original naming is Written offset, but some reviewers think Kafka has a similar concept, which is named as Watermark. @vcjmhg That is the reason why the naming is Watermark offset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] EvanLjp commented on pull request #163: Seems ambiguous
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #163:
URL: https://github.com/apache/skywalking-website/pull/163#issuecomment-739889158
@vcjmhg thx for your notice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] EvanLjp edited a comment on pull request #163: Seems ambiguous
Posted by GitBox <gi...@apache.org>.
EvanLjp edited a comment on pull request #163:
URL: https://github.com/apache/skywalking-website/pull/163#issuecomment-739885532
the original naming is Written offset, but some reviewers think Kafka has a similar concept, which is named as Watermark. @vcjmhg That is the reason why the naming is Watermark offset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org