You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/11 11:48:20 UTC
[jira] [Commented] (NIFI-2684) Validation error messages should
refer to propertyDescriptor using its displayName
[ https://issues.apache.org/jira/browse/NIFI-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481620#comment-15481620 ]
ASF GitHub Bot commented on NIFI-2684:
--------------------------------------
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1002
NIFI-2684 - Change AbstractConfigurableComponent to use displayName w…
…hen available
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trixpan/nifi NIFI-2684
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1002.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1002
----
commit c6a36323ec73d1eb6744132857c2e86998678013
Author: Andre F de Miranda <tr...@users.noreply.github.com>
Date: 2016-09-11T11:45:02Z
NIFI-2684 - Change AbstractConfigurableComponent to use displayName when available
----
> Validation error messages should refer to propertyDescriptor using its displayName
> ----------------------------------------------------------------------------------
>
> Key: NIFI-2684
> URL: https://issues.apache.org/jira/browse/NIFI-2684
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Andre
> Assignee: Andre
> Fix For: 1.1.0
>
>
> When certain validation violation are triggered, {{AbstractConfigurableComponent}} refers to the descriptor using {{descriptor.getName()}}
> the result is that error messages end up referring to properties by sometimes cryptic names (instead of the "pretty names" defined in {{.displayName}} )
> Users would be better of if we used {{displayName}} on error messages when available, but to fallback to names in case displayName is null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)