You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2022/07/20 00:28:52 UTC
[superset] 01/01: remove condition and reference it in backend
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch fix-filter-query-explore
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 80e79af2360cc5593d79e467a9699e784373cdd9
Author: hughhhh <hu...@gmail.com>
AuthorDate: Tue Jul 19 20:27:21 2022 -0400
remove condition and reference it in backend
---
.../FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx
index 8bef83e9ba..910f7986fd 100644
--- a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx
+++ b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx
@@ -359,7 +359,7 @@ const AdhocFilterEditPopoverSimpleTabContent: React.FC<Props> = props => {
const col = props.adhocFilter.subject;
const having = props.adhocFilter.clause === CLAUSES.HAVING;
- if (col && datasource?.filter_select !== false && !having) {
+ if (col && datasource && datasource.filter_select && !having) {
const controller = new AbortController();
const { signal } = controller;
if (loadingComparatorSuggestions) {